Skip to contentSkip to conversation

filesystems: fix mount order

PATCH Applied Gary Thomas 2 participants 2 messages Jan 6, 2012

lore
Share & tools
lore
#0 lore raw

PATCH v2 1/1 filesystems: fix mount order

This changes the order that file system [types] are tried when using 'mount' in busybox when the file system type is not explictly specified. The pervious ordering is incorrect in that less capable file system types are tried first, e.g. ext2 before ext3, which will cause an ext3 file system to be mounted as ext2, disabling some of the ext3 features such as journaling.

The change also moves infrequently used file system types to the end as checking for them is just a waste of effort in most cases. The list now also includes ext4.

---
 .../recipes-core/base-files/base-files/filesystems |    9 +++++----
 1 files changed, 5 insertions(+), 4 deletions(-)
meta/recipes-core/base-files/base-files/filesystems +5 -4
index 2af6a7e..7e6c41c 100644
@@ -1,7 +1,8 @@
-minix
-fat
-vfat
-ext2
+ext4
 ext3
+ext2
+vfat
+fat
 btrfs
+minix
 *
Signature · 1 line
1.7.7.5
#1 lore raw
Quoted 8 lines · Gary Thomas

This changes the order that file system [types] are tried when using 'mount' in busybox when the file system type is not explictly specified. The pervious ordering is incorrect in that less capable file system types are tried first, e.g. ext2 before ext3, which will cause an ext3 file system to be mounted as ext2, disabling some of the ext3 features such as journaling.

Quoted 8 lines

The change also moves infrequently used file system types to the end as checking for them is just a waste of effort in most cases. The list now also includes ext4.

---
  .../recipes-core/base-files/base-files/filesystems |    9 +++++----
  1 files changed, 5 insertions(+), 4 deletions(-)

Merged to master, thanks.

I had to add a PR bump, mention base-files in the commit summary and for some reason the patch was corrupt and wouldn't apply either so I had to do so manually.

Cheers,

Richard