xserver-common: remove extraneous BSP customizations
PATCH 1/1 xserver-common: remove extraneous BSP customizations
* delete patches meant for BSP layers
* bump PR
--- .../Xserver.add.dpi.for.gta.patch | 29 ------------------ .../Xserver.add.nocursor.for.gta.patch | 20 ------------ .../xserver-common-1.34/Xserver.gta04.patch | 32 -------------------- .../xserver-common-1.34/Xserver.n900.patch | 17 ---------- .../xserver-common-1.34/Xserver.nexusone.patch | 14 -------- .../xserver-common-1.34/Xserver.nexuss.patch | 14 -------- .../xserver-common/xserver-common_1.34.bb | 8 +---- 7 files changed, 1 insertions(+), 133 deletions(-) delete mode 100644 meta-oe/recipes-graphics/xserver-common/xserver-common-1.34/Xserver.add.dpi.for.gta.patch delete mode 100644 meta-oe/recipes-graphics/xserver-common/xserver-common-1.34/Xserver.add.nocursor.for.gta.patch delete mode 100644 meta-oe/recipes-graphics/xserver-common/xserver-common-1.34/Xserver.gta04.patch delete mode 100644 meta-oe/recipes-graphics/xserver-common/xserver-common-1.34/Xserver.n900.patch delete mode 100644 meta-oe/recipes-graphics/xserver-common/xserver-common-1.34/Xserver.nexusone.patch delete mode 100644 meta-oe/recipes-graphics/xserver-common/xserver-common-1.34/Xserver.nexuss.patch
meta-oe/recipes-graphics/xserver-common/xserver-common-1.34/Xserver.add.dpi.for.gta.patch deleted +0 -29
@@ -1,29 +0,0 @@ -xdpyinfo returns 96, but 285 is right value (but 280 is used as it renders 4 columns of illume icons instead of 3 and empty space) - -diff -uNr xserver-common-1.33.orig//X11/xserver-common xserver-common-1.33/X11/xserver-common ---- xserver-common-1.33.orig//X11/xserver-common 2010-04-28 23:27:10.000000000 +0200 -+++ xserver-common-1.33/X11/xserver-common 2010-04-28 23:29:07.000000000 +0200 -@@ -133,19 +133,19 @@ - ARGS="$ARGS -screen ${SCREEN_SIZE}" - DPI="225" ;; - "gta01" ) -- DPI="285" -+ DPI="280" - if [ "$XSERVER" != "Xorg" ] ; then - ARGS="$ARGS -screen 480x640" - else -- ARGS="$ARGS -nocursor" -+ ARGS="$ARGS -dpi ${DPI} -nocursor" - fi - ;; - "gta02") -- DPI="285" -+ DPI="280" - if [ "$XSERVER" != "Xorg" ] ; then - ARGS="$ARGS -screen ${SCREEN_SIZE}" - else -- ARGS="$ARGS -nocursor" -+ ARGS="$ARGS -dpi ${DPI} -nocursor" - fi - ;; - "motorola_ezx_platform")
meta-oe/recipes-graphics/xserver-common/xserver-common-1.34/Xserver.add.nocursor.for.gta.patch deleted +0 -20
@@ -1,20 +0,0 @@ -diff -uNr xserver-common-1.33.orig//X11/xserver-common xserver-common-1.33/X11/xserver-common ---- xserver-common-1.33.orig//X11/xserver-common 2010-04-28 10:44:23.000000000 +0200 -+++ xserver-common-1.33/X11/xserver-common 2010-04-28 10:46:41.000000000 +0200 -@@ -136,12 +136,16 @@ - DPI="285" - if [ "$XSERVER" != "Xorg" ] ; then - ARGS="$ARGS -screen 480x640" -+ else -+ ARGS="$ARGS -nocursor" - fi - ;; - "gta02") - DPI="285" - if [ "$XSERVER" != "Xorg" ] ; then - ARGS="$ARGS -screen ${SCREEN_SIZE}" -+ else -+ ARGS="$ARGS -nocursor" - fi - ;; - "motorola_ezx_platform")
meta-oe/recipes-graphics/xserver-common/xserver-common-1.34/Xserver.gta04.patch deleted +0 -32
@@ -1,32 +0,0 @@ -From 95d741d6849a2faddf8c1e930c7250ead90e7bed Mon Sep 17 00:00:00 2001 -From: Klaus Kurzmann <[email protected]> -Date: Thu, 20 Oct 2011 09:05:43 +0200 -Subject: [PATCH] gta04 - -Signed-off-by: Klaus Kurzmann <[email protected]> ---- - X11/xserver-common | 8 ++++++++ - 1 files changed, 8 insertions(+), 0 deletions(-) - -diff --git a/X11/xserver-common b/X11/xserver-common -index 448b262..208bbfd 100644 ---- a/X11/xserver-common -+++ b/X11/xserver-common -@@ -161,6 +161,14 @@ else - ARGS="$ARGS -dpi ${DPI} -nocursor" - fi - ;; -+ "gta04") -+ DPI="280" -+ if [ "$XSERVER" != "Xorg" ] ; then -+ ARGS="$ARGS -screen ${SCREEN_SIZE}" -+ else -+ ARGS="$ARGS -dpi ${DPI} -nocursor" -+ fi -+ ;; - "motorola_ezx_platform") - ARGS="$ARGS -screen 240x320" - DPI="170" ;; --- -1.7.7 -
meta-oe/recipes-graphics/xserver-common/xserver-common-1.34/Xserver.n900.patch deleted +0 -17
@@ -1,17 +0,0 @@ -diff -uri xserver-common-1.33.orig/X11/xserver-common xserver-common-1.33/X11/xserver-common ---- xserver-common-1.33.orig/X11/xserver-common 2010-09-14 17:10:35.955430177 +0200 -+++ xserver-common-1.33/X11/xserver-common 2010-09-14 17:17:12.484423440 +0200 -@@ -132,6 +132,13 @@ - "nokia_n800" | "nokia_rx-44" | "nokia_n770") - ARGS="$ARGS -screen ${SCREEN_SIZE}" - DPI="225" ;; -+ "nokia_rx-51_board" ) -+ DPI="267" -+ if [ "$XSERVER" != "Xorg" ] ; then -+ ARGS="$ARGS -screen ${SCREEN_SIZE}" -+ else -+ ARGS="$ARGS -dpi ${DPI} -nocursor" -+ fi ;; - "gta01" ) - DPI="280" - if [ "$XSERVER" != "Xorg" ] ; then
meta-oe/recipes-graphics/xserver-common/xserver-common-1.34/Xserver.nexusone.patch deleted +0 -14
@@ -1,14 +0,0 @@ -Index: xserver-common-1.34/X11/xserver-common -=================================================================== ---- xserver-common-1.34.orig/X11/xserver-common 2011-10-10 22:36:14.163129002 +0200 -+++ xserver-common-1.34/X11/xserver-common 2011-10-10 22:37:47.513129001 +0200 -@@ -129,6 +129,9 @@ - "herring") - DPI="235" - ARGS="$ARGS -dpi ${DPI} -nocursor";; -+ "mahimahi") -+ DPI="254" -+ ARGS="$ARGS -dpi ${DPI}";; - "generic_omap1510/1610/1710") - ARGS="$ARGS -screen ${SCREEN_SIZE}" - DPI="225" ;;
meta-oe/recipes-graphics/xserver-common/xserver-common-1.34/Xserver.nexuss.patch deleted +0 -14
@@ -1,14 +0,0 @@ -Index: xserver-common-1.34/X11/xserver-common -=================================================================== ---- xserver-common-1.34.orig/X11/xserver-common 2011-10-09 14:57:10.716896996 +0200 -+++ xserver-common-1.34/X11/xserver-common 2011-10-09 14:57:31.226897012 +0200 -@@ -126,6 +126,9 @@ - "htc_tornado") - ARGS="$ARGS -hide-cursor" - DPI="100" ;; -+ "herring") -+ DPI="235" -+ ARGS="$ARGS -dpi ${DPI} -nocursor";; - "generic_omap1510/1610/1710") - ARGS="$ARGS -screen ${SCREEN_SIZE}" - DPI="225" ;;
meta-oe/recipes-graphics/xserver-common/xserver-common_1.34.bb +1 -7
@@ -2,7 +2,7 @@ DESCRIPTION = "Common X11 scripts and support files" LICENSE = "GPLv2" LIC_FILES_CHKSUM = "file://COPYING;md5=751419260aa954499f7abaabaa882bbe" -PR = "r5" +PR = "r6" # we are using a gpe-style Makefile inherit gpe
@@ -17,12 +17,6 @@ SRC_URI_append = " \ file://89xTs_Calibrate.xinput_calibrator.patch \ file://90xXWindowManager.patch \ file://Xserver.add.xserver-system.patch \ - file://Xserver.add.nocursor.for.gta.patch \ - file://Xserver.add.dpi.for.gta.patch \ - file://Xserver.n900.patch \ - file://Xserver.nexuss.patch \ - file://Xserver.nexusone.patch \ - file://Xserver.gta04.patch \ "
Signature · 1 line
1.7.3.4
Quoted 1 line · Andrea Adami
* delete patches meant for BSP layers
will you send patches adding it back to those BSP layers, please?
Quoted 215 lines
* bump PR
Signed-off-by Andrea Adami <[email protected]>--- .../Xserver.add.dpi.for.gta.patch | 29 ------------------ .../Xserver.add.nocursor.for.gta.patch | 20 ------------ .../xserver-common-1.34/Xserver.gta04.patch | 32 -------------------- .../xserver-common-1.34/Xserver.n900.patch | 17 ---------- .../xserver-common-1.34/Xserver.nexusone.patch | 14 -------- .../xserver-common-1.34/Xserver.nexuss.patch | 14 -------- .../xserver-common/xserver-common_1.34.bb | 8 +---- 7 files changed, 1 insertions(+), 133 deletions(-) delete mode 100644 meta-oe/recipes-graphics/xserver-common/xserver-common-1.34/Xserver.add.dpi.for.gta.patch delete mode 100644 meta-oe/recipes-graphics/xserver-common/xserver-common-1.34/Xserver.add.nocursor.for.gta.patch delete mode 100644 meta-oe/recipes-graphics/xserver-common/xserver-common-1.34/Xserver.gta04.patch delete mode 100644 meta-oe/recipes-graphics/xserver-common/xserver-common-1.34/Xserver.n900.patch delete mode 100644 meta-oe/recipes-graphics/xserver-common/xserver-common-1.34/Xserver.nexusone.patch delete mode 100644 meta-oe/recipes-graphics/xserver-common/xserver-common-1.34/Xserver.nexuss.patchmeta-oe/recipes-graphics/xserver-common/xserver-common-1.34/Xserver.add.dpi.for.gta.patch deleted +0
-29@@ -1,29 +0,0 @@ -xdpyinfo returns 96, but 285 is right value (but 280 is used as it renders 4 columns of illume icons instead of 3 and empty space) - -diff -uNr xserver-common-1.33.orig//X11/xserver-common xserver-common-1.33/X11/xserver-common ---- xserver-common-1.33.orig//X11/xserver-common 2010-04-28 23:27:10.000000000 +0200 -+++ xserver-common-1.33/X11/xserver-common 2010-04-28 23:29:07.000000000 +0200 -@@ -133,19 +133,19 @@ - ARGS="$ARGS -screen ${SCREEN_SIZE}" - DPI="225" ;; - "gta01" ) -- DPI="285" -+ DPI="280" - if [ "$XSERVER" != "Xorg" ] ; then - ARGS="$ARGS -screen 480x640" - else -- ARGS="$ARGS -nocursor" -+ ARGS="$ARGS -dpi ${DPI} -nocursor" - fi - ;; - "gta02") -- DPI="285" -+ DPI="280" - if [ "$XSERVER" != "Xorg" ] ; then - ARGS="$ARGS -screen ${SCREEN_SIZE}" - else -- ARGS="$ARGS -nocursor" -+ ARGS="$ARGS -dpi ${DPI} -nocursor" - fi - ;; - "motorola_ezx_platform")meta-oe/recipes-graphics/xserver-common/xserver-common-1.34/Xserver.add.nocursor.for.gta.patch deleted +0
-20@@ -1,20 +0,0 @@ -diff -uNr xserver-common-1.33.orig//X11/xserver-common xserver-common-1.33/X11/xserver-common ---- xserver-common-1.33.orig//X11/xserver-common 2010-04-28 10:44:23.000000000 +0200 -+++ xserver-common-1.33/X11/xserver-common 2010-04-28 10:46:41.000000000 +0200 -@@ -136,12 +136,16 @@ - DPI="285" - if [ "$XSERVER" != "Xorg" ] ; then - ARGS="$ARGS -screen 480x640" -+ else -+ ARGS="$ARGS -nocursor" - fi - ;; - "gta02") - DPI="285" - if [ "$XSERVER" != "Xorg" ] ; then - ARGS="$ARGS -screen ${SCREEN_SIZE}" -+ else -+ ARGS="$ARGS -nocursor" - fi - ;; - "motorola_ezx_platform")meta-oe/recipes-graphics/xserver-common/xserver-common-1.34/Xserver.gta04.patch deleted +0
-32@@ -1,32 +0,0 @@ -From 95d741d6849a2faddf8c1e930c7250ead90e7bed Mon Sep 17 00:00:00 2001 -From: Klaus Kurzmann <[email protected]> -Date: Thu, 20 Oct 2011 09:05:43 +0200 -Subject: [PATCH] gta04 - -Signed-off-by: Klaus Kurzmann <[email protected]> ---- - X11/xserver-common | 8 ++++++++ - 1 files changed, 8 insertions(+), 0 deletions(-) - -diff --git a/X11/xserver-common b/X11/xserver-common -index 448b262..208bbfd 100644 ---- a/X11/xserver-common -+++ b/X11/xserver-common -@@ -161,6 +161,14 @@ else - ARGS="$ARGS -dpi ${DPI} -nocursor" - fi - ;; -+ "gta04") -+ DPI="280" -+ if [ "$XSERVER" != "Xorg" ] ; then -+ ARGS="$ARGS -screen ${SCREEN_SIZE}" -+ else -+ ARGS="$ARGS -dpi ${DPI} -nocursor" -+ fi -+ ;; - "motorola_ezx_platform") - ARGS="$ARGS -screen 240x320" - DPI="170" ;; --- -1.7.7 -meta-oe/recipes-graphics/xserver-common/xserver-common-1.34/Xserver.n900.patch deleted +0
-17@@ -1,17 +0,0 @@ -diff -uri xserver-common-1.33.orig/X11/xserver-common xserver-common-1.33/X11/xserver-common ---- xserver-common-1.33.orig/X11/xserver-common 2010-09-14 17:10:35.955430177 +0200 -+++ xserver-common-1.33/X11/xserver-common 2010-09-14 17:17:12.484423440 +0200 -@@ -132,6 +132,13 @@ - "nokia_n800" | "nokia_rx-44" | "nokia_n770") - ARGS="$ARGS -screen ${SCREEN_SIZE}" - DPI="225" ;; -+ "nokia_rx-51_board" ) -+ DPI="267" -+ if [ "$XSERVER" != "Xorg" ] ; then -+ ARGS="$ARGS -screen ${SCREEN_SIZE}" -+ else -+ ARGS="$ARGS -dpi ${DPI} -nocursor" -+ fi ;; - "gta01" ) - DPI="280" - if [ "$XSERVER" != "Xorg" ] ; thenmeta-oe/recipes-graphics/xserver-common/xserver-common-1.34/Xserver.nexusone.patch deleted +0
-14@@ -1,14 +0,0 @@ -Index: xserver-common-1.34/X11/xserver-common -=================================================================== ---- xserver-common-1.34.orig/X11/xserver-common 2011-10-10 22:36:14.163129002 +0200 -+++ xserver-common-1.34/X11/xserver-common 2011-10-10 22:37:47.513129001 +0200 -@@ -129,6 +129,9 @@ - "herring") - DPI="235" - ARGS="$ARGS -dpi ${DPI} -nocursor";; -+ "mahimahi") -+ DPI="254" -+ ARGS="$ARGS -dpi ${DPI}";; - "generic_omap1510/1610/1710") - ARGS="$ARGS -screen ${SCREEN_SIZE}" - DPI="225" ;;meta-oe/recipes-graphics/xserver-common/xserver-common-1.34/Xserver.nexuss.patch deleted +0
-14@@ -1,14 +0,0 @@ -Index: xserver-common-1.34/X11/xserver-common -=================================================================== ---- xserver-common-1.34.orig/X11/xserver-common 2011-10-09 14:57:10.716896996 +0200 -+++ xserver-common-1.34/X11/xserver-common 2011-10-09 14:57:31.226897012 +0200 -@@ -126,6 +126,9 @@ - "htc_tornado") - ARGS="$ARGS -hide-cursor" - DPI="100" ;; -+ "herring") -+ DPI="235" -+ ARGS="$ARGS -dpi ${DPI} -nocursor";; - "generic_omap1510/1610/1710") - ARGS="$ARGS -screen ${SCREEN_SIZE}" - DPI="225" ;;meta-oe/recipes-graphics/xserver-common/xserver-common_1.34.bb +1
-7@@ -2,7 +2,7 @@ DESCRIPTION = "Common X11 scripts and support files" LICENSE = "GPLv2" LIC_FILES_CHKSUM = "file://COPYING;md5=751419260aa954499f7abaabaa882bbe" -PR = "r5" +PR = "r6" # we are using a gpe-style Makefile inherit gpe@@ -17,12 +17,6 @@ SRC_URI_append = " \ file://89xTs_Calibrate.xinput_calibrator.patch \ file://90xXWindowManager.patch \ file://Xserver.add.xserver-system.patch \ - file://Xserver.add.nocursor.for.gta.patch \ - file://Xserver.add.dpi.for.gta.patch \ - file://Xserver.n900.patch \ - file://Xserver.nexuss.patch \ - file://Xserver.nexusone.patch \ - file://Xserver.gta04.patch \ "Signature · 7 lines
1.7.3.4 _______________________________________________ Openembedded-devel mailing list [email protected] http://lists.linuxtogo.org/cgi-bin/mailman/listinfo/openembedded-devel
Signature · 1 line
Martin 'JaMa' Jansa jabber: [email protected]
-----BEGIN PGP SIGNED MESSAGE-----
Hash: SHA1
Op 07-01-12 00:55, Andrea Adami schreef:
Quoted 1 line
* delete patches meant for BSP layers * bump PR
With a recipe like xserver-common I don't see a point in going all out BSP on it. This patch just moves things to layers just for the sake of moving it to layers. I strongly suspect that applying this patch will be a net burden on device maintainers instead of a gain.
-----BEGIN PGP SIGNATURE-----
Version: GnuPG v1.4.11 (Darwin)
Comment: GPGTools - http://gpgtools.org
iEYEARECAAYFAk8H/NIACgkQMkyGM64RGpEvwACfRRHrwdZqrc3UrqSNvEOPvh8w kIoAn2Wpy6va4V/Y369vSwDj7AcZLuNO
=oYt/
-----END PGP SIGNATURE-----
Quoted 12 lines · Koen Kooi
-----BEGIN PGP SIGNED MESSAGE-----
Hash: SHA1Op 07-01-12 00:55, Andrea Adami schreef:
Quoted 1 line
* delete patches meant for BSP layers * bump PR
With a recipe like xserver-common I don't see a point in going all out BSP on it. This patch just moves things to layers just for the sake of moving it
to layers. I strongly suspect that applying this patch will be a net burden on device maintainers instead of a gain.
I agree this is going to be bad at first but those kind of improvements always cause some problems for a later gain. Dropping things that ought to be in BSP layers is a good thing but only after the "fix other layers" time window.
I think this is worth it however it might be better to instead port the needed changes to OE-Core and ask other layers to adopt x11-common allowing us to remove this later on. This makes the change easier and avoid some problems for users IMO.
Signature · 3 lines
Otavio Salvador O.S. Systems E-mail: [email protected] http://www.ossystems.com.br Mobile: +55 53 9981-7854 http://projetos.ossystems.com.br
Quoted 20 lines · Otavio Salvador
Quoted 12 lines · Koen Kooi
-----BEGIN PGP SIGNED MESSAGE-----
Hash: SHA1Op 07-01-12 00:55, Andrea Adami schreef:
Quoted 1 line
* delete patches meant for BSP layers * bump PR
With a recipe like xserver-common I don't see a point in going all out BSP on it. This patch just moves things to layers just for the sake of moving it
to layers. I strongly suspect that applying this patch will be a net burden on device maintainers instead of a gain.I agree this is going to be bad at first but those kind of improvements always cause some problems for a later gain. Dropping things that ought to be in BSP layers is a good thing but only after the "fix other layers" time window.
Quoted 4 lines
I think this is worth it however it might be better to instead port the needed changes to OE-Core and ask other layers to adopt x11-common allowing us to remove this later on. This makes the change easier and avoid some problems for users IMO.
This whole recipe has machine specific bits and removing those bits only of some machines (in this case all from meta-smartphone BSPs) doesn't improve that recipe.
So if you want to improve it, merge extra functionality (like xinput-pointercal) to oe-core and drop this completely, but breaking some machines doesn't make thinks better.
Instead of "fixing" it in meta-smartphone BSPs I would just copy whole xserver-common back to meta-shr, because I don't have time now to fix it properly and spending time on .bbappends is not worth it in this case.
Cheers,
JaMa, from daywork..ffs
Quoted 38 lines · Martin Jansa
Quoted 20 lines · Otavio Salvador
Quoted 12 lines · Koen Kooi
-----BEGIN PGP SIGNED MESSAGE-----
Hash: SHA1Op 07-01-12 00:55, Andrea Adami schreef:
Quoted 1 line
* delete patches meant for BSP layers * bump PR
With a recipe like xserver-common I don't see a point in going all out BSP on it. This patch just moves things to layers just for the sake of moving it
to layers. I strongly suspect that applying this patch will be a net burden on device maintainers instead of a gain.I agree this is going to be bad at first but those kind of improvements always cause some problems for a later gain. Dropping things that ought to be in BSP layers is a good thing but only after the "fix other layers" time window.
Quoted 4 lines
I think this is worth it however it might be better to instead port the needed changes to OE-Core and ask other layers to adopt x11-common allowing us to remove this later on. This makes the change easier and avoid some problems for users IMO.
This whole recipe has machine specific bits and removing those bits only of some machines (in this case all from meta-smartphone BSPs) doesn't improve that recipe.
So if you want to improve it, merge extra functionality (like xinput-pointercal) to oe-core and drop this completely, but breaking some machines doesn't make thinks better.
Instead of "fixing" it in meta-smartphone BSPs I would just copy whole xserver-common back to meta-shr, because I don't have time now to fix it properly and spending time on .bbappends is not worth it in this case.
Quoted 9 lines
Cheers,
JaMa, from daywork..ffs
_______________________________________________
Openembedded-devel mailing list
[email protected]
http://lists.linuxtogo.org/cgi-bin/mailman/listinfo/openembedded-devel
I try to explain again my intent:
1) we have at the moment two xserver-nodm-init, one in meta-oe and one in oe-core
2) this is intrinsecaly bad and moreover the two recipes are totally different with regards to runtime dependencies
3) as it is now, oe-core expects to use x11-common while in meta-oe there is xserver-common
4) xserver-common is an old recipe coming from the oe-classic times, designed to work with gpe environments and targeting mostly kdrive. Thius recipe contains alot of BSP code.
5) today, if one builds core-image-sato distroless for zaurus qvga using meta-oe the xserver won't start because of the bad settings provided by the recipe.
So, I already sent a msg in that regard before (
http://lists.linuxtogo.org/pipermail/openembedded-devel/2011-October/035564.html
) and now I'm trying to help cleaning both sides.
The patch for x11-common was taken in oe-core but this one for meta-oe is unexpectedly under discussion.
BE sure my intentions are not to increase maintenance burden, on the opposite I'd like neutral/sane defaults and patches to override those in the BSP layers.
Regards
Andrea
Quoted 5 lines · Andrea Adami
I try to explain again my intent:
1) we have at the moment two xserver-nodm-init, one in meta-oe and one in oe-core
Yes and we ought to sort it out and merge meta-oe improvements on oe-core one.
Quoted 1 line
...
3) as it is now, oe-core expects to use x11-common while in meta-oe
Quoted 2 lines
there is xserver-common
This is the real point. Instead of changing xserver-common the right way of fixing it is porting changes need to x11-common and drop xserver-common from meta-oe afterwards. This will reduce the delta between oe-core and meta-oe plus making sane defaults working out of box :-)
Signature · 3 lines
Otavio Salvador O.S. Systems E-mail: [email protected] http://www.ossystems.com.br Mobile: +55 53 9981-7854 http://projetos.ossystems.com.br
Quoted 49 lines · Andrea Adami
Quoted 38 lines · Martin Jansa
Quoted 20 lines · Otavio Salvador
Quoted 12 lines · Koen Kooi
-----BEGIN PGP SIGNED MESSAGE-----
Hash: SHA1Op 07-01-12 00:55, Andrea Adami schreef:
Quoted 1 line
* delete patches meant for BSP layers * bump PR
With a recipe like xserver-common I don't see a point in going all out BSP on it. This patch just moves things to layers just for the sake of moving it
to layers. I strongly suspect that applying this patch will be a net burden on device maintainers instead of a gain.I agree this is going to be bad at first but those kind of improvements always cause some problems for a later gain. Dropping things that ought to be in BSP layers is a good thing but only after the "fix other layers" time window.
Quoted 4 lines
I think this is worth it however it might be better to instead port the needed changes to OE-Core and ask other layers to adopt x11-common allowing us to remove this later on. This makes the change easier and avoid some problems for users IMO.
This whole recipe has machine specific bits and removing those bits only of some machines (in this case all from meta-smartphone BSPs) doesn't improve that recipe.
So if you want to improve it, merge extra functionality (like xinput-pointercal) to oe-core and drop this completely, but breaking some machines doesn't make thinks better.
Instead of "fixing" it in meta-smartphone BSPs I would just copy whole xserver-common back to meta-shr, because I don't have time now to fix it properly and spending time on .bbappends is not worth it in this case.
Quoted 9 lines
Cheers,
JaMa, from daywork..ffs
_______________________________________________
Openembedded-devel mailing list
[email protected]
http://lists.linuxtogo.org/cgi-bin/mailman/listinfo/openembedded-devel
Quoted 6 lines
I try to explain again my intent:
1) we have at the moment two xserver-nodm-init, one in meta-oe and one in oe-core
2) this is intrinsecaly bad and moreover the two recipes are totally different with regards to runtime dependencies
I'm aware of that and said that many times, just to busy with daywork (in last couple of months) to fix it myself ;/.
Quoted 2 lines
3) as it is now, oe-core expects to use x11-common while in meta-oe there is xserver-common
I've already explained to you to use VIRTUAL_RUNTIME vars.
Quoted 3 lines
4) xserver-common is an old recipe coming from the oe-classic times, designed to work with gpe environments and targeting mostly kdrive. Thius recipe contains alot of BSP code.
Yes and those patches you've removed are not making it worse, upstream script contains a lot of BSP code already and those patches are just making it more complete (think about it as patch which should be applied upstream not in BSP layer).
Quoted 3 lines
5) today, if one builds core-image-sato distroless for zaurus qvga using meta-oe the xserver won't start because of the bad settings provided by the recipe.
see A3).
Quoted 8 lines
So, I already sent a msg in that regard before (
http://lists.linuxtogo.org/pipermail/openembedded-devel/2011-October/035564.html
) and now I'm trying to help cleaning both sides.
The patch for x11-common was taken in oe-core but this one for meta-oe is unexpectedly under discussion.
BE sure my intentions are not to increase maintenance burden, on the opposite I'd like neutral/sane defaults and patches to override those in the BSP layers.
burden is to force people to fix recipe which should be removed instead.
Regards,
Signature · 1 line
Martin 'JaMa' Jansa jabber: [email protected]
Quoted 57 lines · Martin Jansa
Quoted 49 lines · Andrea Adami
Quoted 38 lines · Martin Jansa
Quoted 20 lines · Otavio Salvador
Quoted 12 lines · Koen Kooi
-----BEGIN PGP SIGNED MESSAGE-----
Hash: SHA1Op 07-01-12 00:55, Andrea Adami schreef:
Quoted 1 line
* delete patches meant for BSP layers * bump PR
With a recipe like xserver-common I don't see a point in going all out BSP on it. This patch just moves things to layers just for the sake of moving it
to layers. I strongly suspect that applying this patch will be a net burden on device maintainers instead of a gain.I agree this is going to be bad at first but those kind of improvements always cause some problems for a later gain. Dropping things that ought to be in BSP layers is a good thing but only after the "fix other layers" time window.
Quoted 4 lines
I think this is worth it however it might be better to instead port the needed changes to OE-Core and ask other layers to adopt x11-common allowing us to remove this later on. This makes the change easier and avoid some problems for users IMO.
This whole recipe has machine specific bits and removing those bits only of some machines (in this case all from meta-smartphone BSPs) doesn't improve that recipe.
So if you want to improve it, merge extra functionality (like xinput-pointercal) to oe-core and drop this completely, but breaking some machines doesn't make thinks better.
Instead of "fixing" it in meta-smartphone BSPs I would just copy whole xserver-common back to meta-shr, because I don't have time now to fix it properly and spending time on .bbappends is not worth it in this case.
Quoted 9 lines
Cheers,
JaMa, from daywork..ffs
_______________________________________________
Openembedded-devel mailing list
[email protected]
http://lists.linuxtogo.org/cgi-bin/mailman/listinfo/openembedded-develQuoted 6 lines
I try to explain again my intent:
1) we have at the moment two xserver-nodm-init, one in meta-oe and one in oe-core
2) this is intrinsecaly bad and moreover the two recipes are totally different with regards to runtime dependencies
Quoted 7 lines
I'm aware of that and said that many times, just to busy with daywork (in last couple of months) to fix it myself ;/.
Quoted 2 lines
3) as it is now, oe-core expects to use x11-common while in meta-oe there is xserver-common
I've already explained to you to use
VIRTUAL_RUNTIMEvars.
Sorry but this is not enough in order to obtain a core-image-sato with working xserver on first run.
The meta-oe layer is 'toxic' in that regard.
Quoted 10 lines
Quoted 4 lines
4) xserver-common is an old recipe coming from the oe-classic times, designed to work with gpe environments and targeting mostly kdrive. Thius recipe contains alot of BSP code.
Yes and those patches you've removed are not making it worse, upstream script contains a lot of BSP code already and those patches are just making it more complete (think about it as patch which should be applied upstream not in BSP layer).
Those patches ought to be sent upstream long agoi... I'm sure Florian will apply almost immediately once aware.
Quoted 15 lines
Quoted 3 lines
5) today, if one builds core-image-sato distroless for zaurus qvga using meta-oe the xserver won't start because of the bad settings provided by the recipe.
see A3).
Quoted 8 lines
So, I already sent a msg in that regard before (
http://lists.linuxtogo.org/pipermail/openembedded-devel/2011-October/035564.html
) and now I'm trying to help cleaning both sides.
The patch for x11-common was taken in oe-core but this one for meta-oe is unexpectedly under discussion.
BE sure my intentions are not to increase maintenance burden, on the opposite I'd like neutral/sane defaults and patches to override those in the BSP layers.
Quoted 2 lines
burden is to force people to fix recipe which should be removed instead.
This is my last reply to this thread.
Again I'm sorry to force maintainers of external layers to react and make hanges but there is anything wrong with this.
We did agree the policy of meta-oe is the same of oe-core, thus no BSP code is allowed. Stop.
I'd expect the maintainer agrees.
Cheers
Andrea
Quoted 10 lines
Regards,
--
Martin 'JaMa' Jansa jabber: [email protected]_______________________________________________
Openembedded-devel mailing list
[email protected]
http://lists.linuxtogo.org/cgi-bin/mailman/listinfo/openembedded-devel
Quoted 5 lines · Andrea Adami
Quoted 1 line
I've already explained to you to use
VIRTUAL_RUNTIMEvars.Sorry but this is not enough in order to obtain a core-image-sato with working xserver on first run.
The meta-oe layer is 'toxic' in that regard.
Agreed; that's why I said you could fix x11-common and make it work so we can drop xserver-common from meta-oe.
Quoted 33 lines
Quoted 9 lines
Quoted 3 lines
4) xserver-common is an old recipe coming from the oe-classic times, designed to work with gpe environments and targeting mostly kdrive. Thius recipe contains alot of BSP code.
Yes and those patches you've removed are not making it worse, upstream script contains a lot of BSP code already and those patches are just making it more complete (think about it as patch which should be applied upstream not in BSP layer).
Those patches ought to be sent upstream long agoi... I'm sure Florian will apply almost immediately once aware.
Quoted 8 lines
Quoted 3 lines
5) today, if one builds core-image-sato distroless for zaurus qvga using meta-oe the xserver won't start because of the bad settings provided by the recipe.
see A3).
Quoted 2 lines
So, I already sent a msg in that regard before (
http://lists.linuxtogo.org/pipermail/openembedded-devel/2011-October/035564.html
Quoted 9 lines
Quoted 6 lines
) and now I'm trying to help cleaning both sides.
The patch for x11-common was taken in oe-core but this one for meta-oe is unexpectedly under discussion.
BE sure my intentions are not to increase maintenance burden, on the opposite I'd like neutral/sane defaults and patches to override those in the BSP layers.burden is to force people to fix recipe which should be removed instead.
Quoted 7 lines
This is my last reply to this thread.
Again I'm sorry to force maintainers of external layers to react and make hanges but there is anything wrong with this.
We did agree the policy of meta-oe is the same of oe-core, thus no BSP code is allowed. Stop.
I'd expect the maintainer agrees.
I think you missunderstood it. We are not saying it shouldn't be removed but we're saying we ought to do that in another way.
This will be removed all together with xserver-common in the move to x11-common but for this, x11-common need to have the improvements done on xserver-common merged.
Signature · 3 lines
Otavio Salvador O.S. Systems E-mail: [email protected] http://www.ossystems.com.br Mobile: +55 53 9981-7854 http://projetos.ossystems.com.br