acer-wmi: check wireless capability on AMW0_GUID2 machines

From: "Lee, Chun-Yi" <[email protected]>

Have many non-acer machines have AMW0_GUID2 method in DSDT, in original acer-wmi design, driver direct set ACER_CAP_WIRELESS flag for those machines but didn't check the functionality for set/get wireless state.
It causes acer-wmi driver create a broken wireless rfkill and it already set to soft blocked.

So, this patch add a wireless capability check before we set ACER_CAP_WIRELESS flag to the machines that were included AMW0_GUID2. It avoid acer-wmi create a broken wireless rfkill.

Thank's for Matthew Garrett give the idea.

Reference: brc#674353

        https://bugzilla.redhat.com/show_bug.cgi?id=674353

Tested on Lenovo E520.
Tested on Acer TravelMate 4750.

Quoted 13 lines

From: "Lee, Chun-Yi" <[email protected]>

Have many non-acer machines have AMW0_GUID2 method in DSDT, in original acer-wmi design, driver direct set ACER_CAP_WIRELESS flag for those machines but didn't check the functionality for set/get wireless state.
It causes acer-wmi driver create a broken wireless rfkill and it already set to soft blocked.

So, this patch add a wireless capability check before we set ACER_CAP_WIRELESS flag to the machines that were included AMW0_GUID2. It avoid acer-wmi create a broken wireless rfkill.

Quoted 7 lines

Thank's for Matthew Garrett give the idea.

Reference: brc#674353

        https://bugzilla.redhat.com/show_bug.cgi?id=674353

Tested on Lenovo E520.
Tested on Acer TravelMate 4750.

Is there really no other way to detect the availability of wireless on hardware with that GUID without resorting to poking stuff to see if it sticks?

My assumption has always been that there must be of finding out, but I've never had the hardware to check that with.

-Carlos

I just checked and found I also have no AMW0_GUID2 machines on my hand, now.
I have some questions about AMW0_GUID2:

+ Why we enabled wireless capability in acer-wim if a non-acer machine has
AMW0_GUID2 ?

+ I saw there have some magic number when you access AMW0_GUID1 (e.g.
0x9610, eax, ebx, ecx) Could you please kindly teach me how can grab those value for AMW0_GUID2? Does there have any useful dump or report log can provide by hardware owner?

Quoted 4 lines

I just checked and found I also have no AMW0_GUID2 machines on my hand, now.
I have some questions about AMW0_GUID2:

Quoted 2 lines

+ Why we enabled wireless capability in acer-wim if a non-acer machine has
AMW0_GUID2 ?

IIRC, there were some bug reports on non-Acer hardware (I don't think this involved Acer hardware, but this was some time ago...) where the wireless detection wasn't working with this, but if we forced it on, it worked fine.

Quoted 4 lines

+ I saw there have some magic number when you access AMW0_GUID1 (e.g.
0x9610, eax, ebx, ecx) Could you please kindly teach me how can grab those value for AMW0_GUID2? Does there have any useful dump or report log can provide by hardware owner?

Probably not. For AMW0_GUID1, I got the stuff by using the Windows Kernel Debugger remotely to see what my laptop was doing when changing things in Windows - unfortunately that relied on a firewire port on the laptop, which I suspect most people don't have.

The real problem is that I know almost nothing about AMW0_GUID2 - either what it's used for or what it actually does, nor how hardware detection works with it present (if at all).

-Carlos

於 一，2012-01-09 於 22:15 +0000，Carlos Corbacho 提到：

Quoted 5 lines · On Monday 09 Jan 2012 18:00:24 joeyli wrote:

Quoted 4 lines

I just checked and found I also have no AMW0_GUID2 machines on my hand, now.
I have some questions about AMW0_GUID2:

Quoted 7 lines

Quoted 2 lines

+ Why we enabled wireless capability in acer-wim if a non-acer machine has
AMW0_GUID2 ?

IIRC, there were some bug reports on non-Acer hardware (I don't think this involved Acer hardware, but this was some time ago...) where the wireless detection wasn't working with this, but if we forced it on, it worked fine.

Yes, in acer-wmi supported some non-acer machine by quirk and read EC register. That means we need find out EC register reflect to wifi RF state if we are lucky.

Unfortunately, direct enable wireless capability causes some non-acer machines' wireless rfkill always disabled. e.g. Lenovo E520

https://bugzilla.redhat.com/show_bug.cgi?id=674353

If we don't check the wireless capability, then they need manually add acer-wmi to backlist. On some lenovo machines, ideapad-laptop driver should support by lenovo's ACPI method.

Quoted 21 lines

於 一，2012-01-09 於 22:15 +0000，Carlos Corbacho 提到：

Quoted 5 lines · On Monday 09 Jan 2012 18:00:24 joeyli wrote:

Quoted 4 lines

I just checked and found I also have no AMW0_GUID2 machines on my hand, now.
I have some questions about AMW0_GUID2:

Quoted 7 lines

Quoted 2 lines

+ Why we enabled wireless capability in acer-wim if a non-acer machine has
AMW0_GUID2 ?

IIRC, there were some bug reports on non-Acer hardware (I don't think this involved Acer hardware, but this was some time ago...) where the wireless detection wasn't working with this, but if we forced it on, it worked fine.

Yes, in acer-wmi supported some non-acer machine by quirk and read EC register. That means we need find out EC register reflect to wifi RF state if we are lucky.

Unfortunately, direct enable wireless capability causes some non-acer machines' wireless rfkill always disabled. e.g. Lenovo E520

Quoted 6 lines

https://bugzilla.redhat.com/show_bug.cgi?id=674353

If we don't check the wireless capability, then they need manually add acer-wmi to backlist. On some lenovo machines, ideapad-laptop driver should support by lenovo's ACPI method.

I've got two reports which says after poking the ec register, the phy0 rfkill reports hard blocked by mistake. And few hours ago I get the third report says the similar issue. I will summary the report.

I am thinking about alternative way

Since we have thinkpad_acpi and ideapad_laptop, both of them have rfkill capability. If there is VPC2004/IBM0068/LEN0068 in DSDT, then it will be fine if we do not register rfkill in acer-wmi.

Any thought?

於 四，2012-01-12 於 00:54 +0800，Ike Panhc 提到：

Quoted 22 lines · joeyli

Quoted 21 lines

於 一，2012-01-09 於 22:15 +0000，Carlos Corbacho 提到：

Quoted 5 lines · On Monday 09 Jan 2012 18:00:24 joeyli wrote:

Quoted 4 lines

I just checked and found I also have no AMW0_GUID2 machines on my hand, now.
I have some questions about AMW0_GUID2:

Quoted 7 lines

Quoted 2 lines

+ Why we enabled wireless capability in acer-wim if a non-acer machine has
AMW0_GUID2 ?

IIRC, there were some bug reports on non-Acer hardware (I don't think this involved Acer hardware, but this was some time ago...) where the wireless detection wasn't working with this, but if we forced it on, it worked fine.

Yes, in acer-wmi supported some non-acer machine by quirk and read EC register. That means we need find out EC register reflect to wifi RF state if we are lucky.

Unfortunately, direct enable wireless capability causes some non-acer machines' wireless rfkill always disabled. e.g. Lenovo E520

Quoted 9 lines

Quoted 6 lines

https://bugzilla.redhat.com/show_bug.cgi?id=674353

If we don't check the wireless capability, then they need manually add acer-wmi to backlist. On some lenovo machines, ideapad-laptop driver should support by lenovo's ACPI method.

I've got two reports which says after poking the ec register, the phy0 rfkill reports hard blocked by mistake. And few hours ago I get the third report says the similar issue. I will summary the report.

Please give more detail information (DSDT, EC register dump...), if poking the ec register can block rfkill, means the AMW0_GUID1 works on this machine, maybe we can try to find out which EC register reflect to wireless.

Quoted 6 lines

I am thinking about alternative way

Since we have thinkpad_acpi and ideapad_laptop, both of them have rfkill capability. If there is VPC2004/IBM0068/LEN0068 in DSDT, then it will be fine if we do not register rfkill in acer-wmi.

Any thought?

Yes, it's possible a solution. If you can make sure lenovo machines have VPC2004/IBM0068/LEN0068 in DSDT, then I will generate a patch to acer-wmi.

Thanks
Joey Lee

Quoted 21 lines

於 一，2012-01-09 於 22:15 +0000，Carlos Corbacho 提到：

Quoted 5 lines · On Monday 09 Jan 2012 18:00:24 joeyli wrote:

Quoted 4 lines

I just checked and found I also have no AMW0_GUID2 machines on my hand, now.
I have some questions about AMW0_GUID2:

Quoted 7 lines

Quoted 2 lines

+ Why we enabled wireless capability in acer-wim if a non-acer machine has
AMW0_GUID2 ?

IIRC, there were some bug reports on non-Acer hardware (I don't think this involved Acer hardware, but this was some time ago...) where the wireless detection wasn't working with this, but if we forced it on, it worked fine.

Yes, in acer-wmi supported some non-acer machine by quirk and read EC register. That means we need find out EC register reflect to wifi RF state if we are lucky.

Unfortunately, direct enable wireless capability causes some non-acer machines' wireless rfkill always disabled. e.g. Lenovo E520

Quoted 6 lines

https://bugzilla.redhat.com/show_bug.cgi?id=674353

If we don't check the wireless capability, then they need manually add acer-wmi to backlist. On some lenovo machines, ideapad-laptop driver should support by lenovo's ACPI method.

I've got two reports which says after poking the ec register, the phy0 rfkill reports hard blocked by mistake. And few hours ago I get the third report says the similar issue. I will summary the report.

I am thinking about alternative way

Since we have thinkpad_acpi and ideapad_laptop, both of them have rfkill capability. If there is VPC2004/IBM0068/LEN0068 in DSDT, then it will be fine if we do not register rfkill in acer-wmi.

Any thought?

Hi Ike

於 四，2012-01-12 於 00:54 +0800，Ike Panhc 提到：

Quoted 29 lines · joeyli

Quoted 27 lines

於 一，2012-01-09 於 22:15 +0000，Carlos Corbacho 提到：

Quoted 5 lines · On Monday 09 Jan 2012 18:00:24 joeyli wrote:

Quoted 4 lines

I just checked and found I also have no AMW0_GUID2 machines on my hand, now.
I have some questions about AMW0_GUID2:

Quoted 7 lines

Quoted 2 lines

+ Why we enabled wireless capability in acer-wim if a non-acer machine has
AMW0_GUID2 ?

IIRC, there were some bug reports on non-Acer hardware (I don't think this involved Acer hardware, but this was some time ago...) where the wireless detection wasn't working with this, but if we forced it on, it worked fine.

Yes, in acer-wmi supported some non-acer machine by quirk and read EC register. That means we need find out EC register reflect to wifi RF state if we are lucky.

Unfortunately, direct enable wireless capability causes some non-acer machines' wireless rfkill always disabled. e.g. Lenovo E520

https://bugzilla.redhat.com/show_bug.cgi?id=674353

If we don't check the wireless capability, then they need manually add acer-wmi to backlist. On some lenovo machines, ideapad-laptop driver should support by lenovo's ACPI method.

Quoted 2 lines

I've got two reports which says after poking the ec register, the phy0 rfkill reports hard blocked by mistake. And few hours ago I get the third report says the similar issue. I will summary the report.

Do you mean the above 2 reports is use this patch? or actually it's other problem?
Could you please kindly test this patch on issue machines?

Quoted 6 lines

I am thinking about alternative way

Since we have thinkpad_acpi and ideapad_laptop, both of them have rfkill capability. If there is VPC2004/IBM0068/LEN0068 in DSDT, then it will be fine if we do not register rfkill in acer-wmi.

Any thought?

It's also another idea.

Thanks a lot!
Joey Lee

We have several reports which says acer-wmi is loaded on ideapads and register rfkill for wifi which can not be unblocked.

Since ideapad-laptop also register rfkill for wifi and it works reliably, it will be fine acer-wmi is not going to register rfkill for wifi once VPC2004 is found.

Also put IBM0068/LEN0068 in the list. Though thinkpad_acpi has no wifi rfkill capability, there are reports which says acer-wmi also block wireless on Thinkpad E520/E420.

Signed-off-by Ike Panhc <[email protected]>

---
 drivers/platform/x86/acer-wmi.c |   29 ++++++++++++++++++++++++++++-
 1 files changed, 28 insertions(+), 1 deletions(-)

drivers/platform/x86/acer-wmi.c +28 -1

index b848277..aaef8f8 100644
@@ -679,6 +679,32 @@ static acpi_status AMW0_find_mailled(void)
 	return AE_OK;
 }
 
+static int AMW0_set_cap_acpi_check_device_found = 0;
+
+static acpi_status AMW0_set_cap_acpi_check_device_cb(acpi_handle handle,
+	u32 level, void *context, void **retval)
+{
+	AMW0_set_cap_acpi_check_device_found = 1;
+	return AE_OK;
+}
+
+static const struct acpi_device_id norfkill_ids[] = {
+	{ "VPC2004", 0},
+	{ "IBM0068", 0},
+	{ "LEN0068", 0},
+	{ "", 0},
+};
+
+static int AMW0_set_cap_acpi_check_device(void)
+{
+	const struct acpi_device_id *id;
+
+	for (id = norfkill_ids; id->id[0]; id++)
+		acpi_get_devices(id->id, AMW0_set_cap_acpi_check_device_cb,
+				NULL, NULL);
+	return AMW0_set_cap_acpi_check_device_found;
+}
+
 static acpi_status AMW0_set_capabilities(void)
 {
 	struct wmab_args args;

@@ -692,7 +718,8 @@ static acpi_status AMW0_set_capabilities(void)
 	 * work.
 	 */
 	if (wmi_has_guid(AMW0_GUID2)) {
-		interface->capability |= ACER_CAP_WIRELESS;
+		if (!AMW0_set_cap_acpi_check_device())
+			interface->capability |= ACER_CAP_WIRELESS;
 		return AE_OK;
 	}
 

This patch has been tested on ideapad s205

User reports the first time try wireless hard/soft all blocked

https://bugs.launchpad.net/ubuntu/+source/linux/+bug/875659/comments/53

but the second try looks good.

https://bugs.launchpad.net/ubuntu/+source/linux/+bug/875659/comments/55

Quoted 52 lines

We have several reports which says acer-wmi is loaded on ideapads and register rfkill for wifi which can not be unblocked.

Since ideapad-laptop also register rfkill for wifi and it works reliably, it will be fine acer-wmi is not going to register rfkill for wifi once VPC2004 is found.

Also put IBM0068/LEN0068 in the list. Though thinkpad_acpi has no wifi rfkill capability, there are reports which says acer-wmi also block wireless on Thinkpad E520/E420.

Signed-off-by Ike Panhc <[email protected]>

---
 drivers/platform/x86/acer-wmi.c |   29 ++++++++++++++++++++++++++++-
 1 files changed, 28 insertions(+), 1 deletions(-)

drivers/platform/x86/acer-wmi.c +26 -0

index b848277..aaef8f8 100644
@@ -679,6 +679,32 @@ static acpi_status AMW0_find_mailled(void)
 	return AE_OK;
 }
 
+static int AMW0_set_cap_acpi_check_device_found = 0;
+
+static acpi_status AMW0_set_cap_acpi_check_device_cb(acpi_handle handle,
+	u32 level, void *context, void **retval)
+{
+	AMW0_set_cap_acpi_check_device_found = 1;
+	return AE_OK;
+}
+
+static const struct acpi_device_id norfkill_ids[] = {
+	{ "VPC2004", 0},
+	{ "IBM0068", 0},
+	{ "LEN0068", 0},
+	{ "", 0},
+};
+
+static int AMW0_set_cap_acpi_check_device(void)
+{
+	const struct acpi_device_id *id;
+
+	for (id = norfkill_ids; id->id[0]; id++)
+		acpi_get_devices(id->id, AMW0_set_cap_acpi_check_device_cb,
+				NULL, NULL);
+	return AMW0_set_cap_acpi_check_device_found;
+}
+
 static acpi_status AMW0_set_capabilities(void)
 {

drivers/platform/x86/acer-wmi.c static acpi_status AMW0_set_capabilities(void) · line 722

Quoted 8 lines

drivers/platform/x86/acer-wmi.c +2 -1

 	struct wmab_args args;

@@ -692,7 +718,8 @@ static acpi_status AMW0_set_capabilities(void)
 	 * work.
 	 */
 	if (wmi_has_guid(AMW0_GUID2)) {
-		interface->capability |= ACER_CAP_WIRELESS;
+		if (!AMW0_set_cap_acpi_check_device())
+			interface->capability |= ACER_CAP_WIRELESS;

drivers/platform/x86/acer-wmi.c static acpi_status AMW0_find_mailled(void) · line 681

Quoted 3 lines

drivers/platform/x86/acer-wmi.c +0 -0

 		return AE_OK;
 	}
 

We have several reports which says acer-wmi is loaded on ideapads and register rfkill for wifi which can not be unblocked.

Since ideapad-laptop also register rfkill for wifi and it works reliably, it will be fine acer-wmi is not going to register rfkill for wifi once VPC2004 is found.

Also put IBM0068/LEN0068 in the list. Though thinkpad_acpi has no wifi rfkill capability, there are reports which says acer-wmi also block wireless on Thinkpad E520/E420.

Signed-off-by Ike Panhc <[email protected]>

---
 drivers/platform/x86/acer-wmi.c |   30 +++++++++++++++++++++++++++++-
 1 files changed, 29 insertions(+), 1 deletions(-)

drivers/platform/x86/acer-wmi.c +29 -1

index b848277..1e5290b 100644
@@ -679,6 +679,32 @@ static acpi_status AMW0_find_mailled(void)
 	return AE_OK;
 }
 
+static int AMW0_set_cap_acpi_check_device_found;
+
+static acpi_status AMW0_set_cap_acpi_check_device_cb(acpi_handle handle,
+	u32 level, void *context, void **retval)
+{
+	AMW0_set_cap_acpi_check_device_found = 1;
+	return AE_OK;
+}
+
+static const struct acpi_device_id norfkill_ids[] = {
+	{ "VPC2004", 0},
+	{ "IBM0068", 0},
+	{ "LEN0068", 0},
+	{ "", 0},
+};
+
+static int AMW0_set_cap_acpi_check_device(void)
+{
+	const struct acpi_device_id *id;
+
+	for (id = norfkill_ids; id->id[0]; id++)
+		acpi_get_devices(id->id, AMW0_set_cap_acpi_check_device_cb,
+				NULL, NULL);
+	return AMW0_set_cap_acpi_check_device_found;
+}
+
 static acpi_status AMW0_set_capabilities(void)
 {
 	struct wmab_args args;

@@ -692,7 +718,9 @@ static acpi_status AMW0_set_capabilities(void)
 	 * work.
 	 */
 	if (wmi_has_guid(AMW0_GUID2)) {
-		interface->capability |= ACER_CAP_WIRELESS;
+		if ((quirks != &quirk_unknown) ||
+		    !AMW0_set_cap_acpi_check_device())
+			interface->capability |= ACER_CAP_WIRELESS;
 		return AE_OK;
 	}
 

We have several reports which says acer-wmi is loaded on ideapads and register rfkill for wifi which can not be unblocked.

Since ideapad-laptop also register rfkill for wifi and it works reliably, it will be fine acer-wmi is not going to register rfkill for wifi once VPC2004 is found.

Also put IBM0068/LEN0068 in the list. Though thinkpad_acpi has no wifi rfkill capability, there are reports which says acer-wmi also block wireless on Thinkpad E520/E420.

Signed-off-by Ike Panhc <[email protected]>

---
 drivers/platform/x86/acer-wmi.c |   30 +++++++++++++++++++++++++++++-
 1 files changed, 29 insertions(+), 1 deletions(-)

drivers/platform/x86/acer-wmi.c +29 -1

index b848277..1e5290b 100644
@@ -679,6 +679,32 @@ static acpi_status AMW0_find_mailled(void)
 	return AE_OK;
 }
 
+static int AMW0_set_cap_acpi_check_device_found;
+
+static acpi_status AMW0_set_cap_acpi_check_device_cb(acpi_handle handle,
+	u32 level, void *context, void **retval)
+{
+	AMW0_set_cap_acpi_check_device_found = 1;
+	return AE_OK;
+}
+
+static const struct acpi_device_id norfkill_ids[] = {
+	{ "VPC2004", 0},
+	{ "IBM0068", 0},
+	{ "LEN0068", 0},
+	{ "", 0},
+};
+
+static int AMW0_set_cap_acpi_check_device(void)
+{
+	const struct acpi_device_id *id;
+
+	for (id = norfkill_ids; id->id[0]; id++)
+		acpi_get_devices(id->id, AMW0_set_cap_acpi_check_device_cb,
+				NULL, NULL);
+	return AMW0_set_cap_acpi_check_device_found;
+}
+
 static acpi_status AMW0_set_capabilities(void)
 {
 	struct wmab_args args;

@@ -692,7 +718,9 @@ static acpi_status AMW0_set_capabilities(void)
 	 * work.
 	 */
 	if (wmi_has_guid(AMW0_GUID2)) {
-		interface->capability |= ACER_CAP_WIRELESS;
+		if ((quirks != &quirk_unknown) ||
+		    !AMW0_set_cap_acpi_check_device())
+			interface->capability |= ACER_CAP_WIRELESS;
 		return AE_OK;
 	}
 

We have several reports which says acer-wmi is loaded on ideapads and register rfkill for wifi which can not be unblocked.

Since ideapad-laptop also register rfkill for wifi and it works reliably, it will be fine acer-wmi is not going to register rfkill for wifi once VPC2004 is found.

Signed-off-by Ike Panhc <[email protected]>

---
 drivers/platform/x86/acer-wmi.c |   30 +++++++++++++++++++++++++++++-
 1 files changed, 29 insertions(+), 1 deletions(-)

We have several reports which says acer-wmi is loaded on ideapads and register rfkill for wifi which can not be unblocked.

Since ideapad-laptop also register rfkill for wifi and it works reliably, it will be fine acer-wmi is not going to register rfkill for wifi once VPC2004 is found.

Also put IBM0068/LEN0068 in the list. Though thinkpad_acpi has no wifi rfkill capability, there are reports which says acer-wmi also block wireless on Thinkpad E520/E420.

Signed-off-by Ike Panhc <[email protected]>

---
 drivers/platform/x86/acer-wmi.c |   30 +++++++++++++++++++++++++++++-
 1 files changed, 29 insertions(+), 1 deletions(-)

drivers/platform/x86/acer-wmi.c +29 -1

index b848277..1e5290b 100644
@@ -679,6 +679,32 @@ static acpi_status AMW0_find_mailled(void)
 	return AE_OK;
 }
 
+static int AMW0_set_cap_acpi_check_device_found;
+
+static acpi_status AMW0_set_cap_acpi_check_device_cb(acpi_handle handle,
+	u32 level, void *context, void **retval)
+{
+	AMW0_set_cap_acpi_check_device_found = 1;
+	return AE_OK;
+}
+
+static const struct acpi_device_id norfkill_ids[] = {
+	{ "VPC2004", 0},
+	{ "IBM0068", 0},
+	{ "LEN0068", 0},
+	{ "", 0},
+};
+
+static int AMW0_set_cap_acpi_check_device(void)
+{
+	const struct acpi_device_id *id;
+
+	for (id = norfkill_ids; id->id[0]; id++)
+		acpi_get_devices(id->id, AMW0_set_cap_acpi_check_device_cb,
+				NULL, NULL);
+	return AMW0_set_cap_acpi_check_device_found;
+}
+
 static acpi_status AMW0_set_capabilities(void)
 {
 	struct wmab_args args;

@@ -692,7 +718,9 @@ static acpi_status AMW0_set_capabilities(void)
 	 * work.
 	 */
 	if (wmi_has_guid(AMW0_GUID2)) {
-		interface->capability |= ACER_CAP_WIRELESS;
+		if ((quirks != &quirk_unknown) ||
+		    !AMW0_set_cap_acpi_check_device())
+			interface->capability |= ACER_CAP_WIRELESS;
 		return AE_OK;
 	}
 

Signature · 1 line

1.7.5.4

Hi Greg,

Please consider applying 461e74377cfc (acer-wmi: No wifi rfkill on Lenovo machines, 2012-02-03) to the 3.2.y and 3.0.y trees.

Quoted 2 lines · Jonathan Nieder

Please consider applying 461e74377cfc (acer-wmi: No wifi rfkill on Lenovo machines, 2012-02-03) to the 3.2.y and 3.0.y trees.

Now applied.

Quoted 5 lines · Greg KH

Quoted 2 lines · Jonathan Nieder

Please consider applying 461e74377cfc (acer-wmi: No wifi rfkill on Lenovo machines, 2012-02-03) to the 3.2.y and 3.0.y trees.

Quoted 1 line

Now applied.

Thanks! That was fast.
--
To unsubscribe from this list: send the line "unsubscribe platform-driver-x86" in the body of a message to [email protected]
More majordomo info at http://vger.kernel.org/majordomo-info.html

Quoted 6 lines

Quoted 5 lines · Greg KH

Quoted 2 lines · Jonathan Nieder

Please consider applying 461e74377cfc (acer-wmi: No wifi rfkill on Lenovo machines, 2012-02-03) to the 3.2.y and 3.0.y trees.

Quoted 8 lines

Quoted 1 line

Now applied.

Thanks! That was fast.
--
To unsubscribe from this list: send the line "unsubscribe platform-driver-x86" in the body of a message to [email protected]
More majordomo info at http://vger.kernel.org/majordomo-info.html

Review the commit log of acer-wmi

For 3.2.y, this patch shall work fine.

But for 3.0.y, backport commit 1709adab is necessary or patch has no effect.

I will post the backport patch after.

Joey, can you review and ACK/NAK for this?

Hi Ike,

於 五，2012-03-16 於 12:03 +0800，Ike Panhc 提到：

Quoted 22 lines · Jonathan Nieder

Quoted 6 lines

Quoted 5 lines · Greg KH

Quoted 2 lines · Jonathan Nieder

Please consider applying 461e74377cfc (acer-wmi: No wifi rfkill on Lenovo machines, 2012-02-03) to the 3.2.y and 3.0.y trees.

Quoted 8 lines

Quoted 1 line

Now applied.

Thanks! That was fast.
--
To unsubscribe from this list: send the line "unsubscribe platform-driver-x86" in the body of a message to [email protected]
More majordomo info at http://vger.kernel.org/majordomo-info.html

Review the commit log of acer-wmi

For 3.2.y, this patch shall work fine.

But for 3.0.y, backport commit 1709adab is necessary or patch has no effect.

Quoted 4 lines

I will post the backport patch after.

Joey, can you review and ACK/NAK for this?

Yes, should check ACER_CAP_WIRELESS flag before create wifi rfkill interface.

Quoted 25 lines

Hi Ike,

於 五，2012-03-16 於 12:03 +0800，Ike Panhc 提到：

Quoted 22 lines · Jonathan Nieder

Quoted 6 lines

Quoted 5 lines · Greg KH

Quoted 2 lines · Jonathan Nieder

Please consider applying 461e74377cfc (acer-wmi: No wifi rfkill on Lenovo machines, 2012-02-03) to the 3.2.y and 3.0.y trees.

Quoted 8 lines

Quoted 1 line

Now applied.

Thanks! That was fast.
--
To unsubscribe from this list: send the line "unsubscribe platform-driver-x86" in the body of a message to [email protected]
More majordomo info at http://vger.kernel.org/majordomo-info.html

Review the commit log of acer-wmi

For 3.2.y, this patch shall work fine.

But for 3.0.y, backport commit 1709adab is necessary or patch has no effect.

Quoted 7 lines

Quoted 4 lines

I will post the backport patch after.

Joey, can you review and ACK/NAK for this?

Yes, should check ACER_CAP_WIRELESS flag before create wifi rfkill interface.

Ok, I've queued up a number of acer-wmi patches for the 3.0-stable tree now, all should be good.

thanks,

greg k-h

於 五，2012-03-16 於 10:20 -0700，Greg KH 提到：

Quoted 37 lines · joeyli

Quoted 25 lines

Hi Ike,

於 五，2012-03-16 於 12:03 +0800，Ike Panhc 提到：

Quoted 22 lines · Jonathan Nieder

Quoted 6 lines

Quoted 5 lines · Greg KH

Quoted 2 lines · Jonathan Nieder

Please consider applying 461e74377cfc (acer-wmi: No wifi rfkill on Lenovo machines, 2012-02-03) to the 3.2.y and 3.0.y trees.

Quoted 8 lines

Quoted 1 line

Now applied.

Thanks! That was fast.
--
To unsubscribe from this list: send the line "unsubscribe platform-driver-x86" in the body of a message to [email protected]
More majordomo info at http://vger.kernel.org/majordomo-info.html

Review the commit log of acer-wmi

For 3.2.y, this patch shall work fine.

But for 3.0.y, backport commit 1709adab is necessary or patch has no effect.

Quoted 7 lines

Quoted 4 lines

I will post the backport patch after.

Joey, can you review and ACK/NAK for this?

Yes, should check ACER_CAP_WIRELESS flag before create wifi rfkill interface.

Ok, I've queued up a number of acer-wmi patches for the 3.0-stable tree now, all should be good.

Quoted 4 lines

thanks,

greg k-h

Thanks a lot!
Joey Lee

Quoted 4 lines

於 五，2012-03-16 於 10:20 -0700，Greg KH 提到：

Quoted 2 lines

Ok, I've queued up a number of acer-wmi patches for the 3.0-stable tree now, all should be good.

Please notify me when patches will be present in git. For testing. Thanks!

Quoted 21 lines · joeyli

於 一，2012-01-09 於 22:15 +0000，Carlos Corbacho 提到：

Quoted 5 lines · On Monday 09 Jan 2012 18:00:24 joeyli wrote:

Quoted 4 lines

I just checked and found I also have no AMW0_GUID2 machines on my hand, now.
I have some questions about AMW0_GUID2:

Quoted 7 lines

Quoted 2 lines

+ Why we enabled wireless capability in acer-wim if a non-acer machine has
AMW0_GUID2 ?

IIRC, there were some bug reports on non-Acer hardware (I don't think this involved Acer hardware, but this was some time ago...) where the wireless detection wasn't working with this, but if we forced it on, it worked fine.

Yes, in acer-wmi supported some non-acer machine by quirk and read EC register. That means we need find out EC register reflect to wifi RF state if we are lucky.

Unfortunately, direct enable wireless capability causes some non-acer machines' wireless rfkill always disabled. e.g. Lenovo E520

Quoted 6 lines

https://bugzilla.redhat.com/show_bug.cgi?id=674353

If we don't check the wireless capability, then they need manually add acer-wmi to backlist. On some lenovo machines, ideapad-laptop driver should support by lenovo's ACPI method.

I've got two reports which says after poking the ec register, the phy0 rfkill reports hard blocked by mistake. And few hours ago I get the third report says the similar issue. I will summary the report.

I am thinking about alternative way

Since we have thinkpad_acpi and ideapad_laptop, both of them have rfkill capability. If there is VPC2004/IBM0068/LEN0068 in DSDT, then it will be fine if we do not register rfkill in acer-wmi.

Any thought?