Skip to contentSkip to conversation

init/Kconfig: Fix dependency for SCHED_AUTOGROUP

PATCH Superseded Fabio Estevam 2 participants 4 messages Jan 10, 2012 – Jan 11, 2012

lore
Share & tools
lore

Fabio Estevam

author
#0 lore raw

PATCH 1/1 init/Kconfig: Fix dependency for SCHED_AUTOGROUP

Fix the following build warning:

warning: (SCHED_AUTOGROUP) selects CGROUP_SCHED which has unmet direct dependencies (CGROUPS && EXPERIMENTAL)

Signed-off-by Fabio Estevam <[email protected]>
---
 init/Kconfig |    1 +
 1 files changed, 1 insertions(+), 0 deletions(-)
init/Kconfig +1 -0
index 34f6d0c..b5cae89 100644
@@ -850,6 +850,7 @@ endif # NAMESPACES
 
 config SCHED_AUTOGROUP
 	bool "Automatic process group scheduling"
+	depends on EXPERIMENTAL
 	select EVENTFD
 	select CGROUPS
 	select CGROUP_SCHED
Signature · 1 line
1.7.1
#1 lore raw
Quoted 14 lines · Fabio Estevam

Fix the following build warning:

warning: (SCHED_AUTOGROUP) selects CGROUP_SCHED which has unmet direct dependencies (CGROUPS && EXPERIMENTAL)

Signed-off-by Fabio Estevam <[email protected]>
---
 init/Kconfig |    1 +
 1 files changed, 1 insertions(+), 0 deletions(-)
init/Kconfig +0 -0
index 34f6d0c..b5cae89 100644

init/Kconfig endif # NAMESPACES · line 856

Quoted 7 lines
init/Kconfig +1 -0
@@ -850,6 +850,7 @@ endif # NAMESPACES
 
 config SCHED_AUTOGROUP
 	bool "Automatic process group scheduling"
+	depends on EXPERIMENTAL
 	select EVENTFD
 	select CGROUPS
 	select CGROUP_SCHED

I think this should rather be solved by removing the EXPERIMENTAL dependency from CGORUP_SCHED.

Thanks,

Ingo

author
#2 lore raw

PATCH v2 1/1 init/Kconfig: Fix dependency for CGROUP_SCHED

In reply to Fabio Estevam

Fix the following build warning:

warning: (SCHED_AUTOGROUP) selects CGROUP_SCHED which has unmet direct dependencies (CGROUPS && EXPERIMENTAL)

Signed-off-by Fabio Estevam <[email protected]>

---
Changes since v1:
- Fix the warning by removing EXPERIMENTAL dependency from CGROUP_SCHED

 init/Kconfig |    1 -
 1 files changed, 0 insertions(+), 1 deletions(-)
init/Kconfig +0 -1
index 34f6d0c..6ac2236 100644
@@ -713,7 +713,6 @@ config CGROUP_PERF
 
 menuconfig CGROUP_SCHED
 	bool "Group CPU scheduler"
-	depends on EXPERIMENTAL
 	default n
 	help
 	  This feature lets CPU scheduler recognize task groups and control CPU
Signature · 1 line
1.7.1
author
#3 lore raw

[tip:sched/urgent] sched: Fix CONFIG_CGROUP_SCHED dependency

Commit-ID:  6db9dc150eabce7053c8df2a2146aa0d6748ec42
Gitweb:     http://git.kernel.org/tip/6db9dc150eabce7053c8df2a2146aa0d6748ec42
Author:     Fabio Estevam <[email protected]>
AuthorDate: Tue, 10 Jan 2012 08:46:23 -0200
Committer:  Ingo Molnar <[email protected]>
CommitDate: Tue, 10 Jan 2012 13:44:50 +0100

sched: Fix CONFIG_CGROUP_SCHED dependency

The dependency bug was pointed out by this build warning:

warning: (SCHED_AUTOGROUP) selects CGROUP_SCHED which has unmet direct dependencies (CGROUPS && EXPERIMENTAL)

Signed-off-by Fabio Estevam <[email protected]>
Cc [email protected]
Cc Fabio Estevam <[email protected]>
Link http://lkml.kernel.org/r/[email protected] open here
Signed-off-by Ingo Molnar <[email protected]>
---
 init/Kconfig |    1 -
 1 files changed, 0 insertions(+), 1 deletions(-)
init/Kconfig +0 -1
index 82b6a4c..a34cd17 100644
@@ -702,7 +702,6 @@ config CGROUP_PERF
 
 menuconfig CGROUP_SCHED
 	bool "Group CPU scheduler"
-	depends on EXPERIMENTAL
 	default n
 	help
 	  This feature lets CPU scheduler recognize task groups and control CPU