Skip to contentSkip to conversation

ASoC: utils - Add support for a dummy codec driver.

PATCH In review Liam Girdwood 2 participants 3 messages Jan 9, 2012 – Jan 10, 2012

Subsystems (2)
lore
Share & tools
lore
#0 lore raw

PATCH 1/1 ASoC: utils - Add support for a dummy codec driver.

This is useful to create dummy codec devices where we need to have some DAI links without a real Codec. e.g. could be used to represent dumb FM, MODEM, etc

This is also used by dynamic PCM for DAI links that have no codec.

---
 sound/soc/soc-utils.c |   20 +++++++++++++++++++-
 1 files changed, 19 insertions(+), 1 deletions(-)
sound/soc/soc-utils.c +19 -1
index 4220bb0..329122d 100644
@@ -89,14 +89,32 @@ static struct snd_soc_platform_driver dummy_platform = {
 	.ops = &dummy_dma_ops,
 };
 
+static struct snd_soc_codec_driver dummy_codec;
+static struct snd_soc_dai_driver dummy_dai = {
+		.name = "snd-soc-dummy-dai",
+};
+
 static __devinit int snd_soc_dummy_probe(struct platform_device *pdev)
 {
-	return snd_soc_register_platform(&pdev->dev, &dummy_platform);
+	int ret;
+
+	ret = snd_soc_register_codec(&pdev->dev, &dummy_codec, &dummy_dai, 1);
+	if (ret < 0)
+		return ret;
+
+	ret = snd_soc_register_platform(&pdev->dev, &dummy_platform);
+	if (ret < 0) {
+		snd_soc_unregister_codec(&pdev->dev);
+		return ret;
+	}
+
+	return ret;
 }
 
 static __devexit int snd_soc_dummy_remove(struct platform_device *pdev)
 {
 	snd_soc_unregister_platform(&pdev->dev);
+	snd_soc_unregister_codec(&pdev->dev);
 
 	return 0;
 }
Signature · 1 line
1.7.5.4
#1 lore raw
Quoted 3 lines · Liam Girdwood

This is useful to create dummy codec devices where we need to have some DAI links without a real Codec. e.g. could be used to represent dumb FM, MODEM, etc

I've applied this but I think we should move it into the CODECs directory - I stubbed the platform out in here mostly because there isn't a natural place to put a platform driver that's not associated with a particular platform. Does that sound sensible?

sound/soc/soc-utils.c static struct snd_soc_platform_driver dummy_platform = { · line 95

Quoted 3 lines
sound/soc/soc-utils.c +3 -0
+static struct snd_soc_dai_driver dummy_dai = {
+		.name = "snd-soc-dummy-dai",
+};

Also fixed the indentation here while applying.

#2 lore raw
Quoted 9 lines · Mark Brown
Quoted 3 lines · Liam Girdwood

This is useful to create dummy codec devices where we need to have some DAI links without a real Codec. e.g. could be used to represent dumb FM, MODEM, etc

I've applied this but I think we should move it into the CODECs directory - I stubbed the platform out in here mostly because there isn't a natural place to put a platform driver that's not associated with a particular platform. Does that sound sensible?

yeah, I was 50/50 about this since we do have codecs/ and utils.c. I don't really mind where it goes.

Liam