Skip to contentSkip to conversation

scripts:kconfig:mconf.c: let make not report error when not save configuration

PATCH In review Wang YanQing 3 participants 3 messages Jan 12, 2012 – Jan 14, 2012

Subsystems (2)
Kbuild Kconfig
lore
Share & tools
lore

Wang YanQing

author
#0 lore raw

PATCH 1/1 scripts:kconfig:mconf.c: let make not report error when not save configuration

I find every time when I choice the 'NO' button at the dialog which let me choice whether to save the configuration before exit menuconfig, it always report the blow:

" GEN     /mnt/sda7/home/build/test/Makefile
  HOSTCC  scripts/kconfig/mconf.o
  HOSTLD  scripts/kconfig/mconf

scripts/kconfig/mconf Kconfig

Your configuration changes were NOT saved.

make[2]: *** [menuconfig] Error 1
make[1]: *** [menuconfig] Error 2
make: *** [sub-make] Error 2 "

This patch repair it.

Thanks!

Signed-off-by Wang YanQing <[email protected]>
---
 scripts/kconfig/mconf.c |    1 +
 1 files changed, 1 insertions(+), 0 deletions(-)
scripts/kconfig/mconf.c +1 -0
index 19e200d..86cd1ea 100644
@@ -830,6 +830,7 @@ static int handle_exit(void)
 		fprintf(stderr, _("\n\n"
 				  "Your configuration changes were NOT saved."
 				  "\n\n"));
+		res = 0;
 	}
 
 	return res;
Signature · 1 line
1.7.3.4
Acked-by on v1 1/1
#1 lore raw
Quoted 15 lines · Wang YanQing

I find every time when I choice the 'NO' button at the dialog which let me choice whether to save the configuration before exit menuconfig, it always report the blow:

" GEN     /mnt/sda7/home/build/test/Makefile
  HOSTCC  scripts/kconfig/mconf.o
  HOSTLD  scripts/kconfig/mconf

scripts/kconfig/mconf Kconfig

Your configuration changes were NOT saved.

make[2]: *** [menuconfig] Error 1
make[1]: *** [menuconfig] Error 2
make: *** [sub-make] Error 2 "

Quoted 5 lines

This patch repair it.

Thanks!

Signed-off-by Wang YanQing <[email protected]>
Acked-by Davidlohr Bueso <[email protected]>
Quoted 16 lines
---
 scripts/kconfig/mconf.c |    1 +
 1 files changed, 1 insertions(+), 0 deletions(-)
scripts/kconfig/mconf.c +1 -0
index 19e200d..86cd1ea 100644
@@ -830,6 +830,7 @@ static int handle_exit(void)
 		fprintf(stderr, _("\n\n"
 				  "Your configuration changes were NOT saved."
 				  "\n\n"));
+		res = 0;
 	}
 
 	return res;
#2 lore raw
Quoted 16 lines · Davidlohr Bueso
Quoted 15 lines · Wang YanQing

I find every time when I choice the 'NO' button at the dialog which let me choice whether to save the configuration before exit menuconfig, it always report the blow:

" GEN     /mnt/sda7/home/build/test/Makefile
  HOSTCC  scripts/kconfig/mconf.o
  HOSTLD  scripts/kconfig/mconf

scripts/kconfig/mconf Kconfig

Your configuration changes were NOT saved.

make[2]: *** [menuconfig] Error 1
make[1]: *** [menuconfig] Error 2
make: *** [sub-make] Error 2 "

Quoted 7 lines
Quoted 5 lines

This patch repair it.

Thanks!

Signed-off-by Wang YanQing <[email protected]>
Acked-by Davidlohr Bueso <[email protected]>

Applied to kbuild.git#kconfig.

Michal