Skip to contentSkip to conversation

gcc-cross: Don't reference machine specific variables

PATCH In review Richard Purdie 3 participants 3 messages Jan 24, 2012 – Jan 25, 2012

lore
Share & tools
lore
#0 lore raw

PATCH 1/1 gcc-cross: Don't reference machine specific variables

gcc-cross is installed into a package architecture specific directory and is not meant to be machine specific. This patch replaces MACHINE_ARCH with PACKAGE_ARCH to ensure this is really the case.

This was found by examining sstate checksums.

---

meta/recipes-devtools/gcc/gcc-cross.inc +6 -6
index 0b31a8c..6acf8c5 100644
@@ -87,12 +87,12 @@ then
 	exit 1
 fi
 	echo "lappend boards_dir [pwd]/../../.." > ${B}/site.exp
-	echo "load_generic_config \"unix\"" > ${B}/${MACHINE_ARCH}.exp
-	echo "set_board_info username \$user" >> ${B}/${MACHINE_ARCH}.exp
-	echo "set_board_info rsh_prog ssh" >> ${B}/${MACHINE_ARCH}.exp
-	echo "set_board_info rcp_prog scp" >> ${B}/${MACHINE_ARCH}.exp
-	echo "set_board_info hostname \$target" >> ${B}/${MACHINE_ARCH}.exp
-	DEJAGNU=${B}/site.exp make -k check RUNTESTFLAGS="--target_board=${MACHINE_ARCH}\$@"
+	echo "load_generic_config \"unix\"" > ${B}/${PACKAGE_ARCH}.exp
+	echo "set_board_info username \$user" >> ${B}/${PACKAGE_ARCH}.exp
+	echo "set_board_info rsh_prog ssh" >> ${B}/${PACKAGE_ARCH}.exp
+	echo "set_board_info rcp_prog scp" >> ${B}/${PACKAGE_ARCH}.exp
+	echo "set_board_info hostname \$target" >> ${B}/${PACKAGE_ARCH}.exp
+	DEJAGNU=${B}/site.exp make -k check RUNTESTFLAGS="--target_board=${PACKAGE_ARCH}\$@"
 
 STOP
 
Acked-by on v1 1/1
#1 lore raw
Quoted 5 lines · Richard Purdie

gcc-cross is installed into a package architecture specific directory and is not meant to be machine specific. This patch replaces MACHINE_ARCH with PACKAGE_ARCH to ensure this is really the case.

This was found by examining sstate checksums.

This change is fine. Since its only a script name it does not matter what its called.

Quoted 28 lines

---

meta/recipes-devtools/gcc/gcc-cross.inc +0 -0
index 0b31a8c..6acf8c5 100644
@@ -87,12 +87,12 @@ then

       exit 1
 fi
       echo "lappend boards_dir [pwd]/../../.." > ${B}/site.exp
-       echo "load_generic_config \"unix\"" > ${B}/${MACHINE_ARCH}.exp
-       echo "set_board_info username \$user" >> ${B}/${MACHINE_ARCH}.exp
-       echo "set_board_info rsh_prog ssh" >> ${B}/${MACHINE_ARCH}.exp
-       echo "set_board_info rcp_prog scp" >> ${B}/${MACHINE_ARCH}.exp
-       echo "set_board_info hostname \$target" >> ${B}/${MACHINE_ARCH}.exp
-       DEJAGNU=${B}/site.exp make -k check RUNTESTFLAGS="--target_board=${MACHINE_ARCH}\$@"
+       echo "load_generic_config \"unix\"" > ${B}/${PACKAGE_ARCH}.exp
+       echo "set_board_info username \$user" >> ${B}/${PACKAGE_ARCH}.exp
+       echo "set_board_info rsh_prog ssh" >> ${B}/${PACKAGE_ARCH}.exp
+       echo "set_board_info rcp_prog scp" >> ${B}/${PACKAGE_ARCH}.exp
+       echo "set_board_info hostname \$target" >> ${B}/${PACKAGE_ARCH}.exp
+       DEJAGNU=${B}/site.exp make -k check RUNTESTFLAGS="--target_board=${PACKAGE_ARCH}\$@"

 STOP

Acked-by on v1 1/1
#2 lore raw
In reply to Richard Purdie
Quoted 7 lines · Richard Purdie

gcc-cross is installed into a package architecture specific directory and is not meant to be machine specific. This patch replaces MACHINE_ARCH with PACKAGE_ARCH to ensure this is really the case.

This was found by examining sstate checksums.

Quoted 31 lines

---

meta/recipes-devtools/gcc/gcc-cross.inc +6 -6
index 0b31a8c..6acf8c5 100644
@@ -87,12 +87,12 @@ then
 	exit 1
 fi
 	echo "lappend boards_dir [pwd]/../../.." > ${B}/site.exp
-	echo "load_generic_config \"unix\"" > ${B}/${MACHINE_ARCH}.exp
-	echo "set_board_info username \$user" >> ${B}/${MACHINE_ARCH}.exp
-	echo "set_board_info rsh_prog ssh" >> ${B}/${MACHINE_ARCH}.exp
-	echo "set_board_info rcp_prog scp" >> ${B}/${MACHINE_ARCH}.exp
-	echo "set_board_info hostname \$target" >> ${B}/${MACHINE_ARCH}.exp
-	DEJAGNU=${B}/site.exp make -k check RUNTESTFLAGS="--target_board=${MACHINE_ARCH}\$@"
+	echo "load_generic_config \"unix\"" > ${B}/${PACKAGE_ARCH}.exp
+	echo "set_board_info username \$user" >> ${B}/${PACKAGE_ARCH}.exp
+	echo "set_board_info rsh_prog ssh" >> ${B}/${PACKAGE_ARCH}.exp
+	echo "set_board_info rcp_prog scp" >> ${B}/${PACKAGE_ARCH}.exp
+	echo "set_board_info hostname \$target" >> ${B}/${PACKAGE_ARCH}.exp
+	DEJAGNU=${B}/site.exp make -k check RUNTESTFLAGS="--target_board=${PACKAGE_ARCH}\$@"
 
 STOP
 

_______________________________________________
Openembedded-core mailing list
[email protected]
http://lists.linuxtogo.org/cgi-bin/mailman/listinfo/openembedded-core

Signature · 1 line
Martin 'JaMa' Jansa     jabber: [email protected]