Skip to contentSkip to conversation

Richard Purdie : gcc-common.inc: Ensure WORKDIR doesn' t adversly affect sstate checksums

oe-commits Andreas Müller 2 participants 3 messages Jan 24, 2012 2 messages not in the archive

lore
Share & tools
lore

A message that is not in the archive (sent off-list or not yet received): 20120124122907.DB5D710332@opal

Andreas Müller

author
#1 lore raw
Quoted 30 lines · On Tue, Jan 24, 2012 at 1:29 PM, <[email protected]> wrote:

Module: openembedded-core.git
Branch: master
Commit: 0de85d2ca3bc9674323302a35995dfddb6044a71
URL:    http://git.openembedded.org/?p=openembedded-core.git&a=commit;h=0de85d2ca3bc9674323302a35995dfddb6044a71

Author: Richard Purdie <[email protected]>
Date:   Tue Jan 24 12:14:19 2012 +0000

gcc-common.inc: Ensure WORKDIR doesn't adversly affect sstate checksums

Changes in WORKDIR were changing the do_patch stamps between gcc-crosssdk and gcc-cross. This excludes the variable since in this case, we don't need want those changes to affect the signatures.

Signed-off-by Richard Purdie <[email protected]>

---

 meta/recipes-devtools/gcc/gcc-common.inc |    4 ++++

 1 files changed, 4 insertions(+), 0 deletions(-)
meta/recipes-devtools/gcc/gcc-common.inc +0 -0
index ed41b0f..5ba68a0 100644
@@ -105,3 +105,7 @@ do_headerfix () {

 addtask headerfix after do_unpack before do_patch

 do_headerfix[vardepvalue] = "PATH"

meta/recipes-devtools/gcc/gcc-common.inc

Quoted 3 lines
meta/recipes-devtools/gcc/gcc-common.inc +3 -0
+
+# We need to ensure that for the shared work directory, the do_patch singatures match
+The real WORKDIR location isn't a dependency for the shared workdir.

Oops^^

Quoted 1 line

+src_patches[vardepsexclude] = "WORKDIR"

Andreas

A message that is not in the archive (sent off-list or not yet received): CALbNGRQuiOEWTZ5P5K-fHUYWBB61MVwkDnivCjZ9YzVaybnp8w@mail.gmail.com

author
#3 lore raw
Quoted 30 lines · On Tue, Jan 24, 2012 at 1:29 PM, <[email protected]> wrote:

Module: openembedded-core.git
Branch: master
Commit: 0de85d2ca3bc9674323302a35995dfddb6044a71
URL:    http://git.openembedded.org/?p=openembedded-core.git&a=commit;h=0de85d2ca3bc9674323302a35995dfddb6044a71

Author: Richard Purdie <[email protected]>
Date:   Tue Jan 24 12:14:19 2012 +0000

gcc-common.inc: Ensure WORKDIR doesn't adversly affect sstate checksums

Changes in WORKDIR were changing the do_patch stamps between gcc-crosssdk and gcc-cross. This excludes the variable since in this case, we don't need want those changes to affect the signatures.

Signed-off-by Richard Purdie <[email protected]>

---

 meta/recipes-devtools/gcc/gcc-common.inc |    4 ++++

 1 files changed, 4 insertions(+), 0 deletions(-)
meta/recipes-devtools/gcc/gcc-common.inc +0 -0
index ed41b0f..5ba68a0 100644
@@ -105,3 +105,7 @@ do_headerfix () {

 addtask headerfix after do_unpack before do_patch

 do_headerfix[vardepvalue] = "PATH"

meta/recipes-devtools/gcc/gcc-common.inc

Quoted 3 lines
meta/recipes-devtools/gcc/gcc-common.inc +3 -0
+
+# We need to ensure that for the shared work directory, the do_patch singatures match
+The real WORKDIR location isn't a dependency for the shared workdir.

Oops^^

Quoted 1 line

+src_patches[vardepsexclude] = "WORKDIR"

Aargh: sent to wrong list again :(

Andreas

#4 lore raw
Quoted 30 lines · Andreas Müller
Quoted 29 lines · On Tue, Jan 24, 2012 at 1:29 PM, <[email protected]> wrote:
Module: openembedded-core.git
Branch: master
Commit: 0de85d2ca3bc9674323302a35995dfddb6044a71
URL:    http://git.openembedded.org/?p=openembedded-core.git&a=commit;h=0de85d2ca3bc9674323302a35995dfddb6044a71
Author: Richard Purdie <[email protected]>
Date:   Tue Jan 24 12:14:19 2012 +0000

gcc-common.inc: Ensure WORKDIR doesn't adversly affect sstate checksums

Changes in WORKDIR were changing the do_patch stamps between gcc-crosssdk and gcc-cross. This excludes the variable since in this case, we don't need want those changes to affect the signatures.

Signed-off-by Richard Purdie <[email protected]>

---

 meta/recipes-devtools/gcc/gcc-common.inc |    4 ++++
 1 files changed, 4 insertions(+), 0 deletions(-)
meta/recipes-devtools/gcc/gcc-common.inc +0 -0
index ed41b0f..5ba68a0 100644
@@ -105,3 +105,7 @@ do_headerfix () {
 addtask headerfix after do_unpack before do_patch
Quoted 6 lines

meta/recipes-devtools/gcc/gcc-common.inc do_headerfix () { · line 110

Quoted 4 lines
meta/recipes-devtools/gcc/gcc-common.inc +3 -0
 do_headerfix[vardepvalue] = "PATH"
+
+# We need to ensure that for the shared work directory, the do_patch singatures match
+The real WORKDIR location isn't a dependency for the shared workdir.

Oops^^

Quoted 1 line
meta/recipes-devtools/gcc/gcc-common.inc +1 -0
+src_patches[vardepsexclude] = "WORKDIR"

Sorry about this, I pushed a fix earlier on.

Cheers,

Richard