Skip to contentSkip to conversation

LPC32XX build fix

PATCH New Roland Stigge 3 participants 3 messages Jan 27, 2012 – Jan 31, 2012

Subsystems (3)
lore
Share & tools
lore
#0 lore raw

PATCH 1/1 LPC32XX build fix

This patch fixes a GCC compile error ("static declaration follows non-static declaration") for LPC32XX's watchdog, removing the extern declaration since it's not called externally.

arch/arm/mach-lpc32xx/common.h +0 -1
index 4b4e700..75640bfb 100644
@@ -65,7 +65,6 @@ extern u32 clk_get_pclk_div(void);
  */
 extern void lpc32xx_get_uid(u32 devid[4]);
 
-extern void lpc32xx_watchdog_reset(void);
 extern u32 lpc32xx_return_iram_size(void);
 
 /*
#1 lore raw

PATCH 1/1 LPC32XX build fix

Quoted 5 lines · Roland Stigge

This patch fixes a GCC compile error ("static declaration follows non-static declaration") for LPC32XX's watchdog, removing the extern declaration since it's not called externally.

Subject header should contain "arm: lpc32xx" and describe the fix like "remove broken non-static declaration" or so

Other than that:

Quoted 13 lines
arch/arm/mach-lpc32xx/common.h +0 -1
index 4b4e700..75640bfb 100644
@@ -65,7 +65,6 @@ extern u32 clk_get_pclk_div(void);
  */
 extern void lpc32xx_get_uid(u32 devid[4]);
 
-extern void lpc32xx_watchdog_reset(void);
 extern u32 lpc32xx_return_iram_size(void);
 
 /*
Signature · 9 lines
Pengutronix e.K.                           | Wolfram Sang                |
Industrial Linux Solutions                 | http://www.pengutronix.de/  |
-------------- next part --------------
A non-text attachment was scrubbed...
Name: signature.asc
Type: application/pgp-signature
Size: 198 bytes
Desc: Digital signature
URL: <http://lists.infradead.org/pipermail/linux-arm-kernel/attachments/20120131/14f9ff59/attachment.sig>
#2 lore raw

PATCH 1/1 LPC32XX build fix

In reply to Roland Stigge

arch/arm/mach-lpc32xx/common.h

Quoted 10 lines · Roland Stigge

This patch fixes a GCC compile error ("static declaration follows non-static declaration") for LPC32XX's watchdog, removing the extern declaration since it's not called externally.

arch/arm/mach-lpc32xx/common.h +0 -0
index 4b4e700..75640bfb 100644

No need to CC me on patches like this. I'm not in any way involved with lpc32xx maintainership.

g.

Quoted 8 lines
arch/arm/mach-lpc32xx/common.h +0 -0
@@ -65,7 +65,6 @@ extern u32 clk_get_pclk_div(void);

?*/
?extern void lpc32xx_get_uid(u32 devid[4]);

-extern void lpc32xx_watchdog_reset(void);
?extern u32 lpc32xx_return_iram_size(void);

?/*

Signature · 2 lines
Grant Likely, B.Sc., P.Eng.
Secret Lab Technologies Ltd.