Skip to contentSkip to conversation

selftests: Make run_tests executable

PATCH In review Frederic Weisbecker 2 participants 5 messages Jan 30, 2012 – Feb 2, 2012 Kselftest

lore
Share & tools
lore
#0 lore raw

PATCH 1/1 selftests: Make run_tests executable

Make the main script that launches the tests to become executable. Otherwise people need to launch it as an argument to a new bash instance.

---

 0 files changed, 0 insertions(+), 0 deletions(-)
 mode change 100644 => 100755 tools/testing/selftests/run_tests
tools/testing/selftests/run_tests +0 -0
old mode 100644
new mode 100755
Signature · 1 line
1.7.5.4
#1 lore raw
Quoted 4 lines · On Mon, 30 Jan 2012 18:04:29 +0100 Frederic Weisbecker <[email protected]>…

Make the main script that launches the tests to become executable. Otherwise people need to launch it as an argument to a new bash instance.

That's a feature ;)

The x bit can easily get lost on kernel scripts. For example, if someone upgrades their kernel with patch(1) and the patch adds or renames the script, the x bit gets lost.

If we were to set the x bit for the subset of people who get their scripts direct from a git repository then those people might write and distribute tools which fail when used by people who have lost their x bit. I've seen this happen at least once before.

#2 lore raw
Quoted 10 lines · Andrew Morton
Quoted 4 lines · On Mon, 30 Jan 2012 18:04:29 +0100 Frederic Weisbecker <[email protected]>…

Make the main script that launches the tests to become executable. Otherwise people need to launch it as an argument to a new bash instance.

That's a feature ;)

Quoted 9 lines

The x bit can easily get lost on kernel scripts. For example, if someone upgrades their kernel with patch(1) and the patch adds or renames the script, the x bit gets lost.

If we were to set the x bit for the subset of people who get their scripts direct from a git repository then those people might write and distribute tools which fail when used by people who have lost their x bit. I've seen this happen at least once before.

I see. Another way could be to chmod the run_test script from the Makefile. Would that sound clumsy?

#3 lore raw
Quoted 15 lines · On Wed, 1 Feb 2012 16:24:53 +0100 Frederic Weisbecker <[email protected]>…
Quoted 14 lines · Andrew Morton
Quoted 4 lines · On Mon, 30 Jan 2012 18:04:29 +0100 Frederic Weisbecker <[email protected]>…

Make the main script that launches the tests to become executable. Otherwise people need to launch it as an argument to a new bash instance.

That's a feature ;)

The x bit can easily get lost on kernel scripts. For example, if someone upgrades their kernel with patch(1) and the patch adds or renames the script, the x bit gets lost.

Quoted 8 lines
Quoted 5 lines

If we were to set the x bit for the subset of people who get their scripts direct from a git repository then those people might write and distribute tools which fail when used by people who have lost their x bit. I've seen this happen at least once before.

I see. Another way could be to chmod the run_test script from the Makefile. Would that sound clumsy?

I suggest we remove the script and make it a makefile target instead. "make tests" or whatever. As a microbonus that would remove the need to duplicate the TARGETS definition in the two scripts.

#4 lore raw
Quoted 24 lines · Andrew Morton
Quoted 21 lines · On Wed, 1 Feb 2012 16:24:53 +0100 Frederic Weisbecker <[email protected]>…
Quoted 19 lines · Andrew Morton
Quoted 4 lines · On Mon, 30 Jan 2012 18:04:29 +0100 Frederic Weisbecker <[email protected]>…

Make the main script that launches the tests to become executable. Otherwise people need to launch it as an argument to a new bash instance.

That's a feature ;)

The x bit can easily get lost on kernel scripts. For example, if someone upgrades their kernel with patch(1) and the patch adds or renames the script, the x bit gets lost.

If we were to set the x bit for the subset of people who get their scripts direct from a git repository then those people might write and distribute tools which fail when used by people who have lost their x bit. I've seen this happen at least once before.

Quoted 6 lines
Quoted 2 lines

I see. Another way could be to chmod the run_test script from the Makefile. Would that sound clumsy?

I suggest we remove the script and make it a makefile target instead. "make tests" or whatever. As a microbonus that would remove the need to duplicate the TARGETS definition in the two scripts.

Sounds good. But we still need the TARGET in the makefile to list the directories. Although I can do a simple ls.