Skip to contentSkip to conversation

bitbake: fix bug #1492

PATCH Applied Lianhao Lu 3 participants 5 messages Jan 31, 2012 – Feb 1, 2012

lore
Share & tools
lore

Lianhao Lu

author
#0 lore raw

cover bitbake: fix bug #1492

The following changes since commit 636d7e308fefe7cca67166d564c3a8f877f2ca86:
Richard Purdie (1):
useradd.bbclass: Fix missing quote

are available in the git repository at:

git://git.pokylinux.org/poky-contrib llu/bug1942
http://git.pokylinux.org/cgit.cgi/poky-contrib/log/?h=llu/bug1942

Lianhao Lu (1):
prserv: Do not ping PRService if not required

 bitbake/lib/prserv/serv.py |    2 +-
 1 files changed, 1 insertions(+), 1 deletions(-)
author
#1 lore raw

PATCH 1/1 prserv: Do not ping PRService if not required

[YOCTO #1942]
Ping the PRService only if PRSERV_HOST and PRSERV_PORT are set.

---
 bitbake/lib/prserv/serv.py |    2 +-
 1 files changed, 1 insertions(+), 1 deletions(-)
bitbake/lib/prserv/serv.py +1 -1
index fa437f9..5567c6f 100644
@@ -268,7 +268,7 @@ def is_local_special(host, port):
 
 def auto_start(d):
     global singleton
-    if d.getVar('USE_PR_SERV', True) == '0':
+    if (not d.getVar('PRSERV_HOST', True)) or (not d.getVar('PRSERV_PORT', True)):
         return True
 
     if is_local_special(d.getVar('PRSERV_HOST', True), int(d.getVar('PRSERV_PORT', True))) and not singleton:
Signature · 1 line
1.7.0.4
#2 lore raw

Re: [PATCH 1/1] prserv: Do not ping PRService if not required

Quoted 14 lines · Lianhao Lu

[YOCTO #1942]
Ping the PRService only if PRSERV_HOST and PRSERV_PORT are set.

---
 bitbake/lib/prserv/serv.py |    2 +-

 1 files changed, 1 insertions(+), 1 deletions(-)
bitbake/lib/prserv/serv.py +0 -0
index fa437f9..5567c6f 100644
@@ -268,7 +268,7 @@ def is_local_special(host, port):
 
Quoted 4 lines

 def auto_start(d):
    global singleton
-    if d.getVar('USE_PR_SERV', True) == '0':
+    if (not d.getVar('PRSERV_HOST', True)) or (not d.getVar('PRSERV_PORT', True)):

should it warn in case when USE_PR_SERV is set but one of PRSERV_HOST or PRSERV_PORT are unset

Quoted 11 lines

        return True

    if is_local_special(d.getVar('PRSERV_HOST', True), int(d.getVar('PRSERV_PORT', True))) and not singleton:
--
1.7.0.4

_______________________________________________
bitbake-devel mailing list
[email protected]
http://lists.linuxtogo.org/cgi-bin/mailman/listinfo/bitbake-devel

#3 lore raw

Re: [PATCH 1/1] prserv: Do not ping PRService if not required

Khem Raj wrote on 2012-01-31:

Quoted 15 lines · Lianhao Lu
Quoted 14 lines

[YOCTO #1942]
Ping the PRService only if PRSERV_HOST and PRSERV_PORT are set.

---
 bitbake/lib/prserv/serv.py |    2 +-

 1 files changed, 1 insertions(+), 1 deletions(-)
bitbake/lib/prserv/serv.py +0 -0
index fa437f9..5567c6f 100644
@@ -268,7 +268,7 @@ def is_local_special(host, port):
 
Quoted 8 lines
Quoted 4 lines

 def auto_start(d):
    global singleton
-    if d.getVar('USE_PR_SERV', True) == '0':
+    if (not d.getVar('PRSERV_HOST', True)) or (not d.getVar('PRSERV_PORT', True)):

should it warn in case when USE_PR_SERV is set but one of PRSERV_HOST or PRSERV_PORT are unset

USE_PR_SERV will also be set if PRSERV_LOCKDOWN is set in the case of release 'lockdown'.

Quoted 11 lines
Quoted 11 lines

        return True

    if is_local_special(d.getVar('PRSERV_HOST', True), int(d.getVar('PRSERV_PORT', True))) and not singleton:
--
1.7.0.4

_______________________________________________
bitbake-devel mailing list
[email protected]
http://lists.linuxtogo.org/cgi-bin/mailman/listinfo/bitbake-devel