Skip to contentSkip to conversation

Correcting some style issues

PATCH In review Tristan Pourcelot 2 participants 4 messages Feb 2, 2012 – Feb 14, 2012

Subsystems (2)
lore
Share & tools
lore
#0 lore raw

PATCH 1/1 Correcting some style issues

Quoted 1 line

From d50e5530201aa02a5232ca9f2458a7fdd18de374 Mon Sep 17 00:00:00 2001

From: Tristan Pourcelot <[email protected]>
Date: Thu, 2 Feb 2012 14:01:03 +0100
Subject: [PATCH] Correcting some style errors in
drivers/crypto/geode-aes.c

---
 drivers/crypto/geode-aes.c |   72
++++++++++++++++++++++----------------------
 1 files changed, 36 insertions(+), 36 deletions(-)
drivers/crypto/geode-aes.c +36 -36
index 2addf1a..e325929 100644
@@ -282,21 +282,21 @@ static struct crypto_alg geode_alg = {
 	.cra_driver_name	=	"geode-aes",
 	.cra_priority		=	300,
 	.cra_alignmask		=	15,
-	.cra_flags			=	CRYPTO_ALG_TYPE_CIPHER |
-							CRYPTO_ALG_NEED_FALLBACK,
-	.cra_init			=	fallback_init_cip,
-	.cra_exit			=	fallback_exit_cip,
+	.cra_flags		=	CRYPTO_ALG_TYPE_CIPHER |
+		CRYPTO_ALG_NEED_FALLBACK,
+	.cra_init		=	fallback_init_cip,
+	.cra_exit		=	fallback_exit_cip,
 	.cra_blocksize		=	AES_MIN_BLOCK_SIZE,
 	.cra_ctxsize		=	sizeof(struct geode_aes_op),
-	.cra_module			=	THIS_MODULE,
-	.cra_list			=	LIST_HEAD_INIT(geode_alg.cra_list),
-	.cra_u				=	{
-		.cipher	=	{
-			.cia_min_keysize	=	AES_MIN_KEY_SIZE,
-			.cia_max_keysize	=	AES_MAX_KEY_SIZE,
-			.cia_setkey			=	geode_setkey_cip,
-			.cia_encrypt		=	geode_encrypt,
-			.cia_decrypt		=	geode_decrypt
+	.cra_module		=	THIS_MODULE,
+	.cra_list		=	LIST_HEAD_INIT(geode_alg.cra_list),
+	.cra_u			=	{
+	.cipher	=	{
+		.cia_min_keysize	=	AES_MIN_KEY_SIZE,
+		.cia_max_keysize	=	AES_MAX_KEY_SIZE,
+		.cia_setkey		=	geode_setkey_cip,
+		.cia_encrypt		=	geode_encrypt,
+		.cia_decrypt		=	geode_decrypt
 		}
 	}
 };
@@ -392,24 +392,24 @@ static struct crypto_alg geode_cbc_alg = {
 	.cra_name		=	"cbc(aes)",
 	.cra_driver_name	=	"cbc-aes-geode",
 	.cra_priority		=	400,
-	.cra_flags			=	CRYPTO_ALG_TYPE_BLKCIPHER |
-							CRYPTO_ALG_NEED_FALLBACK,
-	.cra_init			=	fallback_init_blk,
-	.cra_exit			=	fallback_exit_blk,
+	.cra_flags		=	CRYPTO_ALG_TYPE_BLKCIPHER |
+						CRYPTO_ALG_NEED_FALLBACK,
+	.cra_init		=	fallback_init_blk,
+	.cra_exit		=	fallback_exit_blk,
 	.cra_blocksize		=	AES_MIN_BLOCK_SIZE,
 	.cra_ctxsize		=	sizeof(struct geode_aes_op),
 	.cra_alignmask		=	15,
-	.cra_type			=	&crypto_blkcipher_type,
-	.cra_module			=	THIS_MODULE,
-	.cra_list			=	LIST_HEAD_INIT(geode_cbc_alg.cra_list),
-	.cra_u				=	{
+	.cra_type		=	&crypto_blkcipher_type,
+	.cra_module		=	THIS_MODULE,
+	.cra_list		=	LIST_HEAD_INIT(geode_cbc_alg.cra_list),
+	.cra_u			=	{
 		.blkcipher	=	{
 			.min_keysize	=	AES_MIN_KEY_SIZE,
 			.max_keysize	=	AES_MAX_KEY_SIZE,
-			.setkey			=	geode_setkey_blk,
-			.encrypt		=	geode_cbc_encrypt,
-			.decrypt		=	geode_cbc_decrypt,
-			.ivsize			=	AES_IV_LENGTH,
+			.setkey		=	geode_setkey_blk,
+			.encryp		=	geode_cbc_encrypt,
+			.decryp		=	geode_cbc_decrypt,
+			.ivsize		=	AES_IV_LENGTH,
 		}
 	}
 };
@@ -478,23 +478,23 @@ static struct crypto_alg geode_ecb_alg = {
 	.cra_name		=	"ecb(aes)",
 	.cra_driver_name	=	"ecb-aes-geode",
 	.cra_priority		=	400,
-	.cra_flags			=	CRYPTO_ALG_TYPE_BLKCIPHER |
-							CRYPTO_ALG_NEED_FALLBACK,
-	.cra_init			=	fallback_init_blk,
-	.cra_exit			=	fallback_exit_blk,
+	.cra_flags		=	CRYPTO_ALG_TYPE_BLKCIPHER |
+						CRYPTO_ALG_NEED_FALLBACK,
+	.cra_init		=	fallback_init_blk,
+	.cra_exit		=	fallback_exit_blk,
 	.cra_blocksize		=	AES_MIN_BLOCK_SIZE,
 	.cra_ctxsize		=	sizeof(struct geode_aes_op),
 	.cra_alignmask		=	15,
-	.cra_type			=	&crypto_blkcipher_type,
-	.cra_module			=	THIS_MODULE,
-	.cra_list			=	LIST_HEAD_INIT(geode_ecb_alg.cra_list),
-	.cra_u				=	{
+	.cra_type		=	&crypto_blkcipher_type,
+	.cra_module		=	THIS_MODULE,
+	.cra_list		=	LIST_HEAD_INIT(geode_ecb_alg.cra_list),
+	.cra_u			=	{
 		.blkcipher	=	{
 			.min_keysize	=	AES_MIN_KEY_SIZE,
 			.max_keysize	=	AES_MAX_KEY_SIZE,
-			.setkey			=	geode_setkey_blk,
-			.encrypt		=	geode_ecb_encrypt,
-			.decrypt		=	geode_ecb_decrypt,
+			.setkey		=	geode_setkey_blk,
+			.encrypt	=	geode_ecb_encrypt,
+			.decrypt	=	geode_ecb_decrypt,
 		}
 	}
 };
Signature · 1 line
1.7.9
#1 lore raw
Quoted 6 lines · Tristan Pourcelot
Quoted 1 line

From d50e5530201aa02a5232ca9f2458a7fdd18de374 Mon Sep 17 00:00:00 2001

From: Tristan Pourcelot <[email protected]>
Date: Thu, 2 Feb 2012 14:01:03 +0100
Subject: [PATCH] Correcting some style errors in
drivers/crypto/geode-aes.c

Sorry, your patch doesn't apply against cryptodev:

$ git apply ~/p
2 out of 3 hunks FAILED -- saving rejects to file drivers/crypto/geode-aes.c.rej
$

Please check and resend.

Thanks,

Signature · 3 lines
Email: Herbert Xu <[email protected]>
Home Page: http://gondor.apana.org.au/~herbert/
PGP Key: http://gondor.apana.org.au/~herbert/pubkey.txt
#2 lore raw

Re: [PATCH] [trivial] Correcting some style issues in drivers/crypto/geode-aes.c

Quoted 9 lines · Herbert Xu
Quoted 6 lines · Tristan Pourcelot
Quoted 1 line

From d50e5530201aa02a5232ca9f2458a7fdd18de374 Mon Sep 17 00:00:00 2001

From: Tristan Pourcelot <[email protected]>
Date: Thu, 2 Feb 2012 14:01:03 +0100
Subject: [PATCH] Correcting some style errors in
drivers/crypto/geode-aes.c

Sorry, your patch doesn't apply against cryptodev:

Sorry, I messed up my patch.
Here is a correct version that should apply correctly.

Quoted 8 lines
$ git apply ~/p
2 out of 3 hunks FAILED -- saving rejects to file drivers/crypto/geode-aes.c.rej
$

Please check and resend.

Thanks,

Thanks,

Quoted 1 line

From 27c351b5ccc20c088e613826fc80710dec3c0fb2 Mon Sep 17 00:00:00 2001

From: Tristan Pourcelot <[email protected]>
Date: Tue, 7 Feb 2012 20:24:03 +0100
Subject: [PATCH] Correcting some style issues in drivers/geode-aes.c

---
 drivers/crypto/geode-aes.c |   66
++++++++++++++++++++++----------------------
 1 files changed, 33 insertions(+), 33 deletions(-)
drivers/crypto/geode-aes.c +0 -0
index 219d09c..8a494b0 100644
@@ -278,23 +278,23 @@ static void fallback_exit_cip(struct crypto_tfm

*tfm)
}

static struct crypto_alg geode_alg = {
- .cra_name = "aes",
+ .cra_name = "aes",
.cra_driver_name = "geode-aes",
.cra_priority = 300,
.cra_alignmask = 15,
- .cra_flags = CRYPTO_ALG_TYPE_CIPHER |
- CRYPTO_ALG_NEED_FALLBACK,
- .cra_init = fallback_init_cip,
- .cra_exit = fallback_exit_cip,
+ .cra_flags = CRYPTO_ALG_TYPE_CIPHER |
+ CRYPTO_ALG_NEED_FALLBACK,
+ .cra_init = fallback_init_cip,
+ .cra_exit = fallback_exit_cip,
.cra_blocksize = AES_MIN_BLOCK_SIZE,
.cra_ctxsize = sizeof(struct geode_aes_op),
- .cra_module = THIS_MODULE,
- .cra_list = LIST_HEAD_INIT(geode_alg.cra_list),
- .cra_u = {
+ .cra_module = THIS_MODULE,
+ .cra_list = LIST_HEAD_INIT(geode_alg.cra_list),
+ .cra_u = {
.cipher = {
.cia_min_keysize = AES_MIN_KEY_SIZE,
.cia_max_keysize = AES_MAX_KEY_SIZE,
- .cia_setkey = geode_setkey_cip,
+ .cia_setkey = geode_setkey_cip,
.cia_encrypt = geode_encrypt,
.cia_decrypt = geode_decrypt
}
@@ -392,24 +392,24 @@ static struct crypto_alg geode_cbc_alg = {
.cra_name = "cbc(aes)",
.cra_driver_name = "cbc-aes-geode",
.cra_priority = 400,
- .cra_flags = CRYPTO_ALG_TYPE_BLKCIPHER |
- CRYPTO_ALG_NEED_FALLBACK,
- .cra_init = fallback_init_blk,
- .cra_exit = fallback_exit_blk,
+ .cra_flags = CRYPTO_ALG_TYPE_BLKCIPHER |
+ CRYPTO_ALG_NEED_FALLBACK,
+ .cra_init = fallback_init_blk,
+ .cra_exit = fallback_exit_blk,
.cra_blocksize = AES_MIN_BLOCK_SIZE,
.cra_ctxsize = sizeof(struct geode_aes_op),
.cra_alignmask = 15,
- .cra_type = &crypto_blkcipher_type,
- .cra_module = THIS_MODULE,
- .cra_list = LIST_HEAD_INIT(geode_cbc_alg.cra_list),
- .cra_u = {
+ .cra_type = &crypto_blkcipher_type,
+ .cra_module = THIS_MODULE,
+ .cra_list = LIST_HEAD_INIT(geode_cbc_alg.cra_list),
+ .cra_u = {
.blkcipher = {
.min_keysize = AES_MIN_KEY_SIZE,
.max_keysize = AES_MAX_KEY_SIZE,
- .setkey = geode_setkey_blk,
- .encrypt = geode_cbc_encrypt,
- .decrypt = geode_cbc_decrypt,
- .ivsize = AES_IV_LENGTH,
+ .setkey = geode_setkey_blk,
+ .encrypt = geode_cbc_encrypt,
+ .decrypt = geode_cbc_decrypt,
+ .ivsize = AES_IV_LENGTH,
}
}
};
@@ -475,26 +475,26 @@ geode_ecb_encrypt(struct blkcipher_desc *desc,
}

static struct crypto_alg geode_ecb_alg = {
- .cra_name = "ecb(aes)",
+ .cra_name = "ecb(aes)",
.cra_driver_name = "ecb-aes-geode",
.cra_priority = 400,
- .cra_flags = CRYPTO_ALG_TYPE_BLKCIPHER |
- CRYPTO_ALG_NEED_FALLBACK,
- .cra_init = fallback_init_blk,
- .cra_exit = fallback_exit_blk,
+ .cra_flags = CRYPTO_ALG_TYPE_BLKCIPHER |
+ CRYPTO_ALG_NEED_FALLBACK,
+ .cra_init = fallback_init_blk,
+ .cra_exit = fallback_exit_blk,
.cra_blocksize = AES_MIN_BLOCK_SIZE,
.cra_ctxsize = sizeof(struct geode_aes_op),
.cra_alignmask = 15,
- .cra_type = &crypto_blkcipher_type,
- .cra_module = THIS_MODULE,
- .cra_list = LIST_HEAD_INIT(geode_ecb_alg.cra_list),
- .cra_u = {
+ .cra_type = &crypto_blkcipher_type,
+ .cra_module = THIS_MODULE,
+ .cra_list = LIST_HEAD_INIT(geode_ecb_alg.cra_list),
+ .cra_u = {
.blkcipher = {
.min_keysize = AES_MIN_KEY_SIZE,
.max_keysize = AES_MAX_KEY_SIZE,
- .setkey = geode_setkey_blk,
- .encrypt = geode_ecb_encrypt,
- .decrypt = geode_ecb_decrypt,
+ .setkey = geode_setkey_blk,
+ .encrypt = geode_ecb_encrypt,
+ .decrypt = geode_ecb_decrypt,
}
}
};

Signature · 1 line
1.7.0.4
#3 lore raw

Re: [PATCH] [trivial] Correcting some style issues in drivers/crypto/geode-aes.c

Quoted 9 lines · Tristan Pourcelot
Quoted 8 lines · Herbert Xu
Quoted 6 lines · Tristan Pourcelot
Quoted 1 line

From d50e5530201aa02a5232ca9f2458a7fdd18de374 Mon Sep 17 00:00:00 2001

From: Tristan Pourcelot <[email protected]>
Date: Thu, 2 Feb 2012 14:01:03 +0100
Subject: [PATCH] Correcting some style errors in
drivers/crypto/geode-aes.c

Quoted 3 lines
Quoted 1 line

Sorry, your patch doesn't apply against cryptodev:

Sorry, I messed up my patch.
Here is a correct version that should apply correctly.

Sigh, it's still broken. Please try applying the patch the list sends back to you. Your mailer is wrapping long lines.

Signature · 3 lines
Email: Herbert Xu <[email protected]>
Home Page: http://gondor.apana.org.au/~herbert/
PGP Key: http://gondor.apana.org.au/~herbert/pubkey.txt