Skip to contentSkip to conversation

Crash in mtd_cls_suspend because mtd is NULL.

PATCH NeilBrown 2 participants 3 messages Feb 2, 2012 – Feb 5, 2012 Memory technology devices (MTD)

lore
Share & tools
lore

NeilBrown

author
#0 lore raw

Hi,
I just tried to suspend my GTA04 (OMAP based mobile phone platform) running
3.3-rc2 and it crashed in mtd_cls_suspend because mtd was NULL.

So for me, it looks like the following patch is a regression.

Is there anything I can do to help find the correct resolution here.

(It has some flash memory but I am not using it at all).

Thanks,
NeilBrown

commit 079c985e7a6f4ce60f931cebfdd5ee3c38347e31

Author: Artem Bityutskiy <[email protected]>
Date:   Fri Dec 30 17:15:59 2011 +0200

mtd: do not use mtd->suspend and mtd->resume directly

Just call the 'mtd_suspend()' and 'mtd_resume()' - they will do nothing if the operation is not defined.

drivers/mtd/mtdcore.c +1 -4
index 66494ee..6ae9ca0 100644
@@ -119,10 +119,7 @@ static int mtd_cls_suspend(struct device *dev, pm_message_t
 {
        struct mtd_info *mtd = dev_get_drvdata(dev);
 
-       if (mtd && mtd->suspend)
-               return mtd_suspend(mtd);
-       else
-               return 0;
+       return mtd_suspend(mtd);
 }
 
 static int mtd_cls_resume(struct device *dev)
#1 lore raw
Quoted 9 lines · NeilBrown

Hi,
I just tried to suspend my GTA04 (OMAP based mobile phone platform) running
3.3-rc2 and it crashed in mtd_cls_suspend because mtd was NULL.

So for me, it looks like the following patch is a regression.

Is there anything I can do to help find the correct resolution here.

(It has some flash memory but I am not using it at all).

Neil, there is a fix:

http://git.infradead.org/users/dedekind/l2-mtd.git/commit/da50432777e184dd889f077cf06a74aa24cb80d9

I should just be merged upstream. It was discussed here:

http://patchwork.ozlabs.org/patch/138551/

Signature · 2 lines
Best Regards,
Artem Bityutskiy
author
#2 lore raw
Quoted 11 lines · On Fri, 03 Feb 2012 06:58:24 +0200 Artem Bityutskiy <[email protected]> wrote:
Quoted 9 lines · NeilBrown

Hi,
I just tried to suspend my GTA04 (OMAP based mobile phone platform) running
3.3-rc2 and it crashed in mtd_cls_suspend because mtd was NULL.

So for me, it looks like the following patch is a regression.

Is there anything I can do to help find the correct resolution here.

(It has some flash memory but I am not using it at all).

Quoted 8 lines

Neil, there is a fix:

http://git.infradead.org/users/dedekind/l2-mtd.git/commit/da50432777e184dd889f077cf06a74aa24cb80d9

I should just be merged upstream. It was discussed here:

http://patchwork.ozlabs.org/patch/138551/

Thanks!

I pulled in the whole 'master' branch and it is much better.... (which is to say that suspend gets a bit further, and the thing that causes it to break isn't MTD (it is libertas_sdio..)).

Thanks,
NeilBrown