powerpc/wsp: Permanently enable PCI class code workaround
PATCH 1/1 powerpc/wsp: Permanently enable PCI class code workaround
It appears that on the Chroma card, the class code of the root complex is still wrong even on DD2 or later chips. This could be a firmware issue, but that breaks resource allocation so let's unconditionally fix it up.
Signed-off-by Benjamin Herrenschmidt <[email protected]>
--- arch/powerpc/platforms/wsp/wsp_pci.c | 8 ++++---- 1 files changed, 4 insertions(+), 4 deletions(-)
arch/powerpc/platforms/wsp/wsp_pci.c +4 -4
@@ -468,15 +468,15 @@ static void __init wsp_pcie_configure_hw(struct pci_controller *hose)#define DUMP_REG (x) \ pr_debug("%-30s : 0x%016llx\n", #x, in_be64(hose->cfg_data + x)) -#ifdef CONFIG_WSP_DD1_WORKAROUND_BAD_PCIE_CLASS -/* WSP DD1 has a bogus class code by default in the PCI-E -* root complex's built-in P2P bridge */ +/* +* Some WSP variants has a bogus class code by default in the PCI-E +* root complex's built-in P2P bridge +*/ val =in_be64 (hose->cfg_data +PCIE_REG_SYS_CFG1 );pr_debug ("PCI-E SYS_CFG1 : 0x%llx\n" , val);out_be64 (hose->cfg_data +PCIE_REG_SYS_CFG1 , (val & ~PCIE_REG_SYS_CFG1_CLASS_CODE ) | (PCI_CLASS_BRIDGE_PCI <<8 ));pr_debug ("PCI-E SYS_CFG1 : 0x%llx\n" ,in_be64 (hose->cfg_data +PCIE_REG_SYS_CFG1 )); -#endif /* CONFIG_WSP_DD1_WORKAROUND_BAD_PCIE_CLASS */ #ifdef CONFIG_WSP_DD1_WORKAROUND_DD1_TCE_BUGS /* XXX Disable TCE caching, it doesn't work on DD1 */
Signature · 1 line
1.7.7.3
Hi Ben,
Just a small grammar correction:
arch/powerpc/platforms/wsp/wsp_pci.c static void __init wsp_pcie_configure_hw(struct pci_controller *hose) · line 472
Quoted 5 lines · On Mon, 06 Feb 2012 10:50:04 +1100 Benjamin Herrenschmidt…
arch/powerpc/platforms/wsp/wsp_pci.c +2
-2-/* WSP DD1 has a bogus class code by default in the PCI-E -* root complex's built-in P2P bridge */ +/* +* Some WSP variants has a bogus class code by default in the PCI-E
^^^^
have
Signature · 2 lines
Cheers, Stephen Rothwell [email protected]