Skip to contentSkip to conversation

regmap: Don't use bitfields for booleans

PATCH New Mark Brown 1 participant 2 messages Feb 6, 2012

Subsystems (2)
lore
Share & tools
lore

Mark Brown

author
#0 lore raw

PATCH 1/2 regmap: Don't use bitfields for booleans

This was a cut'n'paste from some older code.

Since we're about to add debugfs support don't do the obvious thing and use bool, use u32 instead (which debugfs has been using since time immemorial).

---
 drivers/base/regmap/internal.h |    8 ++++----
 1 files changed, 4 insertions(+), 4 deletions(-)
drivers/base/regmap/internal.h +4 -4
index 9ec8d8f..abd7667 100644
@@ -66,16 +66,16 @@ struct regmap {
 	unsigned int num_reg_defaults_raw;
 
 	/* if set, only the cache is modified not the HW */
-	unsigned int cache_only:1;
+	u32 cache_only;
 	/* if set, only the HW is modified not the cache */
-	unsigned int cache_bypass:1;
+	u32 cache_bypass;
 	/* if set, remember to free reg_defaults_raw */
-	unsigned int cache_free:1;
+	bool cache_free;
 
 	struct reg_default *reg_defaults;
 	const void *reg_defaults_raw;
 	void *cache;
-	bool cache_dirty;
+	u32 cache_dirty;
 
 	struct reg_default *patch;
 	int patch_regs;
Signature · 1 line
1.7.9.rc1
author
#1 lore raw

PATCH 2/2 regmap: Add debugfs information for the cache status

Show all the cache status flags in debugfs if we have a cache.

---
 drivers/base/regmap/regmap-debugfs.c |    9 +++++++++
 1 files changed, 9 insertions(+), 0 deletions(-)
drivers/base/regmap/regmap-debugfs.c +9 -0
index 6f39747..b3b4b8f 100644
@@ -192,6 +192,15 @@ void regmap_debugfs_init(struct regmap *map)
 		debugfs_create_file("access", 0400, map->debugfs,
 				    map, &regmap_access_fops);
 	}
+
+	if (map->cache_type) {
+		debugfs_create_bool("cache_only", 0400, map->debugfs,
+				    &map->cache_only);
+		debugfs_create_bool("cache_dirty", 0400, map->debugfs,
+				    &map->cache_dirty);
+		debugfs_create_bool("cache_bypass", 0400, map->debugfs,
+				    &map->cache_bypass);
+	}
 }
 
 void regmap_debugfs_exit(struct regmap *map)
Signature · 1 line
1.7.9.rc1