regmap: Don't use bitfields for booleans
Subsystems (2)
PATCH 1/2 regmap: Don't use bitfields for booleans
This was a cut'n'paste from some older code.
Since we're about to add debugfs support don't do the obvious thing and use bool, use u32 instead (which debugfs has been using since time immemorial).
Signed-off-by Mark Brown <[email protected]>
--- drivers/base/regmap/internal.h | 8 ++++---- 1 files changed, 4 insertions(+), 4 deletions(-)
drivers/base/regmap/internal.h +4 -4
@@ -66,16 +66,16 @@ struct regmap {unsigned int num_reg_defaults_raw;/* if set, only the cache is modified not the HW */ - unsigned int cache_only:1; +u32 cache_only;/* if set, only the HW is modified not the cache */ - unsigned int cache_bypass:1; +u32 cache_bypass;/* if set, remember to free reg_defaults_raw */ - unsigned int cache_free:1; +bool cache_free;struct reg_default *reg_defaults;const void *reg_defaults_raw;void *cache; -bool cache_dirty; +u32 cache_dirty;struct reg_default *patch;int patch_regs;
Signature · 1 line
1.7.9.rc1
PATCH 2/2 regmap: Add debugfs information for the cache status
Show all the cache status flags in debugfs if we have a cache.
Signed-off-by Mark Brown <[email protected]>
--- drivers/base/regmap/regmap-debugfs.c | 9 +++++++++ 1 files changed, 9 insertions(+), 0 deletions(-)
drivers/base/regmap/regmap-debugfs.c +9 -0
@@ -192,6 +192,15 @@ void regmap_debugfs_init(struct regmap *map)debugfs_create_file ("access" ,0400 , map->debugfs, map, ®map_access_fops); } + +if (map->cache_type) { +debugfs_create_bool ("cache_only" ,0400 , map->debugfs, + &map->cache_only); +debugfs_create_bool ("cache_dirty" ,0400 , map->debugfs, + &map->cache_dirty); +debugfs_create_bool ("cache_bypass" ,0400 , map->debugfs, + &map->cache_bypass); + } }void regmap_debugfs_exit (struct regmap *map)
Signature · 1 line
1.7.9.rc1