ide: fix compilation errors when DEBUG_IDE is set
PATCH 1/1 ide: fix compilation errors when DEBUG_IDE is set
Signed-off-by Hervé Poussineau <[email protected]>
--- hw/ide/pci.c | 2 +- hw/ide/piix.c | 4 ++-- 2 files changed, 3 insertions(+), 3 deletions(-)
hw/ide/pci.c +1 -1
@@ -336,7 +336,7 @@ static uint64_t bmdma_addr_read(void *opaque, target_phys_addr_t addr, data = (bm->addr >> (addr *8 )) & mask;#ifdef DEBUG_IDE -printf ("%s: 0x%08x\n" , __func__, (unsigned )*data); +printf ("%s: 0x%08x\n" , __func__, (unsigned )data);#endif return data; }
hw/ide/piix.c +2 -2
@@ -53,7 +53,7 @@ static uint64_t bmdma_read(void *opaque, target_phys_addr_t addr, unsigned size)break ; }#ifdef DEBUG_IDE -printf ("bmdma: readb 0x%02x : 0x%02x\n" , addr, val); +printf ("bmdma: readb 0x%02x : 0x%02x\n" , (uint8_t )addr, val);#endif return val; }
@@ -68,7 +68,7 @@ static void bmdma_write(void *opaque, target_phys_addr_t addr, }#ifdef DEBUG_IDE -printf ("bmdma: writeb 0x%02x : 0x%02x\n" , addr, val); +printf ("bmdma: writeb 0x%02x : 0x%02x\n" , (uint8_t )addr, (uint8_t )val);#endif switch (addr &3 ) {case 0 :
Signature · 1 line
1.7.8.3
Stefan Hajnoczi
AppliedQuoted 6 lines · Hervé Poussineau
Signed-off-by Hervé Poussineau <[email protected]>--- hw/ide/pci.c | 2 +- hw/ide/piix.c | 4 ++-- 2 files changed, 3 insertions(+), 3 deletions(-)
The types in this code are a mess but your patch doesn't make it worse. It would be nice to clean things up in the future.
Thanks, applied to the trivial patches tree:
https://github.com/stefanha/qemu/commits/trivial-patches
Stefan