leds: lm3530: Fix setting pltfm->als_vmax
RFC PATCH 1/1 leds: lm3530: Fix setting pltfm->als_vmax
In current code, pltfm->als_vmin is set to LM3530_ALS_WINDOW_mV and pltfm->als_vmax is 0. This looks does not make sense.
I think what we want here is setting pltfm->als_vmax to LM3530_ALS_WINDOW_mV.
Both als_vmin and als_vmax local variables will be set to pltfm->als_vmin and pltfm->als_vmax by a few lines latter.
Thus also remove a redundant assignment for als_vmin and als_vmax in this patch.
---
Hi Kim,
I don't have this hardware, I'd appreciate if you can review and test this patch.
Thanks,
Axel
drivers/leds/leds-lm3530.c | 4 ++-- 1 files changed, 2 insertions(+), 2 deletions(-)
drivers/leds/leds-lm3530.c +2 -2
@@ -164,8 +164,8 @@ static int lm3530_init_registers(struct lm3530_data *drvdata)if (drvdata->mode ==LM3530_BL_MODE_ALS ) {if (pltfm->als_vmax ==0 ) { - pltfm->als_vmin = als_vmin =0 ; - pltfm->als_vmin = als_vmax = LM3530_ALS_WINDOW_mV; + pltfm->als_vmin =0 ; + pltfm->als_vmax = LM3530_ALS_WINDOW_mV; } als_vmin = pltfm->als_vmin;
Signature · 1 line
1.7.5.4
Quoted 13 lines
-----Original Message-----
From: Axel Lin [mailto:[email protected]]
Sent: Tuesday, February 07, 2012 3:23 PM
To: [email protected]
Cc: Shreshtha Kumar Sahu; Kim, Milo; Richard Purdie; Andrew Morton
Subject: [PATCH RFC] leds: lm3530: Fix settingpltfm->als_vmaxIn current code,
pltfm->als_vminis set toLM3530_ALS_WINDOW_mVandpltfm->als_vmaxis 0. This looks does not make sense.
I think what we want here is settingpltfm->als_vmaxtoLM3530_ALS_WINDOW_mV.
Quoted 7 lines
Both
als_vminandals_vmaxlocal variables will be set to pltfm-Quoted 1 line
als_vminand
pltfm->als_vmaxby a few lines latter.
Thus also remove a redundant assignment forals_vminandals_vmaxin this patch.Signed-off-by Axel Lin <[email protected]>
This patch makes sense and fixes wrong range of the ALS input voltage. It works well on the real board.
Thanks.
BTW, I'd suggest that 'pltfm' is replaced with 'pdata' if below patch has been updated. [PATCH v4 5/5] leds-lm3530: replace pltfm with pdata.
Best Regards,
Milo - ���{.n�+�������+%�����ݶ��w��{.n�+����{��G�����{ay� ʇڙ�,j��f���h��������z_�(�階�ݢj"���m������G������?����&���~��iO��z��v�^�m���� ������?�I�
Quoted 8 lines
This patch makes sense and fixes wrong range of the ALS input voltage. It works well on the real board.
Thanks.Acked-and-tested-by Milo(Woogyom) Kim <[email protected]>BTW, I'd suggest that 'pltfm' is replaced with 'pdata' if below patch has been updated. [PATCH v4 5/5] leds-lm3530: replace pltfm with pdata.
Well, I will redo the patch if Andrew takes your patch serial first. But I guess Andrew may take this one first for 3.3.
Regards,
Axel
Quoted 4 lines · On Tue, 7 Feb 2012 19:12:41 +0800 Axel Lin <[email protected]> wrote:
Quoted 4 lines
This patch makes sense and fixes wrong range of the ALS input voltage. It works well on the real board.
Thanks.
Quoted 8 lines
Quoted 4 lines
Acked-and-tested-by Milo(Woogyom) Kim <[email protected]>BTW, I'd suggest that 'pltfm' is replaced with 'pdata' if below patch has been updated. [PATCH v4 5/5] leds-lm3530: replace pltfm with pdata.
Well, I will redo the patch if Andrew takes your patch serial first. But I guess Andrew may take this one first for 3.3.
I applied "leds: lm3530: Fix setting pltfm->als_vmax" as-is for 3.3 and fixed up my copy of "leds-lm3530: replace pltfm with pdata".