Skip to contentSkip to conversation

Tegra: mmc: Fixed handling of interrupts in timeouts.

PATCH New Tom Warren 1 participant 1 message Feb 7, 2012

Subsystems (2)
MMC, SD and SDIO Tegra architecture support
lore
Share & tools
lore

Tom Warren

author
#0 lore raw

PATCH 1/1 Tegra: mmc: Fixed handling of interrupts in timeouts.

We are seeing occasional timeouts in the Tegra mmc code when we are reading from external MMC cards. These don't seem to be detrimental if they are handled properly. This CL properly clears the "normal interrupt status register" (norintsts) in error conditions. If we don't do this, when we come back into mmc_send_cmd() the register will still contain status from the last transaction.

Signed-off-by Doug Anderson <[email protected]>
Signed-off-by Tom Warren <[email protected]>
---
 drivers/mmc/tegra2_mmc.c |    4 ++++
 1 files changed, 4 insertions(+), 0 deletions(-)
drivers/mmc/tegra2_mmc.c +4 -0
index 5b4c9f6..e1d9067 100644
@@ -219,16 +219,19 @@ static int mmc_send_cmd(struct mmc *mmc, struct mmc_cmd *cmd,
 
 	if (i == retry) {
 		printf("%s: waiting for status update\n", __func__);
+		writel(mask, &host->reg->norintsts);
 		return TIMEOUT;
 	}
 
 	if (mask & TEGRA_MMC_NORINTSTS_CMD_TIMEOUT) {
 		/* Timeout Error */
 		debug("timeout: %08x cmd %d\n", mask, cmd->cmdidx);
+		writel(mask, &host->reg->norintsts);
 		return TIMEOUT;
 	} else if (mask & TEGRA_MMC_NORINTSTS_ERR_INTERRUPT) {
 		/* Error Interrupt */
 		debug("error: %08x cmd %d\n", mask, cmd->cmdidx);
+		writel(mask, &host->reg->norintsts);
 		return -1;
 	}
 

@@ -257,6 +260,7 @@ static int mmc_send_cmd(struct mmc *mmc, struct mmc_cmd *cmd,
 
 			if (i == retry) {
 				printf("%s: card is still busy\n", __func__);
+				writel(mask, &host->reg->norintsts);
 				return TIMEOUT;
 			}
Signature · 1 line
1.7.7.1