ixgb: Remove unnecessary defines, use pr_debug
Subsystems (3)
PATCH 1/1 ixgb: Remove unnecessary defines, use pr_debug
Use the current logging styles.
Remove unnecessary _DEBUG_DRIVER_ and PFX, use pr_debug. Coalesce format.
Signed-off-by Joe Perches <[email protected]>
--- drivers/net/ethernet/intel/ixgb/ixgb.h | 12 ------------ drivers/net/ethernet/intel/ixgb/ixgb_main.c | 4 ++-- 2 files changed, 2 insertions(+), 14 deletions(-)
drivers/net/ethernet/intel/ixgb/ixgb.h +0 -12
@@ -75,18 +75,6 @@ struct ixgb_adapter;#include "ixgb_ee.h" #include "ixgb_ids.h" -#define PFX "ixgb: " - -#ifdef _DEBUG_DRIVER_ -#define IXGB_DBG(fmt, args...) printk(KERN_DEBUG PFX fmt, ##args) -#else -#define IXGB_DBG(fmt, args...) \ -do { \ - if (0) \ - printk(KERN_DEBUG PFX fmt, ##args); \ -} while (0) -#endif -/* TX/RX descriptor defines */ #define DEFAULT_TXD 256#define MAX_TXD 4096
drivers/net/ethernet/intel/ixgb/ixgb_main.c +2 -2
@@ -2068,8 +2068,8 @@ ixgb_clean_rx_irq(struct ixgb_adapter *adapter, int *work_done, int work_to_do)/* All receives must fit into a single buffer */ -IXGB_DBG ("Receive packet consumed multiple buffers " -"length<%x>\n" , length); +pr_debug ("Receive packet consumed multiple buffers length<%x>\n" , + length);dev_kfree_skb_irq (skb); goto rxdesc_done;
Quoted 10 lines · Joe Perches
Use the current logging styles.
Remove unnecessary _DEBUG_DRIVER_ and PFX, use
pr_debug. Coalesce format.Signed-off-by Joe Perches <[email protected]>--- drivers/net/ethernet/intel/ixgb/ixgb.h | 12 ------------ drivers/net/ethernet/intel/ixgb/ixgb_main.c | 4 ++-- 2 files changed, 2 insertions(+), 14 deletions(-)
Thanks Joe! I have added the patch to my queue.