Skip to contentSkip to conversation

drm: Fix kcalloc parameters swapped

PATCH In review Axel Lin 2 participants 2 messages Feb 10, 2012

Subsystems (4)
DRM drivers DRM misc Intel i915 DRM drivers for GMA500 (Poulsbo, Moorestown and derivative chipsets)
lore
Share & tools
lore

Axel Lin

author
#0 lore raw

PATCH 1/1 drm: Fix kcalloc parameters swapped

The first parameter should be "number of elements" and the second parameter should be "element size".

Signed-off-by Axel Lin <[email protected]>
---
 drivers/gpu/drm/gma500/intel_gmbus.c |    2 +-
 drivers/gpu/drm/i915/intel_i2c.c     |    2 +-
 2 files changed, 2 insertions(+), 2 deletions(-)
drivers/gpu/drm/gma500/intel_gmbus.c +1 -1
index 147584a..9db9052 100644
@@ -395,7 +395,7 @@ int gma_intel_setup_gmbus(struct drm_device *dev)
 	struct drm_psb_private *dev_priv = dev->dev_private;
 	int ret, i;
 
-	dev_priv->gmbus = kcalloc(sizeof(struct intel_gmbus), GMBUS_NUM_PORTS,
+	dev_priv->gmbus = kcalloc(GMBUS_NUM_PORTS, sizeof(struct intel_gmbus),
 				  GFP_KERNEL);
 	if (dev_priv->gmbus == NULL)
 		return -ENOMEM;
drivers/gpu/drm/i915/intel_i2c.c +1 -1
index 7fa4f64..03573e0 100644
@@ -375,7 +375,7 @@ int intel_setup_gmbus(struct drm_device *dev)
 	struct drm_i915_private *dev_priv = dev->dev_private;
 	int ret, i;
 
-	dev_priv->gmbus = kcalloc(sizeof(struct intel_gmbus), GMBUS_NUM_PORTS,
+	dev_priv->gmbus = kcalloc(GMBUS_NUM_PORTS, sizeof(struct intel_gmbus),
 				  GFP_KERNEL);
 	if (dev_priv->gmbus == NULL)
 		return -ENOMEM;
Signature · 1 line
1.7.5.4