Skip to contentSkip to conversation

usb: add missing Kconfig UWB select to USB_WHCI_HCD and USB_HWA_HCD

PATCH In review Mike Galbraith 3 participants 5 messages Feb 10, 2012 – Feb 11, 2012 USB

lore
Share & tools
lore
#0 lore raw

PATCH 1/1 usb: add missing Kconfig UWB select to USB_WHCI_HCD and USB_HWA_HCD

usb: add missing Kconfig UWB select to USB_WHCI_HCD and USB_HWA_HCD

cripts/kconfig/conf --oldconfig Kconfig
warning: (USB_WHCI_HCD && USB_HWA_HCD) selects USB_WUSB which has unmet direct dependencies (USB_SUPPORT && EXPERIMENTAL && USB && PCI && UWB)
warning: (USB_WHCI_HCD) selects UWB_WHCI which has unmet direct dependencies (UWB && PCI)
warning: (USB_WHCI_HCD && USB_HWA_HCD) selects USB_WUSB which has unmet direct dependencies (USB_SUPPORT && EXPERIMENTAL && USB && PCI && UWB)
warning: (USB_WHCI_HCD) selects UWB_WHCI which has unmet direct dependencies (UWB && PCI)

drivers/usb/host/Kconfig +2 -0
index 91413ca..b224959 100644
@@ -547,6 +547,7 @@ config USB_WHCI_HCD
 	tristate "Wireless USB Host Controller Interface (WHCI) driver (EXPERIMENTAL)"
 	depends on EXPERIMENTAL
 	depends on PCI && USB
+	select UWB
 	select USB_WUSB
 	select UWB_WHCI
 	help
@@ -560,6 +561,7 @@ config USB_HWA_HCD
 	tristate "Host Wire Adapter (HWA) driver (EXPERIMENTAL)"
 	depends on EXPERIMENTAL
 	depends on USB
+	select UWB
 	select USB_WUSB
 	select UWB_HWA
 	help
#1 lore raw
Quoted 9 lines · Mike Galbraith

usb: add missing Kconfig UWB select to USB_WHCI_HCD and USB_HWA_HCD

cripts/kconfig/conf --oldconfig Kconfig
warning: (USB_WHCI_HCD && USB_HWA_HCD) selects USB_WUSB which has unmet direct dependencies (USB_SUPPORT && EXPERIMENTAL && USB && PCI && UWB)
warning: (USB_WHCI_HCD) selects UWB_WHCI which has unmet direct dependencies (UWB && PCI)
warning: (USB_WHCI_HCD && USB_HWA_HCD) selects USB_WUSB which has unmet direct dependencies (USB_SUPPORT && EXPERIMENTAL && USB && PCI && UWB)
warning: (USB_WHCI_HCD) selects UWB_WHCI which has unmet direct dependencies (UWB && PCI)

I have 2 patches in linux-next that fix the UWB/WUSB problems by using "depends on" instead...

Quoted 24 lines
drivers/usb/host/Kconfig +2 -1
index 91413ca..b224959 100644
@@ -547,6 +547,7 @@ config USB_WHCI_HCD
 	tristate "Wireless USB Host Controller Interface (WHCI) driver (EXPERIMENTAL)"
 	depends on EXPERIMENTAL
 	depends on PCI && USB
+	select UWB
 	select USB_WUSB
 	select UWB_WHCI
 	help
@@ -560,6 +561,7 @@ config USB_HWA_HCD
 	tristate "Host Wire Adapter (HWA) driver (EXPERIMENTAL)"
 	depends on EXPERIMENTAL
 	depends on USB
+	select UWB
 	select USB_WUSB
 	select UWB_HWA
 	help
 
 
--
Signature · 2 lines
~Randy
*** Remember to use Documentation/SubmitChecklist when testing your code ***
#2 lore raw
Quoted 9 lines · Randy Dunlap
Quoted 8 lines · Mike Galbraith

usb: add missing Kconfig UWB select to USB_WHCI_HCD and USB_HWA_HCD

cripts/kconfig/conf --oldconfig Kconfig
warning: (USB_WHCI_HCD && USB_HWA_HCD) selects USB_WUSB which has unmet direct dependencies (USB_SUPPORT && EXPERIMENTAL && USB && PCI && UWB)
warning: (USB_WHCI_HCD) selects UWB_WHCI which has unmet direct dependencies (UWB && PCI)
warning: (USB_WHCI_HCD && USB_HWA_HCD) selects USB_WUSB which has unmet direct dependencies (USB_SUPPORT && EXPERIMENTAL && USB && PCI && UWB)
warning: (USB_WHCI_HCD) selects UWB_WHCI which has unmet direct dependencies (UWB && PCI)

Quoted 4 lines
Quoted 1 line

I have 2 patches in linux-next that fix the UWB/WUSB problems by using "depends on" instead...

Yes, this should all now be resolved, Mike can you verify this please?

thanks,

greg k-h

#3 lore raw
Quoted 10 lines · Greg Kroah-Hartman
Quoted 9 lines · Randy Dunlap
Quoted 8 lines · Mike Galbraith

usb: add missing Kconfig UWB select to USB_WHCI_HCD and USB_HWA_HCD

cripts/kconfig/conf --oldconfig Kconfig
warning: (USB_WHCI_HCD && USB_HWA_HCD) selects USB_WUSB which has unmet direct dependencies (USB_SUPPORT && EXPERIMENTAL && USB && PCI && UWB)
warning: (USB_WHCI_HCD) selects UWB_WHCI which has unmet direct dependencies (UWB && PCI)
warning: (USB_WHCI_HCD && USB_HWA_HCD) selects USB_WUSB which has unmet direct dependencies (USB_SUPPORT && EXPERIMENTAL && USB && PCI && UWB)
warning: (USB_WHCI_HCD) selects UWB_WHCI which has unmet direct dependencies (UWB && PCI)

Quoted 6 lines
Quoted 4 lines
Quoted 1 line

I have 2 patches in linux-next that fix the UWB/WUSB problems by using "depends on" instead...

Yes, this should all now be resolved, Mike can you verify this please?

Nah, Randy surely did, and it would be hard to mess it up ;-)

-Mike

#4 lore raw
Quoted 11 lines · Mike Galbraith
Quoted 10 lines · Greg Kroah-Hartman
Quoted 9 lines · Randy Dunlap
Quoted 8 lines · Mike Galbraith

usb: add missing Kconfig UWB select to USB_WHCI_HCD and USB_HWA_HCD

cripts/kconfig/conf --oldconfig Kconfig
warning: (USB_WHCI_HCD && USB_HWA_HCD) selects USB_WUSB which has unmet direct dependencies (USB_SUPPORT && EXPERIMENTAL && USB && PCI && UWB)
warning: (USB_WHCI_HCD) selects UWB_WHCI which has unmet direct dependencies (UWB && PCI)
warning: (USB_WHCI_HCD && USB_HWA_HCD) selects USB_WUSB which has unmet direct dependencies (USB_SUPPORT && EXPERIMENTAL && USB && PCI && UWB)
warning: (USB_WHCI_HCD) selects UWB_WHCI which has unmet direct dependencies (UWB && PCI)

Quoted 8 lines
Quoted 6 lines
Quoted 4 lines
Quoted 1 line

I have 2 patches in linux-next that fix the UWB/WUSB problems by using "depends on" instead...

Yes, this should all now be resolved, Mike can you verify this please?

Nah, Randy surely did, and it would be hard to mess it up ;-)

Hah. It took me two simple patches to get it right AFAIK. :(

Signature · 2 lines
~Randy
*** Remember to use Documentation/SubmitChecklist when testing your code ***