Skip to contentSkip to conversation

ASoC: Show device id in the debug message

PATCH Applied Axel Lin 2 participants 2 messages Feb 16, 2012

Subsystems (3)
Sound ASoC Wolfson microelectronics drivers
lore
Share & tools
lore

Axel Lin

author
#0 lore raw

PATCH 1/1 ASoC: Show device id in the debug message

Show the id we read when the id mismatch is detected. This is useful for debugging.

Signed-off-by Axel Lin <[email protected]>
---
 sound/soc/codecs/wm8962.c |    2 +-
 sound/soc/codecs/wm8996.c |    2 +-
 sound/soc/codecs/wm9090.c |    2 +-
 3 files changed, 3 insertions(+), 3 deletions(-)
sound/soc/codecs/wm8962.c +1 -1
index 172dcac..5a6516e 100644
@@ -3718,7 +3718,7 @@ static __devinit int wm8962_i2c_probe(struct i2c_client *i2c,
 	}
 	if (reg != 0x6243) {
 		dev_err(&i2c->dev,
-			"Device is not a WM8962, ID %x != 0x6243\n", ret);
+			"Device is not a WM8962, ID %x != 0x6243\n", reg);
 		ret = -EINVAL;
 		goto err_regmap;
 	}
sound/soc/codecs/wm8996.c +1 -1
index 759ea69..c3bde4a 100644
@@ -3185,7 +3185,7 @@ static __devinit int wm8996_i2c_probe(struct i2c_client *i2c,
 		goto err_regmap;
 	}
 	if (reg != 0x8915) {
-		dev_err(&i2c->dev, "Device is not a WM8996, ID %x\n", ret);
+		dev_err(&i2c->dev, "Device is not a WM8996, ID %x\n", reg);
 		ret = -EINVAL;
 		goto err_regmap;
 	}
sound/soc/codecs/wm9090.c +1 -1
index e8280ee..4b263b6 100644
@@ -639,7 +639,7 @@ static int wm9090_i2c_probe(struct i2c_client *i2c,
 	if (ret < 0)
 		goto err;
 	if (reg != 0x9093) {
-		dev_err(&i2c->dev, "Device is not a WM9090, ID=%x\n", ret);
+		dev_err(&i2c->dev, "Device is not a WM9090, ID=%x\n", reg);
 		ret = -ENODEV;
 		goto err;
 	}
Signature · 1 line
1.7.5.4
Applied
#1 lore raw
Quoted 2 lines · Axel Lin

Show the id we read when the id mismatch is detected. This is useful for debugging.

Applied, thanks.