Skip to contentSkip to conversation

Staging: crystalhd: Get rid of unecessary BCMLOG_ENTER macro

PATCH In review Jorgyano Vieira 1 participant 1 message Feb 17, 2012 Staging

lore
Share & tools
lore
#0 lore raw

PATCH 2/3 Staging: crystalhd: Get rid of unecessary BCMLOG_ENTER macro

The BCMLOG_ENTER macro is used only in five functions, perhaps it is remainder of debugging some specific problem, now, this macro don't seems to be useful, so it should be removed.

---
 drivers/staging/crystalhd/crystalhd_hw.c   |    3 ---
 drivers/staging/crystalhd/crystalhd_lnx.c  |    4 ----
 drivers/staging/crystalhd/crystalhd_misc.h |    7 -------
 3 files changed, 0 insertions(+), 14 deletions(-)
drivers/staging/crystalhd/crystalhd_hw.c +0 -3
index eeddee9..2d02ed2 100644
@@ -1627,7 +1627,6 @@ enum BC_STATUS crystalhd_download_fw(struct crystalhd_adp *adp, void *buffer, ui
 	uint32_t fw_sig_len = 36;
 	uint32_t dram_offset = BC_FWIMG_ST_ADDR, sig_reg;
 
-	BCMLOG_ENTER;
 
 	if (!adp || !buffer || !sz) {
 		BCMLOG_ERR("Invalid Params.\n");
@@ -1724,8 +1723,6 @@ enum BC_STATUS crystalhd_do_fw_cmd(struct crystalhd_hw *hw,
 
 	crystalhd_create_event(&fw_cmd_event);
 
-	BCMLOG_ENTER;
-
 	if (!hw || !fw_cmd) {
 		BCMLOG_ERR("Invalid Arguments\n");
 		return BC_STS_INV_ARG;
drivers/staging/crystalhd/crystalhd_lnx.c +0 -4
index 7e0c199..9dca92c 100644
@@ -298,7 +298,6 @@ static int chd_dec_open(struct inode *in, struct file *fd)
 	enum BC_STATUS sts = BC_STS_SUCCESS;
 	struct crystalhd_user *uc = NULL;
 
-	BCMLOG_ENTER;
 	if (!adp) {
 		BCMLOG_ERR("Invalid adp\n");
 		return -EINVAL;
@@ -327,7 +326,6 @@ static int chd_dec_close(struct inode *in, struct file *fd)
 	struct crystalhd_adp *adp = chd_get_adp();
 	struct crystalhd_user *uc;
 
-	BCMLOG_ENTER;
 	if (!adp) {
 		BCMLOG_ERR("Invalid adp\n");
 		return -EINVAL;
@@ -513,8 +511,6 @@ static void __devexit chd_dec_pci_remove(struct pci_dev *pdev)
 	struct crystalhd_adp *pinfo;
 	enum BC_STATUS sts = BC_STS_SUCCESS;
 
-	BCMLOG_ENTER;
-
 	pinfo = pci_get_drvdata(pdev);
 	if (!pinfo) {
 		BCMLOG_ERR("could not get adp\n");
drivers/staging/crystalhd/crystalhd_misc.h +0 -7
index eedd9b7..d2f7256 100644
@@ -200,15 +200,8 @@ enum _chd_log_levels {
 	BCMLOG_INFO		= 0x00000001,	/* Generic informational */
 	BCMLOG_DBG		= 0x00000002,	/* First level Debug info */
 	BCMLOG_SSTEP		= 0x00000004,	/* Stepping information */
-	BCMLOG_ENTER_LEAVE	= 0x00000008,	/* stack tracking */
 };
 
-#define BCMLOG_ENTER						\
-do {								\
-	if (g_linklog_level & BCMLOG_ENTER_LEAVE)		\
-		printk(KERN_DEBUG "Entered %s\n", __func__);	\
-} while (0)
-
 
 #define BCMLOG(trace, fmt, args...)	\
 do {					\
Signature · 1 line
1.7.2.5