pull request: linux-firmware: update cxgb* firmwares
Hi David,
Can you please pull from the following URL?
git://git.chelsio.net/pub/git/linux-firmware.git for-david
It contains the following commits:
03cadf2 linux-firmware: update cxgb3 driver firmware to revision 7.12.0 235dfaf linux-firmware: add t4fw-1.4.16.0.bin firmware for cxgb4 driver. e2ea873 linux-firmware: remove current t4fw.bin
The following changes since commit 15888a2eab052ac3d3f49334e4f6f05f347a516e:
bnx2x: Adding FW 7.0.29.0 (2011-10-24 16:31:44 +0200)
are available in the git repository at:
git://git.chelsio.net/pub/git/linux-firmware.git for-david
Divy Le Ray (3):
linux-firmware: remove current t4fw.bin
linux-firmware: add t4fw-1.4.16.0.bin firmware for cxgb4 driver.
linux-firmware: update cxgb3 driver firmware to revision 7.12.0
WHENCE | 3 ++- cxgb3/t3fw-7.12.0.bin | Bin 0 -> 31812 bytes cxgb4/t4fw-1.4.16.0.bin | Bin 0 -> 298496 bytes cxgb4/t4fw.bin | Bin 241664 -> 0 bytes 4 files changed, 2 insertions(+), 1 deletions(-) create mode 100755 cxgb3/t3fw-7.12.0.bin create mode 100644 cxgb4/t4fw-1.4.16.0.bin delete mode 100644 cxgb4/t4fw.bin
Cheers,
Divy
Quoted 22 lines · Divy Le Ray
Hi David,
Can you please pull from the following URL?
git://git.chelsio.net/pub/git/linux-firmware.gitfor-davidIt contains the following commits:
03cadf2 linux-firmware: update cxgb3 driver firmware to revision 7.12.0 235dfaf linux-firmware: add t4fw-1.4.16.0.bin firmware for cxgb4 driver. e2ea873 linux-firmware: remove current t4fw.binThe following changes since commit
15888a2eab052ac3d3f49334e4f6f05f347a516e:bnx2x: Adding FW 7.0.29.0 (2011-10-24 16:31:44 +0200)
are available in the git repository at:
git://git.chelsio.net/pub/git/linux-firmware.gitfor-davidDivy Le Ray (3):
linux-firmware: remove current t4fw.bin
linux-firmware: add t4fw-1.4.16.0.bin firmware for cxgb4 driver.
linux-firmware: update cxgb3 driver firmware to revision 7.12.0
Quoted 9 lines
WHENCE | 3 ++- cxgb3/t3fw-7.12.0.bin | Bin 0 -> 31812 bytes cxgb4/t4fw-1.4.16.0.bin | Bin 0 -> 298496 bytes cxgb4/t4fw.bin | Bin 241664 -> 0 bytes 4 files changed, 2 insertions(+), 1 deletions(-) create mode 100755 cxgb3/t3fw-7.12.0.bin create mode 100644 cxgb4/t4fw-1.4.16.0.bin delete mode 100644 cxgb4/t4fw.bin
Deleting the old firmware is a bad idea. You've haven't modified the driver in net or net-next to use the new firmware, and until you do, kernels won't be able to find the firmware the driver is requesting. You should make firmware changes addative. Add new versions of firmware, but keep the old ones (at least for a while). Thank you for moving cxgb4 to a versioned firmware file though. I presume there is a pending update to change the FW_FNAME definition to pending? Neil
Quoted 7 lines
Cheers,
Divy
Quoted 32 lines · Neil Horman
Quoted 22 lines · Divy Le Ray
Hi David,
Can you please pull from the following URL?
git://git.chelsio.net/pub/git/linux-firmware.gitfor-davidIt contains the following commits:
03cadf2 linux-firmware: update cxgb3 driver firmware to revision 7.12.0 235dfaf linux-firmware: add t4fw-1.4.16.0.bin firmware for cxgb4 driver. e2ea873 linux-firmware: remove current t4fw.binThe following changes since commit
15888a2eab052ac3d3f49334e4f6f05f347a516e:bnx2x: Adding FW 7.0.29.0 (2011-10-24 16:31:44 +0200)are available in the git repository at:
git://git.chelsio.net/pub/git/linux-firmware.gitfor-davidDivy Le Ray (3):
linux-firmware: remove current t4fw.bin
linux-firmware: add t4fw-1.4.16.0.bin firmware for cxgb4 driver.
linux-firmware: update cxgb3 driver firmware to revision 7.12.0Quoted 9 lines
WHENCE | 3 ++- cxgb3/t3fw-7.12.0.bin | Bin 0 -> 31812 bytes cxgb4/t4fw-1.4.16.0.bin | Bin 0 -> 298496 bytes cxgb4/t4fw.bin | Bin 241664 -> 0 bytes 4 files changed, 2 insertions(+), 1 deletions(-)create mode 100755 cxgb3/t3fw-7.12.0.bin
create mode 100644 cxgb4/t4fw-1.4.16.0.bin
delete mode 100644 cxgb4/t4fw.bin
Quoted 6 lines
Deleting the old firmware is a bad idea. You've haven't modified the driver in net or net-next to use the new firmware, and until you do, kernels won't be able to find the firmware the driver is requesting. You should make firmware changes addative. Add new versions of firmware, but keep the old ones (at least for a while). Thank you for moving cxgb4 to a versioned firmware file though. I presume there is a pending update to change the
FW_FNAMEdefinition to pending?
Hi Neil,
Thank you for the review. I have updated the patch series with the following changes:
- Rename the existing t4fw.bin file as t4fw-1.3.10.0.bin
- Add t4fw.bin as a symlink to the latest t4fw revision.
The driver looks up "t4fw.bin", the symlink allows updates of the FW without actually modifying the driver source. Also, if the firmware revision under /lib/firmware/cxgb4/t4fw.bin is more recent than the adapter's embedded FW, the driver will update it. The FW revisions are forward compatible.
The following changes since commit 15888a2eab052ac3d3f49334e4f6f05f347a516e:
bnx2x: Adding FW 7.0.29.0 (2011-10-24 16:31:44 +0200)
are available in the git repository at:
git://git.chelsio.net/pub/git/linux-firmware.git for-david
Divy Le Ray (3):
linux-firmware: rename t4fw.bin
linux-firmware: add t4fw-1.4.16.0.bin firmware for cxgb4 driver.
linux-firmware: update cxgb3 driver firmware to revision 7.12.0
WHENCE | 4 +++- cxgb3/t3fw-7.12.0.bin | Bin 0 -> 31812 bytes cxgb4/t4fw-1.3.10.0.bin | Bin 0 -> 241664 bytes cxgb4/t4fw-1.4.16.0.bin | Bin 0 -> 298496 bytes cxgb4/t4fw.bin | Bin 241664 -> 17 bytes 5 files changed, 3 insertions(+), 1 deletions(-) create mode 100755 cxgb3/t3fw-7.12.0.bin create mode 100644 cxgb4/t4fw-1.3.10.0.bin create mode 100644 cxgb4/t4fw-1.4.16.0.bin mode change 100644 => 120000 cxgb4/t4fw.bin
Cheers,
Divy
Neil Horman
Acked-byQuoted 40 lines · Divy Le Ray
Quoted 32 lines · Neil Horman
Quoted 22 lines · Divy Le Ray
Hi David,
Can you please pull from the following URL?
git://git.chelsio.net/pub/git/linux-firmware.gitfor-davidIt contains the following commits:
03cadf2 linux-firmware: update cxgb3 driver firmware to revision 7.12.0 235dfaf linux-firmware: add t4fw-1.4.16.0.bin firmware for cxgb4 driver. e2ea873 linux-firmware: remove current t4fw.binThe following changes since commit
15888a2eab052ac3d3f49334e4f6f05f347a516e:bnx2x: Adding FW 7.0.29.0 (2011-10-24 16:31:44 +0200)
are available in the git repository at:
git://git.chelsio.net/pub/git/linux-firmware.gitfor-davidDivy Le Ray (3):
linux-firmware: remove current t4fw.bin
linux-firmware: add t4fw-1.4.16.0.bin firmware for cxgb4 driver.
linux-firmware: update cxgb3 driver firmware to revision 7.12.0Quoted 9 lines
WHENCE | 3 ++- cxgb3/t3fw-7.12.0.bin | Bin 0 -> 31812 bytes cxgb4/t4fw-1.4.16.0.bin | Bin 0 -> 298496 bytes cxgb4/t4fw.bin | Bin 241664 -> 0 bytes 4 files changed, 2 insertions(+), 1 deletions(-) create mode 100755 cxgb3/t3fw-7.12.0.bin create mode 100644 cxgb4/t4fw-1.4.16.0.bin delete mode 100644 cxgb4/t4fw.binQuoted 6 lines
Deleting the old firmware is a bad idea. You've haven't modified the driver in net or net-next to use the new firmware, and until you do, kernels won't be able to find the firmware the driver is requesting. You should make firmware changes addative. Add new versions of firmware, but keep the old ones (at least for a while). Thank you for moving cxgb4 to a versioned firmware file though. I presume there is a pending update to change the
FW_FNAMEdefinition to pending?
Quoted 7 lines
Hi Neil,
Thank you for the review. I have updated the patch series with the following changes:
- Rename the existing t4fw.bin file as t4fw-1.3.10.0.bin
- Add t4fw.bin as a symlink to the latest t4fw revision.
Thank you, that helps.
Quoted 6 lines
The driver looks up "t4fw.bin", the symlink allows updates of the FW without actually modifying the driver source.
Also, if the firmware revision under/lib/firmware/cxgb4/t4fw.binis more recent than the adapter's embedded FW,
the driver will update it. The FW revisions are forward compatible.
Thats fine, I presume then we can expect a commit to the cxgb3 driver shortly, updatnig the FW_VERSION_MINOR macro?
Hi Ben, David,
I just realize that the rules to submit patches or pull requests to linux-firmware have changed recently. I had posted a pull request last week against David's tree (https://lkml.org/lkml/2012/2/13/27).
I am now re-posting the pull request against the official tree.
Can you please pull from the following URL?
git://git.chelsio.net/pub/git/linux-firmware.git for-upstream
It contains the following commits:
07af67c linux-firmware: update cxgb3 driver firmware to revision 7.12.0 196909a linux-firmware: add t4fw-1.4.16.0.bin firmware for cxgb4 driver. 3b460f1 linux-firmware: rename t4fw.bin
The following changes since commit 38118a598df73d5a9fd72bf04910e8298db82a46:
linux-firmware: brcm: add firmware for bcm43236 usb device
(2012-02-11 19:20:10 +0000)
are available in the git repository at:
git://git.chelsio.net/pub/git/linux-firmware for-upstream
Divy Le Ray (3):
linux-firmware: rename t4fw.bin
linux-firmware: add t4fw-1.4.16.0.bin firmware for cxgb4 driver.
linux-firmware: update cxgb3 driver firmware to revision 7.12.0
WHENCE | 4 +++- cxgb3/t3fw-7.12.0.bin | Bin 0 -> 31812 bytes cxgb4/t4fw-1.3.10.0.bin | Bin 0 -> 241664 bytes cxgb4/t4fw-1.4.16.0.bin | Bin 0 -> 298496 bytes cxgb4/t4fw.bin | Bin 241664 -> 17 bytes 5 files changed, 3 insertions(+), 1 deletions(-) create mode 100755 cxgb3/t3fw-7.12.0.bin create mode 100644 cxgb4/t4fw-1.3.10.0.bin create mode 100644 cxgb4/t4fw-1.4.16.0.bin mode change 100644 => 120000 cxgb4/t4fw.bin
Cheers,
Divy
On Wed, 2012-02-15 at 23:18 -0800, Divy Le Ray wrote:
[...]
Quoted 19 lines
The following changes since commit
38118a598df73d5a9fd72bf04910e8298db82a46:linux-firmware: brcm: add firmware for bcm43236 usb device
(2012-02-11 19:20:10 +0000)are available in the git repository at:
git://git.chelsio.net/pub/git/linux-firmwarefor-upstreamDivy Le Ray (3):
linux-firmware: rename t4fw.bin
linux-firmware: add t4fw-1.4.16.0.bin firmware for cxgb4 driver.
linux-firmware: update cxgb3 driver firmware to revision 7.12.0WHENCE | 4 +++- cxgb3/t3fw-7.12.0.bin | Bin 0 -> 31812 bytes cxgb4/t4fw-1.3.10.0.bin | Bin 0 -> 241664 bytes cxgb4/t4fw-1.4.16.0.bin | Bin 0 -> 298496 bytes cxgb4/t4fw.bin | Bin 241664 -> 17 bytes 5 files changed, 3 insertions(+), 1 deletions(-)
Quoted 4 lines
create mode 100755 cxgb3/t3fw-7.12.0.bin
create mode 100644 cxgb4/t4fw-1.3.10.0.bin
create mode 100644 cxgb4/t4fw-1.4.16.0.bin
mode change 100644 => 120000 cxgb4/t4fw.bin
Are there any versions of the cxgb4 driver that will specifically request cxgb4/t4fw-1.3.10.0.bin? If not, what's the point of keeping it around after changing the cxgb4/t4fw.bin symlink?
Ben.
Quoted 4 lines
Cheers,
Divy
Signature · 2 lines
Ben Hutchings Beware of programmers who carry screwdrivers. - Leonard Brandwein
Quoted 26 lines · Ben Hutchings
On Wed, 2012-02-15 at 23:18 -0800, Divy Le Ray wrote:
[...]Quoted 19 lines
The following changes since commit
38118a598df73d5a9fd72bf04910e8298db82a46:linux-firmware: brcm: add firmware for bcm43236 usb device
(2012-02-11 19:20:10 +0000)are available in the git repository at:
git://git.chelsio.net/pub/git/linux-firmwarefor-upstreamDivy Le Ray (3):
linux-firmware: rename t4fw.bin
linux-firmware: add t4fw-1.4.16.0.bin firmware for cxgb4 driver.
linux-firmware: update cxgb3 driver firmware to revision 7.12.0WHENCE | 4 +++- cxgb3/t3fw-7.12.0.bin | Bin 0 -> 31812 bytes cxgb4/t4fw-1.3.10.0.bin | Bin 0 -> 241664 bytes cxgb4/t4fw-1.4.16.0.bin | Bin 0 -> 298496 bytes cxgb4/t4fw.bin | Bin 241664 -> 17 bytes 5 files changed, 3 insertions(+), 1 deletions(-)Quoted 4 lines
create mode 100755 cxgb3/t3fw-7.12.0.bin
create mode 100644 cxgb4/t4fw-1.3.10.0.bin
create mode 100644 cxgb4/t4fw-1.4.16.0.bin
mode change 100644 => 120000 cxgb4/t4fw.bin
Quoted 6 lines
Are there any versions of the cxgb4 driver that will specifically request cxgb4/t4fw-1.3.10.0.bin? If not, what's the point of keeping it around after changing the cxgb4/t4fw.bin symlink?
Ben.
I think the right thing to do is update the chelsio driver to do exactly that, request a specific version of firmware (or range of versions), like most other drivers do. That way a single system can boot kernels with varying driver versions, each of which may require a different firmware api level. Regards
Neil
Quoted 8 lines
Quoted 4 lines
Cheers,
DivySignature · 2 lines
Ben Hutchings Beware of programmers who carry screwdrivers. - Leonard Brandwein
Quoted 25 lines · Ben Hutchings
On Wed, 2012-02-15 at 23:18 -0800, Divy Le Ray wrote:
[...]Quoted 19 lines
The following changes since commit
38118a598df73d5a9fd72bf04910e8298db82a46:linux-firmware: brcm: add firmware for bcm43236 usb device
(2012-02-11 19:20:10 +0000)are available in the git repository at:
git://git.chelsio.net/pub/git/linux-firmwarefor-upstreamDivy Le Ray (3):
linux-firmware: rename t4fw.bin
linux-firmware: add t4fw-1.4.16.0.bin firmware for cxgb4 driver.
linux-firmware: update cxgb3 driver firmware to revision 7.12.0WHENCE | 4 +++- cxgb3/t3fw-7.12.0.bin | Bin 0 -> 31812 bytes cxgb4/t4fw-1.3.10.0.bin | Bin 0 -> 241664 bytes cxgb4/t4fw-1.4.16.0.bin | Bin 0 -> 298496 bytes cxgb4/t4fw.bin | Bin 241664 -> 17 bytes 5 files changed, 3 insertions(+), 1 deletions(-)Quoted 4 lines
create mode 100755 cxgb3/t3fw-7.12.0.bin
create mode 100644 cxgb4/t4fw-1.3.10.0.bin
create mode 100644 cxgb4/t4fw-1.4.16.0.bin
mode change 100644 => 120000 cxgb4/t4fw.bin
Quoted 3 lines
Are there any versions of the cxgb4 driver that will specifically request cxgb4/t4fw-1.3.10.0.bin? If not, what's the point of keeping it around after changing the cxgb4/t4fw.bin symlink?
Hi Ben,
I originally removed cxgb4/t4fw-1.3.10.0.bin when I posted the request against David's tree. Subsequent review from Neil requested to keep it around at least for a while (https://lkml.org/lkml/2012/2/11/61).
Either way is fine to me.
Cheers,
Divy
Quoted 30 lines · Divy Le Ray
Quoted 25 lines · Ben Hutchings
On Wed, 2012-02-15 at 23:18 -0800, Divy Le Ray wrote:
[...]Quoted 19 lines
The following changes since commit
38118a598df73d5a9fd72bf04910e8298db82a46:linux-firmware: brcm: add firmware for bcm43236 usb device
(2012-02-11 19:20:10 +0000)are available in the git repository at:
git://git.chelsio.net/pub/git/linux-firmwarefor-upstreamDivy Le Ray (3):
linux-firmware: rename t4fw.bin
linux-firmware: add t4fw-1.4.16.0.bin firmware for cxgb4 driver.
linux-firmware: update cxgb3 driver firmware to revision 7.12.0WHENCE | 4 +++- cxgb3/t3fw-7.12.0.bin | Bin 0 -> 31812 bytes cxgb4/t4fw-1.3.10.0.bin | Bin 0 -> 241664 bytes cxgb4/t4fw-1.4.16.0.bin | Bin 0 -> 298496 bytes cxgb4/t4fw.bin | Bin 241664 -> 17 bytes 5 files changed, 3 insertions(+), 1 deletions(-)Quoted 4 lines
create mode 100755 cxgb3/t3fw-7.12.0.bin
create mode 100644 cxgb4/t4fw-1.3.10.0.bin
create mode 100644 cxgb4/t4fw-1.4.16.0.bin
mode change 100644 => 120000 cxgb4/t4fw.binQuoted 3 lines
Are there any versions of the cxgb4 driver that will specifically request cxgb4/t4fw-1.3.10.0.bin? If not, what's the point of keeping it around after changing the cxgb4/t4fw.bin symlink?
Quoted 7 lines
Hi Ben,
I originally removed cxgb4/t4fw-1.3.10.0.bin when I posted the request against David's tree.
Subsequent review from Neil requested to keep it around at least for a while (https://lkml.org/lkml/2012/2/11/61).
Either way is fine to me.
No, Neil said you need to maintain cxgb4/t4fw.bin, but it's perfectly fine for that to be a symlink.
Ben.
Signature · 2 lines
Ben Hutchings Every program is either trivial or else contains at least one bug
Quoted 2 lines · Ben Hutchings
Quoted 1 line · Divy Le Ray
On 2/16/2012 7:41 PM, Ben Hutchings wrote:
[...]
Quoted 6 lines
Quoted 6 lines
Quoted 3 lines
Are there any versions of the cxgb4 driver that will specifically request cxgb4/t4fw-1.3.10.0.bin? If not, what's the point of keeping it around after changing the cxgb4/t4fw.bin symlink?
Hi Ben,
Quoted 8 lines
Quoted 5 lines
I originally removed cxgb4/t4fw-1.3.10.0.bin when I posted the request against David's tree.
Subsequent review from Neil requested to keep it around at least for a while (https://lkml.org/lkml/2012/2/11/61).
Either way is fine to me.No, Neil said you need to maintain cxgb4/t4fw.bin, but it's perfectly fine for that to be a symlink.
So I've pulled your changes and then deleted the cxgb4/t4fw-1.3.10.0.bin as a separate commit.
Ben.
Signature · 2 lines
Ben Hutchings Every program is either trivial or else contains at least one bug
Quoted 14 lines · Ben Hutchings
Quoted 2 lines · Ben Hutchings
Quoted 1 line · Divy Le Ray
On 2/16/2012 7:41 PM, Ben Hutchings wrote:
[...]
Quoted 10 lines
Quoted 10 lines
Quoted 3 lines
Are there any versions of the cxgb4 driver that will specifically request cxgb4/t4fw-1.3.10.0.bin? If not, what's the point of keeping it around after changing the cxgb4/t4fw.bin symlink?
Hi Ben,
I originally removed cxgb4/t4fw-1.3.10.0.bin when I posted the request against David's tree.
Subsequent review from Neil requested to keep it around at least for a while (https://lkml.org/lkml/2012/2/11/61).
Either way is fine to me.
Quoted 4 lines
Quoted 2 lines
No, Neil said you need to maintain cxgb4/t4fw.bin, but it's perfectly fine for that to be a symlink.
So I've pulled your changes and then deleted the cxgb4/t4fw-1.3.10.0.bin as a separate commit.
Than you.
Cheers,
Divy