Skip to contentSkip to conversation

mfd: tps65912: Initialize irq platform data properly

PATCH In review Axel Lin 3 participants 3 messages Feb 19, 2012 – Feb 23, 2012 Multifunction devices (MFD)

lore
Share & tools
lore

Axel Lin

author
#0 lore raw

PATCH 1/1 mfd: tps65912: Initialize irq platform data properly

irq_base of the tps65912 irq platform data should be initialized with the board provided irq_base data.

Signed-off-by Axel Lin <[email protected]>
---
 drivers/mfd/tps65912-core.c |    2 +-
 1 files changed, 1 insertions(+), 1 deletions(-)
drivers/mfd/tps65912-core.c +1 -1
index 5fec23a..74fd8cb 100644
@@ -151,7 +151,7 @@ int tps65912_device_init(struct tps65912 *tps65912)
 		goto err;
 
 	init_data->irq = pmic_plat_data->irq;
-	init_data->irq_base = pmic_plat_data->irq;
+	init_data->irq_base = pmic_plat_data->irq_base;
 	ret = tps65912_irq_init(tps65912, init_data->irq, init_data);
 	if (ret < 0)
 		goto err;
Signature · 1 line
1.7.5.4
#1 lore raw
Quoted 3 lines · Axel Lin

irq_base of the tps65912 irq platform data should be initialized with the board provided irq_base data.

The description only tells what you did, but why?

Quoted 30 lines
Signed-off-by Axel Lin <[email protected]>

---
 drivers/mfd/tps65912-core.c |    2 +-

 1 files changed, 1 insertions(+), 1 deletions(-)
drivers/mfd/tps65912-core.c +1 -2
index 5fec23a..74fd8cb 100644
@@ -151,7 +151,7 @@ int tps65912_device_init(struct tps65912 *tps65912)
                goto err;
 
        init_data->irq = pmic_plat_data->irq;
-       init_data->irq_base = pmic_plat_data->irq;
+       init_data->irq_base = pmic_plat_data->irq_base;
        ret = tps65912_irq_init(tps65912, init_data->irq, init_data);
        if (ret < 0)
                goto err;
--

1.7.5.4

--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in the body of a message to [email protected]
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/

#2 lore raw
In reply to Axel Lin

Hi Axel,

Quoted 2 lines · Axel Lin

irq_base of the tps65912 irq platform data should be initialized with the board provided irq_base data.

Thanks, patch applied to my for-next and for-linus branches.

Cheers,
Samuel.

Signature · 2 lines
Intel Open Source Technology Centre
http://oss.intel.com/