Skip to contentSkip to conversation

useradd: Add missing DEPEND on shadow

PATCH Richard Purdie 3 participants 5 messages Nov 10, 2011 – Feb 19, 2012

lore
Share & tools
lore
#0 lore raw

Without this rootfs generation fails as an RDEPENDS is added but the package might not have bneen built.

---

meta/classes/useradd.bbclass +1 -1
index 8cd7f4f..7faf1a7 100644
@@ -2,7 +2,7 @@
 # target sysroot, and shadow -native and -sysroot provide the utilities
 # and support files needed to add and modify user and group accounts
 DEPENDS_append = "${USERADDDEPENDS}"
-USERADDDEPENDS = " base-passwd shadow-native shadow-sysroot"
+USERADDDEPENDS = " base-passwd shadow-native shadow-sysroot shadow"
 USERADDDEPENDS_virtclass-nativesdk = ""
 
 # This preinstall function will be run in two contexts: once for the
#1 lore raw
Quoted 13 lines · Richard Purdie

Without this rootfs generation fails as an RDEPENDS is added but the package might not have bneen built.

---

meta/classes/useradd.bbclass +0 -0
index 8cd7f4f..7faf1a7 100644
@@ -2,7 +2,7 @@
  # target sysroot, and shadow -native and -sysroot provide the utilities
  # and support files needed to add and modify user and group accounts

 DEPENDS_append = "${USERADDDEPENDS}"

meta/classes/useradd.bbclass line 5

Quoted 2 lines
meta/classes/useradd.bbclass +1 -1
-USERADDDEPENDS = " base-passwd shadow-native shadow-sysroot"
+USERADDDEPENDS = " base-passwd shadow-native shadow-sysroot shadow"

The shadow recipe is a 'PACKAGE_ARCH = "${MACHINE_ARCH}"' recipe. This makes all recipes that inherit useradd depend on shadow which will depend on the MACHINE being built for. Ideally, we just need a way to ensure these packages are deployed - we don't want them to effect signatures.

Can you suggest a better fix here? Some bb.exec_func("shadow:do_populate_sysroot") or something equivalent?

-M

#2 lore raw

Am Sonntag, den 19.02.2012, 07:29 +0000 schrieb McClintock Matthew-B29882:

Quoted 3 lines · Richard Purdie
Quoted 2 lines

Without this rootfs generation fails as an RDEPENDS is added but the package might not have bneen built.

s/bneen/been/

Quoted 19 lines

meta/classes/useradd.bbclass line 5

Quoted 12 lines

---

meta/classes/useradd.bbclass +1 -1
index 8cd7f4f..7faf1a7 100644
@@ -2,7 +2,7 @@
 # target sysroot, and shadow -native and -sysroot provide the utilities
 # and support files needed to add and modify user and group accounts
 DEPENDS_append = "${USERADDDEPENDS}"
-USERADDDEPENDS = " base-passwd shadow-native shadow-sysroot"
+USERADDDEPENDS = " base-passwd shadow-native shadow-sysroot shadow"

The shadow recipe is a 'PACKAGE_ARCH = "${MACHINE_ARCH}"' recipe. This makes all recipes that inherit useradd depend on shadow which will depend on the MACHINE being built for. Ideally, we just need a way to ensure these packages are deployed - we don't want them to effect signatures.

Quoted 2 lines

Can you suggest a better fix here? Some bb.exec_func("shadow:do_populate_sysroot") or something equivalent?

You raise a good point, but I have no solution.

Thanks,

Paul

#3 lore raw
In reply to McClintock Matthew-B29882
Quoted 24 lines · On Sun, 2012-02-19 at 07:29 +0000, McClintock Matthew-B29882 wrote:
Quoted 10 lines · Richard Purdie

Without this rootfs generation fails as an RDEPENDS is added but the package might not have bneen built.

---

meta/classes/useradd.bbclass +0 -0
index 8cd7f4f..7faf1a7 100644

meta/classes/useradd.bbclass line 5

Quoted 5 lines
meta/classes/useradd.bbclass +1 -1
@@ -2,7 +2,7 @@
 # target sysroot, and shadow -native and -sysroot provide the utilities
 # and support files needed to add and modify user and group accounts
 DEPENDS_append = "${USERADDDEPENDS}"
-USERADDDEPENDS = " base-passwd shadow-native shadow-sysroot"
+USERADDDEPENDS = " base-passwd shadow-native shadow-sysroot shadow"

The shadow recipe is a 'PACKAGE_ARCH = "${MACHINE_ARCH}"' recipe. This makes all recipes that inherit useradd depend on shadow which will depend on the MACHINE being built for. Ideally, we just need a way to ensure these packages are deployed - we don't want them to effect signatures.

Quoted 2 lines

Can you suggest a better fix here? Some bb.exec_func("shadow:do_populate_sysroot") or something equivalent?

This was already fixed:

http://git.yoctoproject.org/cgit/cgit.cgi/poky/commit/?id=7c8899662be5623bedaa9a848fafebeafb348cf0

and the new machine specific subpackage is excluded from sstate's signatures.

Cheers,

Richard

#4 lore raw
Quoted 28 lines · Richard Purdie
Quoted 24 lines · On Sun, 2012-02-19 at 07:29 +0000, McClintock Matthew-B29882 wrote:
Quoted 13 lines · Richard Purdie

Without this rootfs generation fails as an RDEPENDS is added but the package might not have bneen built.

---

meta/classes/useradd.bbclass +0 -0
index 8cd7f4f..7faf1a7 100644
@@ -2,7 +2,7 @@
  # target sysroot, and shadow -native and -sysroot provide the utilities
  # and support files needed to add and modify user and group accounts

 DEPENDS_append = "${USERADDDEPENDS}"

meta/classes/useradd.bbclass line 5

Quoted 2 lines
meta/classes/useradd.bbclass +1 -1
-USERADDDEPENDS = " base-passwd shadow-native shadow-sysroot"
+USERADDDEPENDS = " base-passwd shadow-native shadow-sysroot shadow"

The shadow recipe is a 'PACKAGE_ARCH = "${MACHINE_ARCH}"' recipe. This makes all recipes that inherit useradd depend on shadow which will depend on the MACHINE being built for. Ideally, we just need a way to ensure these packages are deployed - we don't want them to effect signatures.

Quoted 2 lines

Can you suggest a better fix here? Some bb.exec_func("shadow:do_populate_sysroot") or something equivalent?

Quoted 6 lines

This was already fixed:

http://git.yoctoproject.org/cgit/cgit.cgi/poky/commit/?id=7c8899662be5623bedaa9a848fafebeafb348cf0

and the new machine specific subpackage is excluded from sstate's signatures.

Ah missed this - thanks.

-M