ARM: ptrace: Fix audit caused compile error

PATCH New Peter Ujfalusi 4 participants 5 messages Feb 21, 2012

Subsystems (3)

Arm (32-bit) Linux-next tree ptrace support

lore

Share & tools

lore

Peter Ujfalusi

author

2012-02-21 12:04 UTC #0 lore raw

PATCH 1/1 ARM: ptrace: Fix audit caused compile error

While trying to compile the kernel for ARM (omap2plus_defconfig) the kernel build fails with:

arch/arm/kernel/ptrace.c: In function ?syscall_trace?:
arch/arm/kernel/ptrace.c:920:3: error: implicit declaration of function ?audit_syscall_exit? arch/arm/kernel/ptrace.c:922:3: error: implicit declaration of function ?audit_syscall_entry? arch/arm/kernel/ptrace.c:922:23: error: ?AUDIT_ARCH_ARMEB? undeclared (first use in this function) arch/arm/kernel/ptrace.c:922:23: note: each undeclared identifier is reported only once for each function it appears in make[1]: *** [arch/arm/kernel/ptrace.o] Error 1

The issue created by commit:
29ef73b7 Kernel: Audit Support For The ARM Platform

We need to include the linux/audit.h header to the arch/arm/kernel/ptrace.c file to be able to compile the kernel.

Signed-off-by Peter Ujfalusi <[email protected]>

---
 arch/arm/kernel/ptrace.c |    1 +
 1 files changed, 1 insertions(+), 0 deletions(-)

arch/arm/kernel/ptrace.c +1 -0

index e33870f..8e41ad2 100644
@@ -15,6 +15,7 @@
 #include <linux/elf.h>
 #include <linux/smp.h>
 #include <linux/ptrace.h>
+#include <linux/audit.h>
 #include <linux/user.h>
 #include <linux/security.h>
 #include <linux/init.h>

Signature · 1 line

1.7.8.4

Will Deacon

2012-02-21 13:16 UTC #1 lore raw

PATCH 1/1 ARM: ptrace: Fix audit caused compile error

Quoted 10 lines · Peter Ujfalusi

While trying to compile the kernel for ARM (omap2plus_defconfig) the kernel build fails with:
arch/arm/kernel/ptrace.c: In function ?syscall_trace?:
arch/arm/kernel/ptrace.c:920:3: error: implicit declaration of function ?audit_syscall_exit? arch/arm/kernel/ptrace.c:922:3: error: implicit declaration of function ?audit_syscall_entry? arch/arm/kernel/ptrace.c:922:23: error: ?AUDIT_ARCH_ARMEB? undeclared (first use in this function) arch/arm/kernel/ptrace.c:922:23: note: each undeclared identifier is reported only once for each function it appears in make[1]: *** [arch/arm/kernel/ptrace.o] Error 1

Quoted 5 lines

The issue created by commit:
29ef73b7 Kernel: Audit Support For The ARM Platform
We need to include the linux/audit.h header to the arch/arm/kernel/ptrace.c file to be able to compile the kernel.

This was already reported and I think Russell was going to revert the offending commit, since it needed some rework to handle little-endian configurations.

I can't see the revert in any of the trees I'm tracking though...

Will

Russell King - ARM Linux

2012-02-21 13:30 UTC #2 lore raw

PATCH 1/1 ARM: ptrace: Fix audit caused compile error

Quoted 14 lines · Will Deacon

Quoted 13 lines · Peter Ujfalusi
While trying to compile the kernel for ARM (omap2plus_defconfig) the kernel build fails with:
arch/arm/kernel/ptrace.c: In function ?syscall_trace?:
arch/arm/kernel/ptrace.c:920:3: error: implicit declaration of function ?audit_syscall_exit? arch/arm/kernel/ptrace.c:922:3: error: implicit declaration of function ?audit_syscall_entry? arch/arm/kernel/ptrace.c:922:23: error: ?AUDIT_ARCH_ARMEB? undeclared (first use in this function) arch/arm/kernel/ptrace.c:922:23: note: each undeclared identifier is reported only once for each function it appears in make[1]: *** [arch/arm/kernel/ptrace.o] Error 1
The issue created by commit:
29ef73b7 Kernel: Audit Support For The ARM Platform

Quoted 8 lines

Quoted 2 lines
We need to include the linux/audit.h header to the arch/arm/kernel/ptrace.c file to be able to compile the kernel.
This was already reported and I think Russell was going to revert the offending commit, since it needed some rework to handle little-endian configurations.
I can't see the revert in any of the trees I'm tracking though...

I never pushed that out because I thought someone was going to fix it. Were any patches produced to fix it? I can't see anything in the patch system and I couldn't see anything on the list.

It seems the previous thread about it just died. Oh well, I guess a revert is what's required after all.

Eric Paris

2012-02-21 13:35 UTC #3 lore raw

PATCH 1/1 ARM: ptrace: Fix audit caused compile error

Quoted 22 lines · Russell King - ARM Linux

Quoted 21 lines · Will Deacon
Quoted 10 lines · Peter Ujfalusi
While trying to compile the kernel for ARM (omap2plus_defconfig) the kernel build fails with:
arch/arm/kernel/ptrace.c: In function ?syscall_trace?:
arch/arm/kernel/ptrace.c:920:3: error: implicit declaration of function ?audit_syscall_exit? arch/arm/kernel/ptrace.c:922:3: error: implicit declaration of function ?audit_syscall_entry? arch/arm/kernel/ptrace.c:922:23: error: ?AUDIT_ARCH_ARMEB? undeclared (first use in this function) arch/arm/kernel/ptrace.c:922:23: note: each undeclared identifier is reported only once for each function it appears in make[1]: *** [arch/arm/kernel/ptrace.o] Error 1
Quoted 5 lines
The issue created by commit:
29ef73b7 Kernel: Audit Support For The ARM Platform
We need to include the linux/audit.h header to the arch/arm/kernel/ptrace.c file to be able to compile the kernel.
This was already reported and I think Russell was going to revert the offending commit, since it needed some rework to handle little-endian configurations.

Quoted 8 lines

Quoted 1 line
I can't see the revert in any of the trees I'm tracking though...
I never pushed that out because I thought someone was going to fix it. Were any patches produced to fix it? I can't see anything in the patch system and I couldn't see anything on the list.
It seems the previous thread about it just died. Oh well, I guess a revert is what's required after all.

http://marc.info/?l=linux-arm-kernel&m=132928424120369&w=2

???

Eric Paris

2012-02-21 13:49 UTC #4 lore raw

PATCH 1/1 ARM: ptrace: Fix audit caused compile error

Quoted 29 lines · Eric Paris

Quoted 28 lines · Russell King - ARM Linux
Quoted 14 lines · Will Deacon
Quoted 13 lines · Peter Ujfalusi
While trying to compile the kernel for ARM (omap2plus_defconfig) the kernel build fails with:
arch/arm/kernel/ptrace.c: In function ?syscall_trace?:
arch/arm/kernel/ptrace.c:920:3: error: implicit declaration of function ?audit_syscall_exit? arch/arm/kernel/ptrace.c:922:3: error: implicit declaration of function ?audit_syscall_entry? arch/arm/kernel/ptrace.c:922:23: error: ?AUDIT_ARCH_ARMEB? undeclared (first use in this function) arch/arm/kernel/ptrace.c:922:23: note: each undeclared identifier is reported only once for each function it appears in make[1]: *** [arch/arm/kernel/ptrace.o] Error 1
The issue created by commit:
29ef73b7 Kernel: Audit Support For The ARM Platform
Quoted 8 lines
Quoted 2 lines
We need to include the linux/audit.h header to the arch/arm/kernel/ptrace.c file to be able to compile the kernel.
This was already reported and I think Russell was going to revert the offending commit, since it needed some rework to handle little-endian configurations.
I can't see the revert in any of the trees I'm tracking though...
I never pushed that out because I thought someone was going to fix it. Were any patches produced to fix it? I can't see anything in the patch system and I couldn't see anything on the list.

Quoted 6 lines

Quoted 2 lines
It seems the previous thread about it just died. Oh well, I guess a revert is what's required after all.
http://marc.info/?l=linux-arm-kernel&m=132928424120369&w=2
???

You probably meant the arch endian bug. I wrote a patch for it, but guess i never sent it. It was just sitting on my audit arm branch. So I just sent that one as well.

Thanks Russell!
-Eric