Skip to contentSkip to conversation

checkpatch.pl: be silent when -q and --ignore is given

PATCH Superseded Artem Bityutskiy 1 participant 1 message Feb 22, 2012 Checkpatch

lore
Share & tools
lore
#0 lore raw

PATCH 1/1 checkpatch.pl: be silent when -q and --ignore is given

From: Artem Bityutskiy <[email protected]>

This patch fixes checkpatch.pl when both -q and --ignore are given and prevents it from printing a

NOTE: Ignored message types: blah

messages.

E.g., if I use -q --ignore PREFER_PACKED,PREFER_ALIGNED, i see:

NOTE: Ignored message types: PREFER_ALIGNED PREFER_PACKED

It makes no sense to print this when -q is given.

---
 scripts/checkpatch.pl |    5 ++---
 1 files changed, 2 insertions(+), 3 deletions(-)
scripts/checkpatch.pl +2 -3
index a3b9782..6fad217 100755
@@ -3394,13 +3394,12 @@ sub process {
 		}
 	}
 
-	if (keys %ignore_type) {
+	if ($quiet == 0 && keys %ignore_type) {
 	    print "NOTE: Ignored message types:";
 	    foreach my $ignore (sort keys %ignore_type) {
 		print " $ignore";
 	    }
-	    print "\n";
-	    print "\n" if ($quiet == 0);
+	    print "\n\n";
 	}
 
 	if ($clean == 1 && $quiet == 0) {
Signature · 1 line
1.7.9