Skip to contentSkip to conversation

drm/i915: print the unrecognised pixel format value.

PATCH In review Dave Airlie 3 participants 4 messages Feb 23, 2012

Subsystems (2)
lore
Share & tools
lore

Dave Airlie

author maintainer
#0 lore raw

PATCH 1/2 drm/i915: print the unrecognised pixel format value.

From: Dave Airlie <[email protected]>

Another contentless error bites the dust.

---
 drivers/gpu/drm/i915/intel_display.c |    2 +-
 1 files changed, 1 insertions(+), 1 deletions(-)
drivers/gpu/drm/i915/intel_display.c +1 -1
index f425b23..1efb5fc 100644
@@ -7830,7 +7830,7 @@ int intel_framebuffer_init(struct drm_device *dev,
 	case DRM_FORMAT_VYUY:
 		break;
 	default:
-		DRM_ERROR("unsupported pixel format\n");
+		DRM_ERROR("unsupported pixel format %x\n", mode_cmd->pixel_format);
 		return -EINVAL;
 	}
 
Signature · 1 line
1.7.7.6
author maintainer
#1 lore raw

PATCH 2/2 drm/i915: fix mode set on load pipe.

From: Dave Airlie <[email protected]>

Booted my i965 machine and it started printing the unsupported pixel format of 0 message (once I added content to it).

Oh looksie here, we pass 0. fix.

---
 drivers/gpu/drm/i915/intel_display.c |    2 +-
 1 files changed, 1 insertions(+), 1 deletions(-)
drivers/gpu/drm/i915/intel_display.c +1 -1
index 1efb5fc..c03bad7 100644
@@ -6561,7 +6561,7 @@ intel_framebuffer_create_for_mode(struct drm_device *dev,
 	mode_cmd.height = mode->vdisplay;
 	mode_cmd.pitches[0] = intel_framebuffer_pitch_for_width(mode_cmd.width,
 								bpp);
-	mode_cmd.pixel_format = 0;
+	mode_cmd.pixel_format = drm_fb_legacy_fb_format(bpp, depth);
 
 	return intel_framebuffer_create(dev, &mode_cmd, obj);
 }
Signature · 1 line
1.7.7.6
#2 lore raw
In reply to Dave Airlie
Quoted 5 lines · Dave Airlie

From: Dave Airlie <[email protected]>

Another contentless error bites the dust.

Almost identical patch is already merged into -next:

commit aca258482ed7c600b5aeed03aa8727d94d8dd07e

Author: Eugeni Dodonov <[email protected]>
Date:   Tue Jan 17 15:25:45 2012 -0200

drm/i915: print out which pixel format we do not support

Quoted 24 lines
---
 drivers/gpu/drm/i915/intel_display.c |    2 +-
 1 files changed, 1 insertions(+), 1 deletions(-)
drivers/gpu/drm/i915/intel_display.c +1 -1
index f425b23..1efb5fc 100644
@@ -7830,7 +7830,7 @@ int intel_framebuffer_init(struct drm_device *dev,
 	case DRM_FORMAT_VYUY:
 		break;
 	default:
-		DRM_ERROR("unsupported pixel format\n");
+		DRM_ERROR("unsupported pixel format %x\n", mode_cmd->pixel_format);
 		return -EINVAL;
 	}
 
Signature · 6 lines
1.7.7.6

_______________________________________________
Intel-gfx mailing list
[email protected]
http://lists.freedesktop.org/mailman/listinfo/intel-gfx
Signature · 3 lines
Daniel Vetter
Mail: [email protected]
Mobile: +41 (0)79 365 57 48