Skip to contentSkip to conversation

drm/i915: fix mode set on load pipe. (v2)

PATCH Applied Dave Airlie 5 participants 5 messages Feb 23, 2012

Subsystems (2)
DRM drivers Intel i915
lore
Share & tools
lore

Dave Airlie

author maintainer
#0 lore raw

PATCH 1/1 drm/i915: fix mode set on load pipe. (v2)

From: Dave Airlie <[email protected]>

Booted my i965 machine and it started printing the unsupported pixel format of 0 message (once I added content to it).

Oh looksie here, we pass 0. fix.

v2: compile it.

Signed-off-by Dave Airlie <[email protected]>
---
 drivers/gpu/drm/i915/intel_display.c |    2 +-
 1 files changed, 1 insertions(+), 1 deletions(-)
drivers/gpu/drm/i915/intel_display.c +1 -1
index 1efb5fc..c255ff7 100644
@@ -6561,7 +6561,7 @@ intel_framebuffer_create_for_mode(struct drm_device *dev,
 	mode_cmd.height = mode->vdisplay;
 	mode_cmd.pitches[0] = intel_framebuffer_pitch_for_width(mode_cmd.width,
 								bpp);
-	mode_cmd.pixel_format = 0;
+	mode_cmd.pixel_format = drm_mode_legacy_fb_format(bpp, depth);
 
 	return intel_framebuffer_create(dev, &mode_cmd, obj);
 }
Signature · 1 line
1.7.7.6
#1 lore raw
Quoted 7 lines · Dave Airlie

From: Dave Airlie <[email protected]>

Booted my i965 machine and it started printing the unsupported pixel format of 0 message (once I added content to it).

Oh looksie here, we pass 0. fix.

We already have patch1 in drm-intel-fixes I think.

And as for Patch2, I guess it should fix
https://bugs.freedesktop.org/show_bug.cgi?id=46043.

Signature · 2 lines
Eugeni Dodonov
<http://eugeni.dodonov.net/>

_______________________________________________
Intel-gfx mailing list
[email protected]
http://lists.freedesktop.org/mailman/listinfo/intel-gfx

#2 lore raw
Quoted 7 lines · Eugeni Dodonov
Quoted 5 lines · Dave Airlie

From: Dave Airlie <[email protected]>

Booted my i965 machine and it started printing the unsupported pixel format of 0 message (once I added content to it).

Quoted 7 lines
Quoted 2 lines

Oh looksie here, we pass 0. fix.

We already have patch1 in drm-intel-fixes I think.

And as for Patch2, I guess it should fix
https://bugs.freedesktop.org/show_bug.cgi?id=46043.

You're missing the real bug reported agains a i965gm here:

https://bugs.freedesktop.org/show_bug.cgi?id=45966

Patch itself is Reviewed-by: Daniel Vetter <[email protected]>

-Daniel

Signature · 3 lines
Daniel Vetter
Mail: [email protected]
Mobile: +41 (0)79 365 57 48
Reviewed-by on v1 1/1
#3 lore raw
In reply to Dave Airlie
Quoted 10 lines · Dave Airlie

From: Dave Airlie <[email protected]>

Booted my i965 machine and it started printing the unsupported pixel format of 0 message (once I added content to it).

Oh looksie here, we pass 0. fix.

v2: compile it.

Signed-off-by Dave Airlie <[email protected]>

Bugzilla: https://bugs.freedesktop.org/show_bug.cgi?id=45966

Reviewed-by Chris Wilson <[email protected]>

-Chris

Signature · 1 line
Chris Wilson, Intel Open Source Technology Centre
Applied
#4 lore raw
Quoted 6 lines · On Thu, 23 Feb 2012 15:56:52 +0000 Chris Wilson <[email protected]>…
Quoted 5 lines · Dave Airlie

From: Dave Airlie <[email protected]>

Booted my i965 machine and it started printing the unsupported pixel format of 0 message (once I added content to it).

Quoted 7 lines
Quoted 5 lines

Oh looksie here, we pass 0. fix.

v2: compile it.

Signed-off-by Dave Airlie <[email protected]>

Bugzilla: https://bugs.freedesktop.org/show_bug.cgi?id=45966

Reviewed-by Chris Wilson <[email protected]>

Pushed to drm-intel-fixes, thanks. We actually caught this bug last week, but I never merged the fix...

Signature · 1 line
Jesse Barnes, Intel Open Source Technology Center

_______________________________________________
Intel-gfx mailing list
[email protected]
http://lists.freedesktop.org/mailman/listinfo/intel-gfx