Skip to contentSkip to conversation

regulator: Set delay to 0 if set_voltage_time_sel callback returns error

PATCH Superseded Axel Lin 1 participant 1 message Feb 24, 2012 Voltage and current regulator framework

v2 of 3 Superseded Latest is v3 →

lore
Share & tools
lore

Axel Lin

author
#0 lore raw

PATCH v2 1/1 regulator: Set delay to 0 if set_voltage_time_sel callback returns error

rdev->desc->ops->set_voltage_time_sel may return negative error code. Set delay to 0 and also show warning if set_voltage_time_sel returns error.

Signed-off-by Axel Lin <[email protected]>

---
v2: show warning message if set_voltage_time_sel returns error.

 drivers/regulator/core.c |    4 ++++
 1 files changed, 4 insertions(+), 0 deletions(-)
drivers/regulator/core.c +4 -0
index beeeb7f..19a4778 100644
@@ -1892,6 +1892,10 @@ static int _regulator_do_set_voltage(struct regulator_dev *rdev,
 			old_selector = ret;
 			delay = rdev->desc->ops->set_voltage_time_sel(rdev,
 						old_selector, selector);
+			if (delay < 0) {
+				rdev_warn(rdev, "set_voltage_time_sel() failed: %d\n", delay);
+				delay = 0;
+			}
 		}
 
 		if (best_val != INT_MAX) {
Signature · 1 line
1.7.5.4