Skip to contentSkip to conversation

bitbake/runqueue: Ensure finish_now() sets the runqueue state consistently

PATCH In review Richard Purdie 2 participants 2 messages Feb 25, 2012 – Feb 26, 2012

lore
Share & tools
lore

Richard Purdie

author
#0 lore raw

PATCH 1/1 bitbake/runqueue: Ensure finish_now() sets the runqueue state consistently

If we call finish_now(True), rq.state is not updated to match. This makes the behaviour of finish_now(False) and finish_now(True) consistent so both leave rq.state consistently.

Signed-off-by Richard Purdie <[email protected]>
bitbake/lib/bb/runqueue.py +7 -0
index c24841f..26a0f85 100644
@@ -1060,6 +1060,13 @@ class RunQueueExecute:
         for pipe in self.build_pipes:
             self.build_pipes[pipe].read()
 
+        if len(self.failed_fnids) != 0:
+            self.rq.state = runQueueFailed
+            return
+
+        self.rq.state = runQueueComplete
+        return
+
     def finish(self):
         self.rq.state = runQueueCleanUp
#1 lore raw

Hi Richard:

I have included this patch to the "V5 Disk space monitoring" as you suggested, I have tested it, it worked well.

// Robert

Quoted 32 lines · Richard Purdie

If we call finish_now(True), rq.state is not updated to match. This makes the behaviour of finish_now(False) and finish_now(True) consistent so both leave rq.state consistently.

Signed-off-by Richard Purdie<[email protected]>
bitbake/lib/bb/runqueue.py +7 -0
index c24841f..26a0f85 100644
@@ -1060,6 +1060,13 @@ class RunQueueExecute:
          for pipe in self.build_pipes:
              self.build_pipes[pipe].read()
 
+        if len(self.failed_fnids) != 0:
+            self.rq.state = runQueueFailed
+            return
+
+        self.rq.state = runQueueComplete
+        return
+
      def finish(self):
          self.rq.state = runQueueCleanUp

_______________________________________________
bitbake-devel mailing list
[email protected]
http://lists.linuxtogo.org/cgi-bin/mailman/listinfo/bitbake-devel