drm/i915: Handle request to map a very large buffer object
PATCH 1/1 drm/i915: Handle request to map a very large buffer object
This patch sets an upper limit on the size of buffer object which can be mapped safely. Following bugs reported segmentation fault / assertion failure with large textures:
https://bugs.freedesktop.org/show_bug.cgi?id=44970
https://bugs.freedesktop.org/show_bug.cgi?id=46303
This patch along with another patch which I posted on mesa-dev (intel: Fix a case when mapping large texture fails) resolve above mentioned bugs. Recently posted piglit test case (large-textures) also passes with these patches.
---
This fix doesn't limit developers to create very large texture but it restricts them to map it. I am not very confident about this patch and setting 128 MB as the upper limit on size of buffer object. So, please provide your views.
Chris Wilson's views on this issue:
http://www.mail-archive.com/[email protected]/msg08585.html
intel/intel_bufmgr_gem.c | 11 +++++++++++ 1 files changed, 11 insertions(+), 0 deletions(-)
intel/intel_bufmgr_gem.c +11 -0
@@ -1191,6 +1191,17 @@ int drm_intel_gem_bo_map_gtt(drm_intel_bo *bo)pthread_mutex_lock (&bufmgr_gem->lock); +/* Set am upper limit on the size of buffer which can be mapped +safely +*/ +if (bo->size >128 *1024 *1024 ) { +DBG ("%s:%d: Reached buffer map limit.\n" , + __FILE__, __LINE__); + bo->virtual =NULL ; +pthread_mutex_unlock (&bufmgr_gem->lock); +return -1 ; + } +if (bo_gem->map_count++ ==0 )drm_intel_gem_bo_open_vma (bufmgr_gem, bo_gem);
Signature · 1 line
1.7.7.6
Dear Anuj,
thank you for your patch with the great explanation in the commit message. I found one typo in the code comment and while at it point out some grammar issue in the commit message.
Am Montag, den 27.02.2012, 12:28 -0800 schrieb Anuj Phogat:
Quoted 2 lines
This patch sets an upper limit on the size of buffer object which can be mapped safely. Following bugs reported segmentation fault / assertion
reported *a* segmentation fault / *an* assertion …
Quoted 7 lines
failure with large textures:
https://bugs.freedesktop.org/show_bug.cgi?id=44970
https://bugs.freedesktop.org/show_bug.cgi?id=46303This patch along with another patch which I posted on mesa-dev (intel: Fix a case when mapping large texture fails) [1] resolve
You could add the URL.
Quoted 1 line
above mentioned bugs. Recently posted piglit test case (large-textures)
*The* recently …
Quoted 1 line
also passes with these patches.
[1] http://lists.freedesktop.org/archives/mesa-dev/2012-February/019488.html
Quoted 18 lines
Signed-off-by Anuj Phogat <[email protected]>---
This fix doesn't limit developers to create very large texture but it restricts them to map it. I am not very confident about this patch and setting 128 MB as the upper limit on size of buffer object. So, please provide your views.Chris Wilson's views on this issue:
http://www.mail-archive.com/[email protected]/msg08585.htmlintel/intel_bufmgr_gem.c | 11 +++++++++++ 1 files changed, 11 insertions(+), 0 deletions(-)intel/intel_bufmgr_gem.c +0
-0
intel/intel_bufmgr_gem.c int drm_intel_gem_bo_map_gtt(drm_intel_bo *bo) · line 1195
Quoted 5 lines
intel/intel_bufmgr_gem.c +2
-0@@ -1191,6 +1191,17 @@ int drm_intel_gem_bo_map_gtt(drm_intel_bo *bo)pthread_mutex_lock (&bufmgr_gem->lock); +/* Set am upper limit on the size of buffer which can be mapped +safely
s/am/an/
Maybe add full stop ».« at the end of the sentence.
intel/intel_bufmgr_gem.c int drm_intel_gem_bo_map_gtt(drm_intel_bo *bo) · line 1197
Quoted 2 lines
intel/intel_bufmgr_gem.c +2
-0+*/ +if (bo->size >128 *1024 *1024 ) {
It seems strange for me that the upper buffer size is always the same and not dependent on the chipset(?). But I guess you have checked that.
intel/intel_bufmgr_gem.c int drm_intel_gem_bo_map_gtt(drm_intel_bo *bo) · line 1206
Quoted 9 lines
intel/intel_bufmgr_gem.c +7
-0+DBG ("%s:%d: Reached buffer map limit.\n" , + __FILE__, __LINE__); + bo->virtual =NULL ; +pthread_mutex_unlock (&bufmgr_gem->lock); +return -1 ; + } +if (bo_gem->map_count++ ==0 )drm_intel_gem_bo_open_vma (bufmgr_gem, bo_gem);
Thanks,
Paul
_______________________________________________
Intel-gfx mailing list
[email protected]
http://lists.freedesktop.org/mailman/listinfo/intel-gfx