Skip to contentSkip to conversation

checkpatch.pl: be silent when -q and --ignore is given

PATCH RESEND In review Artem Bityutskiy 2 participants 4 messages Feb 27, 2012 – Feb 29, 2012 Checkpatch

lore
Share & tools
lore
#0 lore raw

PATCH RESEND 1/1 checkpatch.pl: be silent when -q and --ignore is given

From: Artem Bityutskiy <[email protected]>

This patch fixes checkpatch.pl when both -q and --ignore are given and prevents it from printing a

NOTE: Ignored message types: blah

messages.

E.g., if I use -q --ignore PREFER_PACKED,PREFER_ALIGNED, i see:

NOTE: Ignored message types: PREFER_ALIGNED PREFER_PACKED

It makes no sense to print this when -q is given.

---
 scripts/checkpatch.pl |    5 ++---
 1 files changed, 2 insertions(+), 3 deletions(-)
scripts/checkpatch.pl +2 -3
index a3b9782..6fad217 100755
@@ -3394,13 +3394,12 @@ sub process {
 		}
 	}
 
-	if (keys %ignore_type) {
+	if ($quiet == 0 && keys %ignore_type) {
 	    print "NOTE: Ignored message types:";
 	    foreach my $ignore (sort keys %ignore_type) {
 		print " $ignore";
 	    }
-	    print "\n";
-	    print "\n" if ($quiet == 0);
+	    print "\n\n";
 	}
 
 	if ($clean == 1 && $quiet == 0) {
Signature · 7 lines
1.7.9

--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to [email protected]
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/
#1 lore raw
Quoted 4 lines · Artem Bityutskiy

From: Artem Bityutskiy <[email protected]>

This patch fixes checkpatch.pl when both -q and --ignore are given and prevents it from printing a

Andrew, am I right that checkpatch.pl patches go in via your tree? Should I check linux-next to find out whether you have merged it or not?

Signature · 2 lines
Best Regards,
Artem Bityutskiy
#2 lore raw
Quoted 7 lines · On Wed, 29 Feb 2012 13:02:06 +0200 Artem Bityutskiy <[email protected]> wrote:
Quoted 4 lines · Artem Bityutskiy

From: Artem Bityutskiy <[email protected]>

This patch fixes checkpatch.pl when both -q and --ignore are given and prevents it from printing a

Andrew, am I right that checkpatch.pl patches go in via your tree?

yup.

Quoted 1 line

Should I check linux-next to find out whether you have merged it or not?

I applied it, but it seems that for some reason the applied-to-mm email didn't get sent out for that one.

#3 lore raw
Quoted 2 lines · Andrew Morton

I applied it, but it seems that for some reason the applied-to-mm email didn't get sent out for that one.

OK, thanks a lot!

Signature · 2 lines
Best Regards,
Artem Bityutskiy