Skip to contentSkip to conversation

pc: make user-triggerable exit conditional to DEBUG_BIOS define

PATCH In review Hervé Poussineau 2 participants 3 messages Feb 29, 2012 – Mar 1, 2012

lore
Share & tools
lore
#0 lore raw

PATCH 1/1 pc: make user-triggerable exit conditional to DEBUG_BIOS define

The port 0x501 is (at least) used by SCO Xenix 2.3.4 installer.

---
 hw/pc.c |    3 +++
 1 files changed, 3 insertions(+), 0 deletions(-)
hw/pc.c +3 -0
index 12c02f2..113a38a 100644
@@ -565,7 +565,10 @@ static void bochs_bios_write(void *opaque, uint32_t addr, uint32_t val)
         /* LGPL'ed VGA BIOS messages */
     case 0x501:
     case 0x502:
+#ifdef DEBUG_BIOS
         exit((val << 1) | 1);
+#endif
+        break;
     case 0x500:
     case 0x503:
 #ifdef DEBUG_BIOS
Signature · 1 line
1.7.9
#1 lore raw
Quoted 1 line · Hervé Poussineau

The port 0x501 is (at least) used by SCO Xenix 2.3.4 installer.

For what? What device would normally be there?

I don't want to disable this by default. My regression suite depends on this as an exit mechanism.

Regards,

Anthony Liguori

Quoted 21 lines
---
  hw/pc.c |    3 +++
  1 files changed, 3 insertions(+), 0 deletions(-)
hw/pc.c +3 -0
index 12c02f2..113a38a 100644
@@ -565,7 +565,10 @@ static void bochs_bios_write(void *opaque, uint32_t addr, uint32_t val)
          /* LGPL'ed VGA BIOS messages */
      case 0x501:
      case 0x502:
+#ifdef DEBUG_BIOS
          exit((val<<  1) | 1);
+#endif
+        break;
      case 0x500:
      case 0x503:
  #ifdef DEBUG_BIOS
#2 lore raw

Hi,

I've no idea what installer is trying to do with this port, or what device it is probing.

We can maybe add a runtime switch to exit Qemu or not. What do you think of '-vgabios-backdoor' which, if specified, does the exit ?

Otherwise, which solution do you propose?

Regards,

Hervé

Quoted 35 lines · Anthony Liguori
Quoted 1 line · Hervé Poussineau

The port 0x501 is (at least) used by SCO Xenix 2.3.4 installer.

For what? What device would normally be there?

I don't want to disable this by default. My regression suite depends on this as an exit mechanism.

Regards,

Anthony Liguori

Quoted 22 lines
---
  hw/pc.c |    3 +++
  1 files changed, 3 insertions(+), 0 deletions(-)
hw/pc.c +3 -0
index 12c02f2..113a38a 100644
@@ -565,7 +565,10 @@ static void bochs_bios_write(void *opaque, 
 uint32_t addr, uint32_t val)
          /* LGPL'ed VGA BIOS messages */
      case 0x501:
      case 0x502:
+#ifdef DEBUG_BIOS
          exit((val<<  1) | 1);
+#endif
+        break;
      case 0x500:
      case 0x503:
  #ifdef DEBUG_BIOS