Skip to contentSkip to conversation

Query about regmap SPI

DISCUSSION Ashish Chavan 2 participants 4 messages Mar 6, 2012 1 message not in the archive

lore
Share & tools
lore

A message that is not in the archive (sent off-list or not yet received): 1331045140.32512.7.camel@matrix

#1 lore raw
Quoted 5 lines · Ashish Chavan

On Tue, Mar 06, 2012 at 12:53:51PM +0500, Ashish Chavan wrote:

Please always CC the relevant mailing lists on postings. I shouldn't need to remind you about this stuff.

Yes, I agree :-(
It's my mistake that I missed [email protected]

Quoted 3 lines

No, implementing stuff like this in individual device drivers rather defeats the point of having frameworks. It sounds like it should be trivial to add support for this to regmap.

I also think that there should be a way to handle this kind of stuff by the framework. May I know if you have any plan to add this to regmap? or should I come up with a patch to extend regmap to support this and propose you?

#2 lore raw
Quoted 4 lines · Ashish Chavan

I also think that there should be a way to handle this kind of stuff by the framework. May I know if you have any plan to add this to regmap? or should I come up with a patch to extend regmap to support this and propose you?

I have no need for it so I'm unlikely to work on it myself, if you were to send a patch that'd be great.

#3 lore raw
Quoted 9 lines · Mark Brown
Quoted 4 lines · Ashish Chavan

I also think that there should be a way to handle this kind of stuff by the framework. May I know if you have any plan to add this to regmap? or should I come up with a patch to extend regmap to support this and propose you?

I have no need for it so I'm unlikely to work on it myself, if you were to send a patch that'd be great.

OK, I will go through regmap sources in detail to find out appropriate place to put this. BTW do you have any recommendation in terms of a good way to achieve this. e.g. will it be useful and generic enough if we introduce two more fields like read/write_flag_mask to indicate shifting and use those fields before applying read/write_flag_masks?

#4 lore raw
Quoted 4 lines · Ashish Chavan

place to put this. BTW do you have any recommendation in terms of a good way to achieve this. e.g. will it be useful and generic enough if we introduce two more fields like read/write_flag_mask to indicate shifting and use those fields before applying read/write_flag_masks?

That sounds like a sensible approach.