Skip to contentSkip to conversation

ASoC: omap-mcbsp: Export functions for threshold configuration

PATCH In review Peter Ujfalusi 3 participants 4 messages Mar 12, 2012

Subsystems (2)
lore
Share & tools
lore
#0 lore raw

PATCH 1/1 ASoC: omap-mcbsp: Export functions for threshold configuration

ABE has certain requirements towards the FIFO configuration in McBSP. Make it posssible to configure the McBSP FIFO threshold from outside of the McBSP driver stack.

---
Hi,

this patch is needed in preparation to add the ABE support for OMAP4+ platforms.

Regards,
Peter

 sound/soc/omap/mcbsp.c |    2 ++
 1 files changed, 2 insertions(+), 0 deletions(-)
sound/soc/omap/mcbsp.c +2 -0
index e5f4444..ca8b028 100644
@@ -402,6 +402,7 @@ void omap_mcbsp_set_tx_threshold(struct omap_mcbsp *mcbsp, u16 threshold)
 	if (threshold && threshold <= mcbsp->max_tx_thres)
 		MCBSP_WRITE(mcbsp, THRSH2, threshold - 1);
 }
+EXPORT_SYMBOL_GPL(omap_mcbsp_set_tx_threshold);
 
 /*
  * omap_mcbsp_set_rx_threshold configures the receive threshold in words.
@@ -416,6 +417,7 @@ void omap_mcbsp_set_rx_threshold(struct omap_mcbsp *mcbsp, u16 threshold)
 	if (threshold && threshold <= mcbsp->max_rx_thres)
 		MCBSP_WRITE(mcbsp, THRSH1, threshold - 1);
 }
+EXPORT_SYMBOL_GPL(omap_mcbsp_set_rx_threshold);
 
 /*
  * omap_mcbsp_get_tx_delay returns the number of used slots in the McBSP FIFO
Signature · 1 line
1.7.8.5
#1 lore raw
Quoted 3 lines · Peter Ujfalusi

ABE has certain requirements towards the FIFO configuration in McBSP. Make it posssible to configure the McBSP FIFO threshold from outside of the McBSP driver stack.

You should always submit things like this along with the changes which use them, it's much easier to see if they're sensible when the users are there. Without seeing how this is used it's hard to tell if this is sensible or if it should be abstracted in some way and we don't want to have half of the bodges sitting around if we end up doing things a different way.

#2 lore raw
Quoted 11 lines · Mark Brown
Quoted 3 lines · Peter Ujfalusi

ABE has certain requirements towards the FIFO configuration in McBSP. Make it posssible to configure the McBSP FIFO threshold from outside of the McBSP driver stack.

You should always submit things like this along with the changes which use them, it's much easier to see if they're sensible when the users are there. Without seeing how this is used it's hard to tell if this is sensible or if it should be abstracted in some way and we don't want to have half of the bodges sitting around if we end up doing things a different way.

I agree, but in this case the ABE series will be huge. We're trying to break this into smaller and more digestible chunks rather than a massive series.

The commit message here should have been more descriptive and described the ABE use case.

Liam

#3 lore raw
Quoted 6 lines · Liam Girdwood

I agree, but in this case the ABE series will be huge. We're trying to break this into smaller and more digestible chunks rather than a massive series.

The commit message here should have been more descriptive and described the ABE use case.

Yeah, or just mix this in with whatever part of the series needs the export (indeed it might make sense to add the export and the user in the same commit). Splitting the series up a bit is good but this is going to the other extreme!