regulator: Fix the logic of tps65910_get_mode

PATCH Applied Axel Lin 3 participants 3 messages Mar 12, 2012 – Mar 13, 2012

Subsystems (2)

OMAP2+ support Voltage and current regulator framework

lore

Share & tools

lore

Axel Lin

author

2012-03-12 23:15 UTC #0 lore raw

PATCH 1/1 regulator: Fix the logic of tps65910_get_mode

We actually clear LDO_ST_ON_BIT for standby mode in tps65910_set_mode. Fix the logic in tps65910_get_mode.

Supply state (EEPROM bits):
ST[1:0] = 00 : Off
ST[1:0] = 01 : On high power (ACTIVE)
ST[1:0] = 10 : Off
ST[1:0] = 11 : On low power (SLEEP)

Signed-off-by Axel Lin <[email protected]>

---
 drivers/regulator/tps65910-regulator.c |    2 +-
 1 files changed, 1 insertions(+), 1 deletions(-)

drivers/regulator/tps65910-regulator.c +1 -1

index 8074d51..33904e7 100644
@@ -520,7 +520,7 @@ static unsigned int tps65910_get_mode(struct regulator_dev *dev)
 	if (value < 0)
 		return value;
 
-	if (value & LDO_ST_ON_BIT)
+	if (!(value & LDO_ST_ON_BIT))
 		return REGULATOR_MODE_STANDBY;
 	else if (value & LDO_ST_MODE_BIT)
 		return REGULATOR_MODE_IDLE;

Signature · 1 line

1.7.5.4

Laxman Dewangan

Acked-by on v1 1/1

2012-03-13 05:32 UTC #1 lore raw

Quoted 11 lines · Axel Lin

We actually clear LDO_ST_ON_BIT for standby mode in tps65910_set_mode. Fix the logic in tps65910_get_mode.
Supply state (EEPROM bits):
ST[1:0] = 00 : Off
ST[1:0] = 01 : On high power (ACTIVE)
ST[1:0] = 10 : Off
ST[1:0] = 11 : On low power (SLEEP)
Signed-off-by Axel Lin<[email protected]>
---

Acked-by Laxman Dewangan <[email protected]>

Mark Brown

Applied

2012-03-13 23:18 UTC #2 lore raw

In reply to Axel Lin

Quoted 2 lines · Axel Lin

We actually clear LDO_ST_ON_BIT for standby mode in tps65910_set_mode. Fix the logic in tps65910_get_mode.

Applied, thanks.