Skip to contentSkip to conversation

package.bbclass: create debugsources.list if it doesn't exist

PATCH In review Robert Yang 2 participants 4 messages Mar 13, 2012 – Mar 14, 2012

lore
Share & tools
lore
#0 lore raw

cover package.bbclass: create debugsources.list if it doesn't exist

The testing information:
# Take MACHINE=qemux86 as example:
1) $ bitbake core-image-sato

2) $ find tmp/work/i586-poky-linux/ -maxdepth 3 -name 'log.do*' -exec \
        grep -H 'debugsources.list: No such file or directory' {} \;

# There should be no output(more than 100 lines without this patch).

// Robert

The following changes since commit f47ada62a3da879006e7cb27479dc9b72c56e923:

  cmake.bbclass: add ${base_libdir} to CMAKE_LIBRARY_PATH (2012-03-12 17:46:16 +0000)

are available in the git repository at:
git://git.pokylinux.org/poky-contrib robert/debugsources
http://git.pokylinux.org/cgit.cgi/poky-contrib/log/?h=robert/debugsources

Robert Yang (1):
package.bbclass: create debugsources.list if it doesn't exist

 meta/classes/package.bbclass |    5 +++++
 1 files changed, 5 insertions(+), 0 deletions(-)
Signature · 1 line
1.7.4.1
#1 lore raw

PATCH 1/1 package.bbclass: create debugsources.list if it doesn't exist

Serval pkg's debug pkg is null, so the find-debuginfo.sh would not generate the ${WORKDIR}/debugsources.list, but the processdebugsrc always need it, there are a few such errors currently:(53 pkgs have such errors in a core-image-sato build):

log.do_package:sort: open failed: debugsources.list: No such file or directory

Create debugsources.list if it doesn't exist would fix this problem.

[YOCTO #2076]

---
 meta/classes/package.bbclass |    5 +++++
 1 files changed, 5 insertions(+), 0 deletions(-)
meta/classes/package.bbclass +5 -0
index 9b6862d..8e76ef8 100644
@@ -243,6 +243,11 @@ def splitfile2(debugsrcdir, d):
     workparentdir = os.path.dirname(workdir)
     workbasedir = os.path.basename(workdir)
     sourcefile = d.expand("${WORKDIR}/debugsources.list")
+    # There is no debugsources.list when the debug pkg is null, but the
+    # processdebugsrc needs it, so create one if it doesn't exist.
+    if not os.path.isfile(sourcefile):
+        f = open(sourcefile, 'w')
+        f.close()
 
     if debugsrcdir:
        nosuchdir = []
Signature · 1 line
1.7.4.1
#2 lore raw
Quoted 8 lines · Robert Yang

Serval pkg's debug pkg is null, so the find-debuginfo.sh would not generate the ${WORKDIR}/debugsources.list, but the processdebugsrc always need it, there are a few such errors currently:(53 pkgs have such errors in a core-image-sato build):

log.do_package:sort: open failed: debugsources.list: No such file or directory

Create debugsources.list if it doesn't exist would fix this problem.

Why can't we modify the code that uses debugsources.list not to get upset if it doesn't exist?

This change seems a little backwards to me...

Cheers,

Richard

Quoted 23 lines

[YOCTO #2076]

---
 meta/classes/package.bbclass |    5 +++++
 1 files changed, 5 insertions(+), 0 deletions(-)
meta/classes/package.bbclass +5 -0
index 9b6862d..8e76ef8 100644
@@ -243,6 +243,11 @@ def splitfile2(debugsrcdir, d):
     workparentdir = os.path.dirname(workdir)
     workbasedir = os.path.basename(workdir)
     sourcefile = d.expand("${WORKDIR}/debugsources.list")
+    # There is no debugsources.list when the debug pkg is null, but the
+    # processdebugsrc needs it, so create one if it doesn't exist.
+    if not os.path.isfile(sourcefile):
+        f = open(sourcefile, 'w')
+        f.close()
 
     if debugsrcdir:
        nosuchdir = []
#3 lore raw
Quoted 6 lines · Richard Purdie
Quoted 5 lines · Robert Yang

Serval pkg's debug pkg is null, so the find-debuginfo.sh would not generate the ${WORKDIR}/debugsources.list, but the processdebugsrc always need it, there are a few such errors currently:(53 pkgs have such errors in a core-image-sato build):

Quoted 7 lines
Quoted 3 lines

log.do_package:sort: open failed: debugsources.list: No such file or directory

Create debugsources.list if it doesn't exist would fix this problem.

Why can't we modify the code that uses debugsources.list not to get upset if it doesn't exist?

Sounds great! I will send an update patch sooner.

Will I reply the updated patch here or should I send a V2, please? I don't know which is popular:-).

// Robert

Quoted 37 lines

This change seems a little backwards to me...

Cheers,

Richard

Quoted 13 lines

[YOCTO #2076]

---
  meta/classes/package.bbclass |    5 +++++
  1 files changed, 5 insertions(+), 0 deletions(-)
meta/classes/package.bbclass +0 -0
index 9b6862d..8e76ef8 100644
@@ -243,6 +243,11 @@ def splitfile2(debugsrcdir, d):
      workparentdir = os.path.dirname(workdir)

meta/classes/package.bbclass def splitfile2(debugsrcdir, d): · line 253

Quoted 10 lines
meta/classes/package.bbclass +5 -0
      workbasedir = os.path.basename(workdir)
      sourcefile = d.expand("${WORKDIR}/debugsources.list")
+    # There is no debugsources.list when the debug pkg is null, but the
+    # processdebugsrc needs it, so create one if it doesn't exist.
+    if not os.path.isfile(sourcefile):
+        f = open(sourcefile, 'w')
+        f.close()
 
      if debugsrcdir:
         nosuchdir = []

_______________________________________________
Openembedded-core mailing list
[email protected]
http://lists.linuxtogo.org/cgi-bin/mailman/listinfo/openembedded-core