Skip to contentSkip to conversation

xf86-video-intel: Add support for toshiba backlight interface

PATCH In review Akio Idehara 2 participants 3 messages Mar 14, 2012 – Mar 15, 2012 x86 platform drivers

lore
Share & tools
lore
#0 lore raw

PATCH 1/1 xf86-video-intel: Add support for toshiba backlight interface

xfce4-power-manager cannot control backlight brightness via toshiba backlight sysfs interface.
The reason is that xf86-video-intel doesn't treat it. This patch adds support for toshiba backlight sysfs interface.

This was tested on a Toshiba Portege R500.

---
 src/intel_display.c   |    1 +
 src/sna/sna_display.c |    1 +
 2 files changed, 2 insertions(+), 0 deletions(-)
src/intel_display.c +1 -0
index 11d0e2b..8eb8df8 100644
@@ -131,6 +131,7 @@ static const char *backlight_interfaces[] = {
 	"fujitsu-laptop",
 	"sony",
 	"samsung",
+	"toshiba",
 	"acpi_video1", /* finally fallback to the generic acpi drivers */
 	"acpi_video0",
 	"intel_backlight",
src/sna/sna_display.c +1 -0
index 9401ca4..10c67f7 100644
@@ -109,6 +109,7 @@ static const char *backlight_interfaces[] = {
 	"fujitsu-laptop",
 	"sony",
 	"samsung",
+	"toshiba",
 	"acpi_video1", /* finally fallback to the generic acpi drivers */
 	"acpi_video0",
 	NULL,
Signature · 1 line
1.7.7.6
#1 lore raw
Quoted 8 lines · Akio Idehara

xfce4-power-manager cannot control backlight brightness via toshiba backlight sysfs interface.
The reason is that xf86-video-intel doesn't treat it. This patch adds support for toshiba backlight sysfs interface.

This was tested on a Toshiba Portege R500.

This isn't a good idea. On many (probably most) Toshibas the platform backlight interface is read-only. I think this patch will break more machines than it fixes.

I have a patch for toshiba_acpi that (among other things) makes it only register the backlight device if it can be written. I've just been sitting on it though because I haven't been able to get anyone with a read/write backlight interface to test it. If you'd be willing to help with testing then I can work on getting that patch into the kernel, then I wouldn't object to your patch.

Seth

#2 lore raw
Quoted 14 lines · Seth Forshee
Quoted 8 lines · Akio Idehara

xfce4-power-manager cannot control backlight brightness via toshiba backlight sysfs interface.
The reason is that xf86-video-intel doesn't treat it. This patch adds support for toshiba backlight sysfs interface.

This was tested on a Toshiba Portege R500.

This isn't a good idea. On many (probably most) Toshibas the platform backlight interface is read-only. I think this patch will break more machines than it fixes.

Quoted 9 lines

I have a patch for toshiba_acpi that (among other things) makes it only register the backlight device if it can be written. I've just been sitting on it though because I haven't been able to get anyone with a read/write backlight interface to test it. If you'd be willing to help with testing then I can work on getting that patch into the kernel, then I wouldn't object to your patch.

Seth

Hi Seth.

Thank you for telling me about this. If I had known it, I'd never send this patch. And I'd be happy to help with testing. So please feel free to send me your patch!

Regards,
Akio