mfd: rc5t583: Improve readability of volatile_reg function
PATCH 1/1 mfd: rc5t583: Improve readability of volatile_reg function
Actually, we have some duplicate entries in current code:RC5T583_GPIO_GPEDGE1, RC5T583_GPIO_GPEDGE2, RC5T583_GPIO_EN_INT are also in the range of ((reg >= RC5T583_GPIO_IOSEL) && (reg <= RC5T583_GPIO_GPOFUNC)).
Let's just list the cases to return false in volatile_reg function. Otherwise, the default is to return true.
Signed-off-by Axel Lin <[email protected]>
--- drivers/mfd/rc5t583.c | 33 +++++++++------------------------ 1 files changed, 9 insertions(+), 24 deletions(-)
drivers/mfd/rc5t583.c +9 -24
@@ -241,32 +241,17 @@ static bool volatile_reg(struct device *dev, unsigned int reg)case RC5T583_INT_EN_ADC1 :case RC5T583_INT_EN_ADC2 :case RC5T583_INT_EN_ADC3 : -case RC5T583_GPIO_GPEDGE1 : -case RC5T583_GPIO_GPEDGE2 : -case RC5T583_GPIO_EN_INT : +/* Enable caching in gpio registers, except RC5T583_GPIO_MON_IOIN which +* is gpio input register */ + case RC5T583_GPIO_IOSEL ... RC5T583_GPIO_EN_INT: +case RC5T583_GPIO_GPOFUNC : +/* Enable caching in sleep seq registers */ + case RC5T583_SLPSEQ1 ... RC5T583_SLPSEQ11: +/* Enable caching of regulator registers */ + case RC5T583_REG_DC0CTL ... RC5T583_REG_SR3CTL: + case RC5T583_REG_LDOEN1 ... RC5T583_REG_LDO9DAC_DS:return false; - -case RC5T583_GPIO_MON_IOIN : -/* This is gpio input register */ -return true; -default : -/* Enable caching in gpio registers */ -if ((reg >=RC5T583_GPIO_IOSEL ) && - (reg <=RC5T583_GPIO_GPOFUNC )) -return false; - -/* Enable caching in sleep seq registers */ -if ((reg >=RC5T583_SLPSEQ1 ) && (reg <=RC5T583_SLPSEQ11 )) -return false; - -/* Enable caching of regulator registers */ -if ((reg >=RC5T583_REG_DC0CTL ) && (reg <=RC5T583_REG_SR3CTL )) -return false; -if ((reg >=RC5T583_REG_LDOEN1 ) && - (reg <=RC5T583_REG_LDO9DAC_DS )) -return false; -break ; }
Signature · 1 line
1.7.5.4