Skip to contentSkip to conversation

staging/vme: Fix module parameters in next-20120323

PATCH In review Gerard Snitselaar 2 participants 2 messages Mar 23, 2012 – Mar 29, 2012 Staging

lore
Share & tools
lore

Gerard Snitselaar

author
#0 lore raw

PATCH 1/1 staging/vme: Fix module parameters in next-20120323

loopback should be declared bool, and variant probably shouldn't be const.

Signed-off-by Gerard Snitselaar <[email protected]>
---
 drivers/staging/vme/devices/vme_pio2_core.c |    4 ++--
 1 files changed, 2 insertions(+), 2 deletions(-)
drivers/staging/vme/devices/vme_pio2_core.c +2 -2
index 9fedc44..573c800 100644
@@ -35,10 +35,10 @@ static int vector[PIO2_CARDS_MAX];
 static int vector_num;
 static int level[PIO2_CARDS_MAX];
 static int level_num;
-static const char *variant[PIO2_CARDS_MAX];
+static char *variant[PIO2_CARDS_MAX];
 static int variant_num;
 
-static int loopback;
+static bool loopback;
 
 static int pio2_match(struct vme_dev *);
 static int __devinit pio2_probe(struct vme_dev *);
Signature · 1 line
1.7.7.6
Acked-by on v1 1/1
#1 lore raw
Quoted 4 lines · Gerard Snitselaar

loopback should be declared bool, and variant probably shouldn't be const.

Signed-off-by Gerard Snitselaar <[email protected]>

Looks good, thanks,

Acked-by Martyn Welch <[email protected]>
Quoted 21 lines
---
 drivers/staging/vme/devices/vme_pio2_core.c |    4 ++--
 1 files changed, 2 insertions(+), 2 deletions(-)
drivers/staging/vme/devices/vme_pio2_core.c +2 -2
index 9fedc44..573c800 100644
@@ -35,10 +35,10 @@ static int vector[PIO2_CARDS_MAX];
 static int vector_num;
 static int level[PIO2_CARDS_MAX];
 static int level_num;
-static const char *variant[PIO2_CARDS_MAX];
+static char *variant[PIO2_CARDS_MAX];
 static int variant_num;
 
-static int loopback;
+static bool loopback;
 
 static int pio2_match(struct vme_dev *);
 static int __devinit pio2_probe(struct vme_dev *);
Signature · 4 lines
Martyn Welch (Lead Software Engineer)  | Registered in England and Wales
GE Intelligent Platforms               | (3828642) at 100 Barbirolli Square
T +44(0)1327322748                     | Manchester, M2 3AB
E [email protected]                  | VAT:GB 927559189