Skip to contentSkip to conversation

ia32-base.inc: Use '=' for IMAGE_FSTYPES

PATCH Superseded Tom Rini 5 participants 7 messages Mar 23, 2012 – Mar 29, 2012

lore
Share & tools
lore

Tom Rini

author
#0 lore raw

PATCH 1/1 ia32-base.inc: Use '=' for IMAGE_FSTYPES

As per
http://lists.linuxtogo.org/pipermail/openembedded-core/2012-March/019772.html
a machine conf file should use '=' to set IMAGE_FSTYPES.

Cc Kishore Bodke <[email protected]>
Cc Tom Zanussi <[email protected]>
Cc Darren Hart <[email protected]>
Signed-off-by Tom Rini <[email protected]>
---
 conf/machine/include/ia32-base.inc |    2 +-
 1 files changed, 1 insertions(+), 1 deletions(-)
conf/machine/include/ia32-base.inc +1 -1
index 9b2ef5a..74ab5a5 100644
@@ -11,7 +11,7 @@ MACHINE_FEATURES += "kernel26 screen keyboard pci usbhost ext2 ext3 x86 \
 MACHINE_EXTRA_RRECOMMENDS += "kernel-modules eee-acpi-scripts"
 MACHINE_ESSENTIAL_EXTRA_RDEPENDS += "grub"
 
-IMAGE_FSTYPES += "ext3 cpio.gz live"
+IMAGE_FSTYPES = "ext3 cpio.gz live"
 
 KERNEL_IMAGETYPE ?= "bzImage"
Signature · 1 line
1.7.0.4
author
#1 lore raw

PATCH v2 1/1 ia32-base.inc: Use '=+' for IMAGE_FSTYPES

As per
http://lists.linuxtogo.org/pipermail/openembedded-core/2012-March/020053.html
a machine conf file should use '=+' to set IMAGE_FSTYPES.

Cc Kishore Bodke <[email protected]>
Cc Tom Zanussi <[email protected]>
Cc Darren Hart <[email protected]>
Signed-off-by Tom Rini <[email protected]>
---
 conf/machine/include/ia32-base.inc |    2 +-
 1 files changed, 1 insertions(+), 1 deletions(-)
conf/machine/include/ia32-base.inc +1 -1
index 9b2ef5a..817ee2d 100644
@@ -11,7 +11,7 @@ MACHINE_FEATURES += "kernel26 screen keyboard pci usbhost ext2 ext3 x86 \
 MACHINE_EXTRA_RRECOMMENDS += "kernel-modules eee-acpi-scripts"
 MACHINE_ESSENTIAL_EXTRA_RDEPENDS += "grub"
 
-IMAGE_FSTYPES += "ext3 cpio.gz live"
+IMAGE_FSTYPES =+ "ext3 cpio.gz live"
 
 KERNEL_IMAGETYPE ?= "bzImage"
Signature · 1 line
1.7.0.4
#2 lore raw

Re: [meta-intel][PATCH v2] ia32-base.inc: Use '=+' for IMAGE_FSTYPES

conf/machine/include/ia32-base.inc MACHINE_FEATURES += "kernel26 screen keyboard pci usbhost ext2 ext3 x86 \ · line 14

Quoted 3 lines · Tom Rini
conf/machine/include/ia32-base.inc +1 -1
-IMAGE_FSTYPES += "ext3 cpio.gz live"
+IMAGE_FSTYPES =+ "ext3 cpio.gz live"

whats the difference ?

#3 lore raw

Re: [meta-intel][PATCH v2] ia32-base.inc: Use '=+' for IMAGE_FSTYPES

Quoted 6 lines · Khem Raj

conf/machine/include/ia32-base.inc MACHINE_FEATURES += "kernel26 screen keyboard pci usbhost ext2 ext3 x86 \ · line 14

Quoted 3 lines · Tom Rini
conf/machine/include/ia32-base.inc +1 -1
-IMAGE_FSTYPES += "ext3 cpio.gz live"
+IMAGE_FSTYPES =+ "ext3 cpio.gz live"

whats the difference ?

Consistency. Or blame Richard for saying "no, wait, =+" :)

Signature · 1 line
Tom
#4 lore raw

Re: [meta-intel][PATCH v2] ia32-base.inc: Use '=+' for IMAGE_FSTYPES

Quoted 10 lines · Tom Rini
Quoted 6 lines · Khem Raj

conf/machine/include/ia32-base.inc MACHINE_FEATURES += "kernel26 screen keyboard pci usbhost ext2 ext3 x86 \ · line 14

Quoted 3 lines · Tom Rini
conf/machine/include/ia32-base.inc +1 -1
-IMAGE_FSTYPES += "ext3 cpio.gz live"
+IMAGE_FSTYPES =+ "ext3 cpio.gz live"

whats the difference ?

Consistency. Or blame Richard for saying "no, wait, =+" :)

+= append
=+ prepend

Doesn't seem to me that it would impact the final output at all.

Signature · 3 lines
Darren Hart
Intel Open Source Technology Center
Yocto Project - Linux Kernel
#5 lore raw

Re: [meta-intel][PATCH v2] ia32-base.inc: Use '=+' for IMAGE_FSTYPES

Quoted 1 line · Darren Hart

Doesn't seem to me that it would impact the final output at all.

exactly that was my point.