Skip to contentSkip to conversation

libselinux: avc_netlink_recieve handle EINTR FIXME

PATCH In review Daniel J Walsh 2 participants 2 messages Mar 27, 2012 SELinux security module

lore
Share & tools
lore
#0 lore raw

PATCH 43/73 libselinux: avc_netlink_recieve handle EINTR FIXME

-----BEGIN PGP SIGNED MESSAGE-----
Hash: SHA1

This patch looks good to me. acked.

I think we should do this rather then have applications like dbus randomly crash, and people not notice it for years.

-----BEGIN PGP SIGNATURE-----
Version: GnuPG v1.4.12 (GNU/Linux)
Comment: Using GnuPG with Mozilla - http://enigmail.mozdev.org/

iEYEARECAAYFAk9x4d0ACgkQrlYvE4MpobMo3QCgqaLM8fRuIgAu/4T6VgsZEppA ipcAoKLspjezOWW4H2NT8mjcm2UbOuCg
=pAU/
-----END PGP SIGNATURE-----

#1 lore raw
Quoted 4 lines · Daniel J Walsh

This patch looks good to me. acked.

I think we should do this rather then have applications like dbus randomly crash, and people not notice it for years.

Handling of EINTR is a very interesting thing in operating systems. For example, the Python interpreter relies on receiving EINTR from system calls when you press Control-C at the toplevel.

However in this case the AVC thread is hidden from the consumer, so it's clearly correct to retry on EINTR.

--
This message was distributed to subscribers of the selinux mailing list. If you no longer wish to subscribe, send mail to [email protected] with the words "unsubscribe selinux" without quotes as the message.