Skip to contentSkip to conversation

Broken LVDS output at mode changes

PATCH Takashi Iwai 5 participants 11 messages Mar 28, 2012 – Mar 30, 2012

Subsystems (2)
lore
Share & tools
lore
#0 lore raw

Hi,

we've encountered a broken LVDS output on some IVY/SNB machines when the mode is changed (from/to native resolution). When this happens, the whole laptop panel gets half white and half black. This doesn't recover until the LVDS is turned off once.

And, there is no signficant difference between working and non-working cases in the register dumps. From the software POV, all looks sane. So, we suspect this is rather specific to some panel hardware.

However, through debugging, I found that disabling LVDS at mode change works around the problem. A test patch is attached below.

My question now is: can this workaround have any serious drawback? I thought of a longer blank time, but I didn't notice any difference before and after the patch.

Or, any other suggestion as a saner fix?

thanks,

Takashi

---

---
 drivers/gpu/drm/i915/intel_lvds.c |   23 ++++++++++++++++++++++-
 1 file changed, 22 insertions(+), 1 deletion(-)
drivers/gpu/drm/i915/intel_lvds.c +22 -1
@@ -398,6 +398,26 @@ out:
 	return true;
 }
 
+static int intel_disable_at_modeset_callback(const struct dmi_system_id *id)
+{
+	DRM_DEBUG_KMS("Disabling LVDS at modeset for %s\n", id->ident);
+	return 1;
+}
+
+/* Requires to disable LVDS for avoiding a broken screen at mode change */
+static const struct dmi_system_id intel_disable_at_modeset[] = {
+	{
+		.callback = intel_disable_at_modeset_callback,
+		.ident = "HP ProBook",
+		.matches = {
+			DMI_MATCH(DMI_SYS_VENDOR, "Hewlett-Packard"),
+			DMI_MATCH(DMI_PRODUCT_NAME, "HP ProBook"),
+		},
+	},
+
+	{ }	/* terminating entry */
+};
+
 static void intel_lvds_prepare(struct drm_encoder *encoder)
 {
 	struct intel_lvds *intel_lvds = to_intel_lvds(encoder);
@@ -407,7 +427,8 @@ static void intel_lvds_prepare(struct dr
 	 * the panel fitter. However at all other times we can just reset
 	 * the registers regardless.
 	 */
-	if (!HAS_PCH_SPLIT(encoder->dev) && intel_lvds->pfit_dirty)
+	if ((!HAS_PCH_SPLIT(encoder->dev) && intel_lvds->pfit_dirty) ||
+	    dmi_check_system(intel_disable_at_modeset))
 		intel_lvds_disable(intel_lvds);
 }
#1 lore raw
Quoted 11 lines · Takashi Iwai

Hi,

we've encountered a broken LVDS output on some IVY/SNB machines when the mode is changed (from/to native resolution). When this happens, the whole laptop panel gets half white and half black. This doesn't recover until the LVDS is turned off once.

And, there is no signficant difference between working and non-working cases in the register dumps. From the software POV, all looks sane. So, we suspect this is rather specific to some panel hardware.

Quoted 8 lines

However, through debugging, I found that disabling LVDS at mode change works around the problem. A test patch is attached below.

My question now is: can this workaround have any serious drawback? I thought of a longer blank time, but I didn't notice any difference before and after the patch.

Or, any other suggestion as a saner fix?

No idea, I'm wondering though whether we should just accept some flickering while modesetting unconditionally. Does anyone know what Windows does in this case and at least on my work machine here it looks like Windows just blanks the screen. I haven't checked with reg dumps though how exactly they upscale stuff on lvds.

git blame says that Chris Wilson created the original PCH_SPLIT check. Chris, any comments on this?

Yours, Daniel

Quoted 54 lines

thanks,

Takashi

---

---
 drivers/gpu/drm/i915/intel_lvds.c |   23 ++++++++++++++++++++++-
 1 file changed, 22 insertions(+), 1 deletion(-)
drivers/gpu/drm/i915/intel_lvds.c +22 -1
@@ -398,6 +398,26 @@ out:
 	return true;
 }
 
+static int intel_disable_at_modeset_callback(const struct dmi_system_id *id)
+{
+	DRM_DEBUG_KMS("Disabling LVDS at modeset for %s\n", id->ident);
+	return 1;
+}
+
+/* Requires to disable LVDS for avoiding a broken screen at mode change */
+static const struct dmi_system_id intel_disable_at_modeset[] = {
+	{
+		.callback = intel_disable_at_modeset_callback,
+		.ident = "HP ProBook",
+		.matches = {
+			DMI_MATCH(DMI_SYS_VENDOR, "Hewlett-Packard"),
+			DMI_MATCH(DMI_PRODUCT_NAME, "HP ProBook"),
+		},
+	},
+
+	{ }	/* terminating entry */
+};
+
 static void intel_lvds_prepare(struct drm_encoder *encoder)
 {
 	struct intel_lvds *intel_lvds = to_intel_lvds(encoder);
@@ -407,7 +427,8 @@ static void intel_lvds_prepare(struct dr
 	 * the panel fitter. However at all other times we can just reset
 	 * the registers regardless.
 	 */
-	if (!HAS_PCH_SPLIT(encoder->dev) && intel_lvds->pfit_dirty)
+	if ((!HAS_PCH_SPLIT(encoder->dev) && intel_lvds->pfit_dirty) ||
+	    dmi_check_system(intel_disable_at_modeset))
 		intel_lvds_disable(intel_lvds);
 }
 

_______________________________________________
Intel-gfx mailing list
[email protected]
http://lists.freedesktop.org/mailman/listinfo/intel-gfx

Signature · 3 lines
Daniel Vetter
Mail: [email protected]
Mobile: +41 (0)79 365 57 48
#2 lore raw
Quoted 21 lines · Daniel Vetter
Quoted 11 lines · Takashi Iwai

Hi,

we've encountered a broken LVDS output on some IVY/SNB machines when the mode is changed (from/to native resolution). When this happens, the whole laptop panel gets half white and half black. This doesn't recover until the LVDS is turned off once.

And, there is no signficant difference between working and non-working cases in the register dumps. From the software POV, all looks sane. So, we suspect this is rather specific to some panel hardware.

Quoted 8 lines

However, through debugging, I found that disabling LVDS at mode change works around the problem. A test patch is attached below.

My question now is: can this workaround have any serious drawback? I thought of a longer blank time, but I didn't notice any difference before and after the patch.

Or, any other suggestion as a saner fix?

Quoted 8 lines

No idea, I'm wondering though whether we should just accept some flickering while modesetting unconditionally. Does anyone know what Windows does in this case and at least on my work machine here it looks like Windows just blanks the screen. I haven't checked with reg dumps though how exactly they upscale stuff on lvds.

git blame says that Chris Wilson created the original PCH_SPLIT check. Chris, any comments on this?

It dates back from an earlier commit that presupposes that we can modify the panel on the fly and avoid the power-cycling delays.

PP_STATUS: Panel Power On Status [bit 31]

In conjunction with bits Power Sequence Progress field and Power Cycle Delay Active, this bit set to a one indicates that the panel is currently powered up or is currently in the power down sequence and it is unsafe to change the timing, port, and DPLL registers for the pipe or transcoder that is assigned to the panel output.

Guess that rules that out.
-Chris

Signature · 1 line
Chris Wilson, Intel Open Source Technology Centre
#3 lore raw
Quoted 36 lines · Chris Wilson
Quoted 21 lines · Daniel Vetter
Quoted 11 lines · Takashi Iwai

Hi,

we've encountered a broken LVDS output on some IVY/SNB machines when the mode is changed (from/to native resolution). When this happens, the whole laptop panel gets half white and half black. This doesn't recover until the LVDS is turned off once.

And, there is no signficant difference between working and non-working cases in the register dumps. From the software POV, all looks sane. So, we suspect this is rather specific to some panel hardware.

Quoted 8 lines

However, through debugging, I found that disabling LVDS at mode change works around the problem. A test patch is attached below.

My question now is: can this workaround have any serious drawback? I thought of a longer blank time, but I didn't notice any difference before and after the patch.

Or, any other suggestion as a saner fix?

Quoted 8 lines

No idea, I'm wondering though whether we should just accept some flickering while modesetting unconditionally. Does anyone know what Windows does in this case and at least on my work machine here it looks like Windows just blanks the screen. I haven't checked with reg dumps though how exactly they upscale stuff on lvds.

git blame says that Chris Wilson created the original PCH_SPLIT check. Chris, any comments on this?

It dates back from an earlier commit that presupposes that we can modify the panel on the fly and avoid the power-cycling delays.

PP_STATUS: Panel Power On Status [bit 31]

Quoted 7 lines

In conjunction with bits Power Sequence Progress field and Power Cycle Delay Active, this bit set to a one indicates that the panel is currently powered up or is currently in the power down sequence and it is unsafe to change the timing, port, and DPLL registers for the pipe or transcoder that is assigned to the panel output.

Guess that rules that out.

Takashi, can you respin your patch to just unconditionally switch of the lvds also on PCH_SPLIT platforms then?
-Daniel

Signature · 3 lines
Daniel Vetter
Mail: [email protected]
Mobile: +41 (0)79 365 57 48
#4 lore raw

At Thu, 29 Mar 2012 14:51:32 +0200,

Quoted 44 lines · Daniel Vetter
Quoted 42 lines · Chris Wilson
Quoted 21 lines · Daniel Vetter
Quoted 11 lines · Takashi Iwai

Hi,

we've encountered a broken LVDS output on some IVY/SNB machines when the mode is changed (from/to native resolution). When this happens, the whole laptop panel gets half white and half black. This doesn't recover until the LVDS is turned off once.

And, there is no signficant difference between working and non-working cases in the register dumps. From the software POV, all looks sane. So, we suspect this is rather specific to some panel hardware.

Quoted 8 lines

However, through debugging, I found that disabling LVDS at mode change works around the problem. A test patch is attached below.

My question now is: can this workaround have any serious drawback? I thought of a longer blank time, but I didn't notice any difference before and after the patch.

Or, any other suggestion as a saner fix?

Quoted 8 lines

No idea, I'm wondering though whether we should just accept some flickering while modesetting unconditionally. Does anyone know what Windows does in this case and at least on my work machine here it looks like Windows just blanks the screen. I haven't checked with reg dumps though how exactly they upscale stuff on lvds.

git blame says that Chris Wilson created the original PCH_SPLIT check. Chris, any comments on this?

It dates back from an earlier commit that presupposes that we can modify the panel on the fly and avoid the power-cycling delays.

PP_STATUS: Panel Power On Status [bit 31]

In conjunction with bits Power Sequence Progress field and Power Cycle Delay Active, this bit set to a one indicates that the panel is currently powered up or is currently in the power down sequence and it is unsafe to change the timing, port, and DPLL registers for the pipe or transcoder that is assigned to the panel output.

Quoted 4 lines
Quoted 1 line

Guess that rules that out.

Takashi, can you respin your patch to just unconditionally switch of the lvds also on PCH_SPLIT platforms then?

The hardware I've tested are actually on PCH_SPLIT, IvyBridge and SandyBridge machines. I'll test IronLake and GM45 machines whether unconditonally switching will give any regressions.

Takashi

#5 lore raw
In reply to Chris Wilson

<#part sign=pgpmime>

Quoted 5 lines · Chris Wilson

In conjunction with bits Power Sequence Progress field and Power Cycle Delay Active, this bit set to a one indicates that the panel is currently powered up or is currently in the power down sequence and it is unsafe to change the timing, port, and DPLL registers for the pipe or transcoder that is assigned to the panel output.

The theory was that as we don't touch the DPLL and only modify the scaler, that the panel wouldn't care. I wonder what's confusing this one...

Signature · 1 line
[email protected]
#6 lore raw

At Thu, 29 Mar 2012 08:07:05 -0700,

Quoted 11 lines · Keith Packard
Quoted 5 lines · Chris Wilson

In conjunction with bits Power Sequence Progress field and Power Cycle Delay Active, this bit set to a one indicates that the panel is currently powered up or is currently in the power down sequence and it is unsafe to change the timing, port, and DPLL registers for the pipe or transcoder that is assigned to the panel output.

The theory was that as we don't touch the DPLL and only modify the scaler, that the panel wouldn't care. I wonder what's confusing this one...

The strange thing is that, although you can recover the display by turning off LVDS and on again once when the problem happens, but then the display starts flickering. And, the flickering continues even after reboot on BIOS boot screen. Even BIOS can't recover the problem by itself, too, as it seems. Then, keep the machine rest for long time and boot up, now the problem is gone.

BTW, now I tested to disable LVDS unconditionally on different platforms as Daniel suggested. All worked fine, and I saw no regressions. Tested on IVY, SNB, ILK, GM45 and PineView.

thanks,

Takashi

#7 lore raw

<#part sign=pgpmime>

Quoted 4 lines · Takashi Iwai

The strange thing is that, although you can recover the display by turning off LVDS and on again once when the problem happens, but then the display starts flickering. And, the flickering continues even after reboot on BIOS boot screen.

Yeah, it's clearly the panel which is confused. It would be nice to know what happened to the LVDS signal which caused this problem with the panel.

Quoted 3 lines

BTW, now I tested to disable LVDS unconditionally on different platforms as Daniel suggested. All worked fine, and I saw no regressions. Tested on IVY, SNB, ILK, GM45 and PineView.

That's not surprising -- pre-PCH platforms disabled the LVDS anyways.

I wonder if we could fix this by being more careful about the order of register operations during LVDS mode setting...

Signature · 1 line
[email protected]
#8 lore raw

At Thu, 29 Mar 2012 09:57:41 -0700,

Quoted 4 lines · Keith Packard

<#part sign=pgpmime>
On Thu, 29 Mar 2012 18:12:56 +0200, Takashi Iwai <[email protected]> wrote:

Quoted 8 lines
Quoted 4 lines

The strange thing is that, although you can recover the display by turning off LVDS and on again once when the problem happens, but then the display starts flickering. And, the flickering continues even after reboot on BIOS boot screen.

Yeah, it's clearly the panel which is confused. It would be nice to know what happened to the LVDS signal which caused this problem with the panel.

I'll try to poke someone in HP.

Quoted 9 lines
Quoted 3 lines

BTW, now I tested to disable LVDS unconditionally on different platforms as Daniel suggested. All worked fine, and I saw no regressions. Tested on IVY, SNB, ILK, GM45 and PineView.

That's not surprising -- pre-PCH platforms disabled the LVDS anyways.

I wonder if we could fix this by being more careful about the order of register operations during LVDS mode setting...

Sure, that'd be a preferred option.
If you have any easy test in mind, let me know.

thanks,

Takashi

#9 lore raw

<#part sign=pgpmime>

Quoted 2 lines · Takashi Iwai

Sure, that'd be a preferred option.
If you have any easy test in mind, let me know.

The way I'd love to see it tested would be to capture signal traces on the LVDS link across mode set and see what glitches appear. That sounds hard to do without an LVDS signal analyser...

Signature · 1 line
[email protected]
#10 lore raw
In reply to Chris Wilson
Quoted 36 lines · On Thu, 29 Mar 2012 13:44:28 +0100 Chris Wilson <[email protected]>…
Quoted 21 lines · Daniel Vetter
Quoted 11 lines · Takashi Iwai

Hi,

we've encountered a broken LVDS output on some IVY/SNB machines when the mode is changed (from/to native resolution). When this happens, the whole laptop panel gets half white and half black. This doesn't recover until the LVDS is turned off once.

And, there is no signficant difference between working and non-working cases in the register dumps. From the software POV, all looks sane. So, we suspect this is rather specific to some panel hardware.

Quoted 8 lines

However, through debugging, I found that disabling LVDS at mode change works around the problem. A test patch is attached below.

My question now is: can this workaround have any serious drawback? I thought of a longer blank time, but I didn't notice any difference before and after the patch.

Or, any other suggestion as a saner fix?

Quoted 8 lines

No idea, I'm wondering though whether we should just accept some flickering while modesetting unconditionally. Does anyone know what Windows does in this case and at least on my work machine here it looks like Windows just blanks the screen. I haven't checked with reg dumps though how exactly they upscale stuff on lvds.

git blame says that Chris Wilson created the original PCH_SPLIT check. Chris, any comments on this?

It dates back from an earlier commit that presupposes that we can modify the panel on the fly and avoid the power-cycling delays.

PP_STATUS: Panel Power On Status [bit 31]

Quoted 7 lines

In conjunction with bits Power Sequence Progress field and Power Cycle Delay Active, this bit set to a one indicates that the panel is currently powered up or is currently in the power down sequence and it is unsafe to change the timing, port, and DPLL registers for the pipe or transcoder that is assigned to the panel output.

Guess that rules that out.

Yeah but the docs are too conservative there. In many cases it's fine to modify things while the panel is on, it just requires lots of testing for the different cases.

On newer chips changing the panel fitting should be ok while the panel is active, but on older ones we need to shut down the panel first (I think the split is around Cantiga/Ironlake).

Signature · 1 line
Jesse Barnes, Intel Open Source Technology Center

_______________________________________________
Intel-gfx mailing list
[email protected]
http://lists.freedesktop.org/mailman/listinfo/intel-gfx