ARM: orion5x: Fix GPIO enable bits for MPP9
PATCH v2 1/1 ARM: orion5x: Fix GPIO enable bits for MPP9
Commit 554cdaefd1cf7bb54b209c4e68c7cec87ce442a9 ('ARM: orion5x: Refactor mpp code to use common orion platform mpp.') seems to have accidentally inverted the GPIO valid bits for MPP9 (only). For the mv2120 platform which uses MPP9 as a GPIO LED device, this results in the error:
[ 12.711476] leds-gpio: probe of leds-gpio failed with error -22
References: http://bugs.debian.org/667446
---
v2: Add subject of the earlier commit
Ben.
arch/arm/mach-orion5x/mpp.h | 4 ++-- 1 file changed, 2 insertions(+), 2 deletions(-)
arch/arm/mach-orion5x/mpp.h +2 -2
@@ -65,8 +65,8 @@#define MPP8_GIGE MPP(8, 0x1, 0, 0, 1, 1, 1)#define MPP9_UNUSED MPP(9, 0x0, 0, 0, 1, 1, 1) -#define MPP9_GPIO MPP(9, 0x0, 0, 0, 1, 1, 1) -#define MPP9_GIGE MPP(9, 0x1, 1, 1, 1, 1, 1) +#define MPP9_GPIO MPP(9, 0x0, 1, 1, 1, 1, 1) +#define MPP9_GIGE MPP(9, 0x1, 0, 0, 1, 1, 1)#define MPP10_UNUSED MPP(10, 0x0, 0, 0, 1, 1, 1)#define MPP10_GPIO MPP(10, 0x0, 1, 1, 1, 1, 1)
Signature · 1 line
1.7.9.5
PATCH v2 1/1 ARM: orion5x: Fix GPIO enable bits for MPP9
Quoted 5 lines · Ben Hutchings
Commit
554cdaefd1cf7bb54b209c4e68c7cec87ce442a9('ARM: orion5x: Refactor mpp code to use common orion platform mpp.') seems to have accidentally inverted the GPIO valid bits for MPP9 (only). For the mv2120 platform which uses MPP9 as a GPIO LED device, this results in the error:
Quoted 8 lines
[ 12.711476] leds-gpio: probe of leds-gpio failed with error -22Reported-by Henry von Tresckow <[email protected]>References: http://bugs.debian.org/667446
Signed-off-by Ben Hutchings <[email protected]>Cc stable at vger.kernel.org [v3.0+]---
v2: Add subject of the earlier commit
oops, replied to the earlier one before seeing this one. Playing catchup after the holidays.
Please see my earlier post regarding possible breakage on other boards.
thx,
Jason.
Quoted 28 lines
arch/arm/mach-orion5x/mpp.h | 4 ++-- 1 file changed, 2 insertions(+), 2 deletions(-)arch/arm/mach-orion5x/mpp.h +2
-2@@ -65,8 +65,8 @@#define MPP8_GIGE MPP(8, 0x1, 0, 0, 1, 1, 1)#define MPP9_UNUSED MPP(9, 0x0, 0, 0, 1, 1, 1) -#define MPP9_GPIO MPP(9, 0x0, 0, 0, 1, 1, 1) -#define MPP9_GIGE MPP(9, 0x1, 1, 1, 1, 1, 1) +#define MPP9_GPIO MPP(9, 0x0, 1, 1, 1, 1, 1) +#define MPP9_GIGE MPP(9, 0x1, 0, 0, 1, 1, 1)#define MPP10_UNUSED MPP(10, 0x0, 0, 0, 1, 1, 1)#define MPP10_GPIO MPP(10, 0x0, 1, 1, 1, 1, 1)Signature · 9 lines
1.7.9.5 _______________________________________________ linux-arm-kernel mailing list linux-arm-kernel at lists.infradead.org http://lists.infradead.org/mailman/listinfo/linux-arm-kernel
PATCH v2 1/1 ARM: orion5x: Fix GPIO enable bits for MPP9
In reply to Ben HutchingsQuoted 8 lines · Ben Hutchings
Commit
554cdaefd1cf7bb54b209c4e68c7cec87ce442a9('ARM: orion5x: Refactor mpp code to use common orion platform mpp.') seems to have accidentally inverted the GPIO valid bits for MPP9 (only). For the mv2120 platform which uses MPP9 as a GPIO LED device, this results in the error:[ 12.711476] leds-gpio: probe of leds-gpio failed with error -22Reported-by Henry von Tresckow <[email protected]>
(on the mv2120, and applied to Debian's 3.2 tree)
Quoted 26 lines
References: http://bugs.debian.org/667446
Signed-off-by Ben Hutchings <[email protected]>Cc stable at vger.kernel.org [v3.0+]---
v2: Add subject of the earlier commitBen.
arch/arm/mach-orion5x/mpp.h | 4 ++-- 1 file changed, 2 insertions(+), 2 deletions(-)arch/arm/mach-orion5x/mpp.h +2
-2@@ -65,8 +65,8 @@#define MPP8_GIGE MPP(8, 0x1, 0, 0, 1, 1, 1)#define MPP9_UNUSED MPP(9, 0x0, 0, 0, 1, 1, 1) -#define MPP9_GPIO MPP(9, 0x0, 0, 0, 1, 1, 1) -#define MPP9_GIGE MPP(9, 0x1, 1, 1, 1, 1, 1) +#define MPP9_GPIO MPP(9, 0x0, 1, 1, 1, 1, 1) +#define MPP9_GIGE MPP(9, 0x1, 0, 0, 1, 1, 1)#define MPP10_UNUSED MPP(10, 0x0, 0, 0, 1, 1, 1)#define MPP10_GPIO MPP(10, 0x0, 1, 1, 1, 1, 1)
Signature · 9 lines
Ben Hutchings This sentence contradicts itself - no actually it doesn't. -------------- next part -------------- A non-text attachment was scrubbed... Name: signature.asc Type: application/pgp-signature Size: 828 bytes Desc: This is a digitally signed message part URL: <http://lists.infradead.org/pipermail/linux-arm-kernel/attachments/20120420/945f26f1/attachment.sig>
PATCH v2 1/1 ARM: orion5x: Fix GPIO enable bits for MPP9
Quoted 11 lines · Ben Hutchings
Quoted 8 lines · Ben Hutchings
Commit
554cdaefd1cf7bb54b209c4e68c7cec87ce442a9('ARM: orion5x: Refactor mpp code to use common orion platform mpp.') seems to have accidentally inverted the GPIO valid bits for MPP9 (only). For the mv2120 platform which uses MPP9 as a GPIO LED device, this results in the error:[ 12.711476] leds-gpio: probe of leds-gpio failed with error -22Reported-by Henry von Tresckow <[email protected]>
I'm putting this towards fixes for v3.4, adding the above Tested-by:
thx,
Jason.
Quoted 40 lines
(on the mv2120, and applied to Debian's 3.2 tree)
Quoted 26 lines
References: http://bugs.debian.org/667446
Signed-off-by Ben Hutchings <[email protected]>Cc stable at vger.kernel.org [v3.0+]---
v2: Add subject of the earlier commitBen.
arch/arm/mach-orion5x/mpp.h | 4 ++-- 1 file changed, 2 insertions(+), 2 deletions(-)arch/arm/mach-orion5x/mpp.h +2
-2@@ -65,8 +65,8 @@#define MPP8_GIGE MPP(8, 0x1, 0, 0, 1, 1, 1)#define MPP9_UNUSED MPP(9, 0x0, 0, 0, 1, 1, 1) -#define MPP9_GPIO MPP(9, 0x0, 0, 0, 1, 1, 1) -#define MPP9_GIGE MPP(9, 0x1, 1, 1, 1, 1, 1) +#define MPP9_GPIO MPP(9, 0x0, 1, 1, 1, 1, 1) +#define MPP9_GIGE MPP(9, 0x1, 0, 0, 1, 1, 1)#define MPP10_UNUSED MPP(10, 0x0, 0, 0, 1, 1, 1)#define MPP10_GPIO MPP(10, 0x0, 1, 1, 1, 1, 1)Signature · 9 lines
Ben Hutchings This sentence contradicts itself - no actually it doesn't. _______________________________________________ linux-arm-kernel mailing list linux-arm-kernel at lists.infradead.org http://lists.infradead.org/mailman/listinfo/linux-arm-kernel