Skip to contentSkip to conversation

package: set PKG_CONFIG_SYSROOT_DIR in HOST_MAKE_ENV

PATCH New Sven Neumann 2 participants 3 messages Apr 4, 2012 – Apr 15, 2012

lore
Share & tools
lore

Sven Neumann

author
#0 lore raw

PATCH 1/1 package: set PKG_CONFIG_SYSROOT_DIR in HOST_MAKE_ENV

A host package that uses AUTORECONF (such as host-libglib2) may end up running './config.status --recheck'. This will call the configure script with the environment variables set in HOST_MAKE_ENV. If PKG_CONFIG_SYSROOT_DIR is missing this will cause the hardcoded sysroot dir take effect leading to wrong paths.

See commit 22acade2ec311 which works around this problem by fiddling with the generated .pc file. This commit becomes obsolete with this fix.

Signed-off-by Sven Neumann <[email protected]>
Cc Daniel Mack <[email protected]>
---
 package/Makefile.in |    1 +
 1 files changed, 1 insertions(+), 0 deletions(-)
package/Makefile.in +1 -0
index dc8d038..c344c6b 100644
@@ -222,6 +222,7 @@ HOST_CONFIGURE_OPTS=PATH=$(HOST_PATH) \
 HOST_MAKE_ENV=PATH=$(HOST_PATH) \
 		LD_LIBRARY_PATH="$(HOST_DIR)/usr/lib:$(LD_LIBRARY_PATH)" \
 		PKG_CONFIG="$(PKG_CONFIG_HOST_BINARY)" \
+		PKG_CONFIG_SYSROOT_DIR="/" \
 		PKG_CONFIG_LIBDIR="$(HOST_DIR)/usr/lib/pkgconfig" \
 		PERLLIB="$(HOST_DIR)/usr/lib/perl"
Signature · 1 line
1.7.9.1
author
#1 lore raw

PATCH 1/1 package: set PKG_CONFIG_SYSROOT_DIR in HOST_MAKE_ENV

Hi,

Quoted 22 lines · Sven Neumann

A host package that uses AUTORECONF (such as host-libglib2) may end up running './config.status --recheck'. This will call the configure script with the environment variables set in HOST_MAKE_ENV. If PKG_CONFIG_SYSROOT_DIR is missing this will cause the hardcoded sysroot dir take effect leading to wrong paths.

See commit 22acade2ec311 which works around this problem by fiddling with the generated .pc file. This commit becomes obsolete with this fix.22acade2ec311

Signed-off-by Sven Neumann <[email protected]>
Cc Daniel Mack <[email protected]>
---
 package/Makefile.in |    1 +
 1 files changed, 1 insertions(+), 0 deletions(-)
package/Makefile.in +0 -0
index dc8d038..c344c6b 100644

package/Makefile.in HOST_CONFIGURE_OPTS=PATH=$(HOST_PATH) \ · line 228

Quoted 7 lines
package/Makefile.in +1 -0
@@ -222,6 +222,7 @@ HOST_CONFIGURE_OPTS=PATH=$(HOST_PATH) \
 HOST_MAKE_ENV=PATH=$(HOST_PATH) \
 		LD_LIBRARY_PATH="$(HOST_DIR)/usr/lib:$(LD_LIBRARY_PATH)" \
 		PKG_CONFIG="$(PKG_CONFIG_HOST_BINARY)" \
+		PKG_CONFIG_SYSROOT_DIR="/" \
 		PKG_CONFIG_LIBDIR="$(HOST_DIR)/usr/lib/pkgconfig" \
 		PERLLIB="$(HOST_DIR)/usr/lib/perl"

Any feedback on this? This small change fixes an important problem and makes the workaround from 22acade2ec311 obsolete. Please consider it for inclusion.

Regards,
Sven

#2 lore raw

PATCH 1/1 package: set PKG_CONFIG_SYSROOT_DIR in HOST_MAKE_ENV

In reply to Sven Neumann
Quoted 1 line
Quoted 1 line
Quoted 1 line
Quoted 1 line
Quoted 1 line

"Sven" == Sven Neumann <[email protected]> writes:

Sven> A host package that uses AUTORECONF (such as host-libglib2) Sven> may end up running './config.status --recheck'. This will Sven> call the configure script with the environment variables Sven> set in HOST_MAKE_ENV. If PKG_CONFIG_SYSROOT_DIR is missing Sven> this will cause the hardcoded sysroot dir take effect leading Sven> to wrong paths.

Committed, thanks.

Signature · 1 line
Bye, Peter Korsgaard