Skip to contentSkip to conversation

GFS2: Rename function gfs2_close to gfs2_release

PATCH New Bob Peterson 2 participants 2 messages Apr 11, 2012 – Apr 12, 2012 1 message not in the archive GFS2 file system

lore
Share & tools
lore

A message that is not in the archive (sent off-list or not yet received): 0630d251-a5cc-446a-bc7a-1e87e75ab0e8@zmail12.collab.prod.int.phx2.redhat.com

#1 lore raw

PATCH 1/5 GFS2: Rename function gfs2_close to gfs2_release

Hi,

This patch renames function gfs2_close to gfs2_release.

Regards,

Bob Peterson
Red Hat File Systems

---
From: Bob Peterson <[email protected]>
Date: Mon, 12 Mar 2012 10:56:01 -0500
Subject: [PATCH 1/5] GFS2: Rename function gfs2_close to gfs2_release

VFS now calls a release function where it used to call a close function. This patch renames gfs2_close to gfs2_release so that it makes more sense to someone reading the code.

---
 fs/gfs2/file.c |   12 ++++++------
 1 files changed, 6 insertions(+), 6 deletions(-)
fs/gfs2/file.c +6 -6
index 7683458..916490f 100644
@@ -559,14 +559,14 @@ fail:
 }
 
 /**
- * gfs2_close - called to close a struct file
+ * gfs2_release - called to close a struct file
  * @inode: the inode the struct file belongs to
  * @file: the struct file being closed
  *
  * Returns: errno
  */
 
-static int gfs2_close(struct inode *inode, struct file *file)
+static int gfs2_release(struct inode *inode, struct file *file)
 {
 	struct gfs2_sbd *sdp = inode->i_sb->s_fs_info;
 	struct gfs2_file *fp;
@@ -1006,7 +1006,7 @@ const struct file_operations gfs2_file_fops = {
 	.unlocked_ioctl	= gfs2_ioctl,
 	.mmap		= gfs2_mmap,
 	.open		= gfs2_open,
-	.release	= gfs2_close,
+	.release	= gfs2_release,
 	.fsync		= gfs2_fsync,
 	.lock		= gfs2_lock,
 	.flock		= gfs2_flock,
@@ -1020,7 +1020,7 @@ const struct file_operations gfs2_dir_fops = {
 	.readdir	= gfs2_readdir,
 	.unlocked_ioctl	= gfs2_ioctl,
 	.open		= gfs2_open,
-	.release	= gfs2_close,
+	.release	= gfs2_release,
 	.fsync		= gfs2_fsync,
 	.lock		= gfs2_lock,
 	.flock		= gfs2_flock,
@@ -1038,7 +1038,7 @@ const struct file_operations gfs2_file_fops_nolock = {
 	.unlocked_ioctl	= gfs2_ioctl,
 	.mmap		= gfs2_mmap,
 	.open		= gfs2_open,
-	.release	= gfs2_close,
+	.release	= gfs2_release,
 	.fsync		= gfs2_fsync,
 	.splice_read	= generic_file_splice_read,
 	.splice_write	= generic_file_splice_write,
@@ -1050,7 +1050,7 @@ const struct file_operations gfs2_dir_fops_nolock = {
 	.readdir	= gfs2_readdir,
 	.unlocked_ioctl	= gfs2_ioctl,
 	.open		= gfs2_open,
-	.release	= gfs2_close,
+	.release	= gfs2_release,
 	.fsync		= gfs2_fsync,
 	.llseek		= default_llseek,
 };
Signature · 1 line
1.7.7.6
#2 lore raw

PATCH 1/5 GFS2: Rename function gfs2_close to gfs2_release

Hi,

All five patches are in the -nmw tree now. Thanks,

Steve.

Quoted 79 lines · Bob Peterson

Hi,

This patch renames function gfs2_close to gfs2_release.

Regards,

Bob Peterson
Red Hat File Systems

---
From: Bob Peterson <[email protected]>
Date: Mon, 12 Mar 2012 10:56:01 -0500
Subject: [PATCH 1/5] GFS2: Rename function gfs2_close to gfs2_release

VFS now calls a release function where it used to call a close function. This patch renames gfs2_close to gfs2_release so that it makes more sense to someone reading the code.

---
 fs/gfs2/file.c |   12 ++++++------
 1 files changed, 6 insertions(+), 6 deletions(-)
fs/gfs2/file.c +6 -6
index 7683458..916490f 100644
@@ -559,14 +559,14 @@ fail:
 }
 
 /**
- * gfs2_close - called to close a struct file
+ * gfs2_release - called to close a struct file
  * @inode: the inode the struct file belongs to
  * @file: the struct file being closed
  *
  * Returns: errno
  */
 
-static int gfs2_close(struct inode *inode, struct file *file)
+static int gfs2_release(struct inode *inode, struct file *file)
 {
 	struct gfs2_sbd *sdp = inode->i_sb->s_fs_info;
 	struct gfs2_file *fp;
@@ -1006,7 +1006,7 @@ const struct file_operations gfs2_file_fops = {
 	.unlocked_ioctl	= gfs2_ioctl,
 	.mmap		= gfs2_mmap,
 	.open		= gfs2_open,
-	.release	= gfs2_close,
+	.release	= gfs2_release,
 	.fsync		= gfs2_fsync,
 	.lock		= gfs2_lock,
 	.flock		= gfs2_flock,
@@ -1020,7 +1020,7 @@ const struct file_operations gfs2_dir_fops = {
 	.readdir	= gfs2_readdir,
 	.unlocked_ioctl	= gfs2_ioctl,
 	.open		= gfs2_open,
-	.release	= gfs2_close,
+	.release	= gfs2_release,
 	.fsync		= gfs2_fsync,
 	.lock		= gfs2_lock,
 	.flock		= gfs2_flock,
@@ -1038,7 +1038,7 @@ const struct file_operations gfs2_file_fops_nolock = {
 	.unlocked_ioctl	= gfs2_ioctl,
 	.mmap		= gfs2_mmap,
 	.open		= gfs2_open,
-	.release	= gfs2_close,
+	.release	= gfs2_release,
 	.fsync		= gfs2_fsync,
 	.splice_read	= generic_file_splice_read,
 	.splice_write	= generic_file_splice_write,
@@ -1050,7 +1050,7 @@ const struct file_operations gfs2_dir_fops_nolock = {
 	.readdir	= gfs2_readdir,
 	.unlocked_ioctl	= gfs2_ioctl,
 	.open		= gfs2_open,
-	.release	= gfs2_close,
+	.release	= gfs2_release,
 	.fsync		= gfs2_fsync,
 	.llseek		= default_llseek,
 };