virtio_ring: remove unused code in virtqueue_notify()
PATCH 1/1 virtio_ring: remove unused code in virtqueue_notify()
From: Zhi Yong Wu <[email protected]>
Signed-off-by Zhi Yong Wu <[email protected]>
--- drivers/virtio/virtio_ring.c | 2 -- 1 files changed, 0 insertions(+), 2 deletions(-)
drivers/virtio/virtio_ring.c +0 -2
@@ -343,8 +343,6 @@ EXPORT_SYMBOL_GPL(virtqueue_kick_prepare);*/ void virtqueue_notify (struct virtqueue *_vq) { -struct vring_virtqueue *vq =to_vvq (_vq); -/* Prod other side to tell it about changes. */ vq->notify (_vq); }
Signature · 1 line
1.7.6
Quoted 12 lines · On Fri, Apr 13, 2012 at 11:26:03AM +0800, [email protected] wrote:
From: Zhi Yong Wu <[email protected]>
Signed-off-by Zhi Yong Wu <[email protected]>--- drivers/virtio/virtio_ring.c | 2 -- 1 files changed, 0 insertions(+), 2 deletions(-)drivers/virtio/virtio_ring.c +0
-0
drivers/virtio/virtio_ring.c EXPORT_SYMBOL_GPL(virtqueue_kick_prepare); · line 347
Quoted 7 lines
drivers/virtio/virtio_ring.c +0
-2@@ -343,8 +343,6 @@ EXPORT_SYMBOL_GPL(virtqueue_kick_prepare);*/ void virtqueue_notify (struct virtqueue *_vq) { -struct vring_virtqueue *vq =to_vvq (_vq); -/* Prod other side to tell it about changes. */ vq->notify (_vq);
vq->notify() uses 'vq'. How does this work?
Stefan
Quoted 8 lines · Stefan Hajnoczi
Quoted 7 lines · On Fri, Apr 13, 2012 at 11:26:03AM +0800, [email protected] wrote:
From: Zhi Yong Wu <[email protected]>
Signed-off-by Zhi Yong Wu <[email protected]>---
drivers/virtio/virtio_ring.c | 2 --1 files changed, 0 insertions(+), 2 deletions(-)
Quoted 14 lines
drivers/virtio/virtio_ring.c EXPORT_SYMBOL_GPL(virtqueue_kick_prepare); · line 347
Quoted 12 lines
drivers/virtio/virtio_ring.c +0
-2@@ -343,8 +343,6 @@ EXPORT_SYMBOL_GPL(virtqueue_kick_prepare);*/ void virtqueue_notify(struct virtqueue *_vq) { - struct vring_virtqueue *vq = to_vvq(_vq); - /* Prod other side to tell it about changes. */ vq->notify(_vq);
vq->notify()uses 'vq'. How does this work?
sorry, i missed vq->notify. thanks
Quoted 3 lines
Stefan
Signature · 3 lines
Regards, Zhi Yong Wu