Skip to contentSkip to conversation

prlimit: remove bogus instructions

PATCH Applied Davidlohr Bueso 2 participants 2 messages Apr 14, 2012 – Apr 23, 2012 Util-Linux package

lore
Share & tools
lore

Davidlohr Bueso

author
#0 lore raw

PATCH 1/1 prlimit: remove bogus instructions

From: Davidlohr Bueso <[email protected]>

usage() is noreturn!

Signed-off-by Davidlohr Bueso <[email protected]>
---
 sys-utils/prlimit.c |    2 --
 1 files changed, 0 insertions(+), 2 deletions(-)
sys-utils/prlimit.c +0 -2
index 12271a0..7e52a2d 100644
@@ -585,7 +585,6 @@ int main(int argc, char **argv)
 			break;
 		case 'h':
 			usage(stdout);
-			break;
 		case 'o':
 			ncolumns = string_to_idarray(optarg,
 						     columns, ARRAY_SIZE(columns),

@@ -609,7 +608,6 @@ int main(int argc, char **argv)
 
 		default:
 			usage(stderr);
-			break;
 		}
 	}
 	if (argc > optind && pid)
Signature · 1 line
1.7.4.1
maintainer Applied
#1 lore raw
Quoted 2 lines · Davidlohr Bueso

sys-utils/prlimit.c | 2 --

1 files changed, 0 insertions(+), 2 deletions(-)

Applied, thanks.

BTW, some (including really expensive) static analyzers have no clue about 'noreturn' function attribute :-)

Karel

Signature · 2 lines
 Karel Zak  <[email protected]>
 http://karelzak.blogspot.com